From dd4d7301bab06bd8bf861f7078ec160ea3bbcff8 Mon Sep 17 00:00:00 2001 From: Spencer Date: Tue, 14 Apr 2026 18:26:00 +0000 Subject: [PATCH] fix: remove global string slice to guarantee JSON parseability --- packages/core/src/telemetry/trace.test.ts | 12 ------------ packages/core/src/telemetry/trace.ts | 8 -------- 2 files changed, 20 deletions(-) diff --git a/packages/core/src/telemetry/trace.test.ts b/packages/core/src/telemetry/trace.test.ts index 965740d944..e9d2dc47dd 100644 --- a/packages/core/src/telemetry/trace.test.ts +++ b/packages/core/src/telemetry/trace.test.ts @@ -124,18 +124,6 @@ describe('truncateForTelemetry', () => { ); }); - it('should enforce a global payload string limit', () => { - const obj = { - a: 'x'.repeat(100), - b: 'y'.repeat(100), - }; - // Let's cap global string length to 50 - const result = truncateForTelemetry(obj, 100, 100, 4, 50) as string; - expect(result.length).toBeGreaterThan(50); - expect(result).toContain('...[TRUNCATED: original payload length'); - expect(result.startsWith('{"a":"xxxx')).toBe(true); - }); - it('should stringify objects unchanged if within maxLength', () => { const obj = { a: 1 }; expect(truncateForTelemetry(obj, 100)).toBe(JSON.stringify(obj)); diff --git a/packages/core/src/telemetry/trace.ts b/packages/core/src/telemetry/trace.ts index eff442ea4e..bd9b32c119 100644 --- a/packages/core/src/telemetry/trace.ts +++ b/packages/core/src/telemetry/trace.ts @@ -67,7 +67,6 @@ export function truncateForTelemetry( maxStringLength = 10000, maxArrayLength = 100, maxDepth = 4, - maxGlobalStringLength = 50000, ): AttributeValue | undefined { const truncateObj = (v: unknown, depth: number): unknown => { if (typeof v === 'string') { @@ -149,13 +148,6 @@ export function truncateForTelemetry( } const stringified = safeJsonStringify(truncated); - if (stringified.length > maxGlobalStringLength) { - const graphemes = Array.from(stringified); - if (graphemes.length > maxGlobalStringLength) { - return (graphemes.slice(0, maxGlobalStringLength).join('') + - `...[TRUNCATED: original payload length ${graphemes.length}]`) as AttributeValue; - } - } return stringified as AttributeValue; }