From dea79901a51543c9020933b6710b814916bdeaac Mon Sep 17 00:00:00 2001 From: mkorwel Date: Thu, 23 Oct 2025 09:30:32 -0700 Subject: [PATCH] fix(release): update docker push action to use ghcr.io Updates the release-sandbox workflow to use the push-docker action, which is configured to push to ghcr.io. Also updates the push-docker action to use `github.repository_owner` as the username for ghcr.io login, which is the recommended practice. --- .github/actions/push-docker/action.yml | 2 +- .github/workflows/release-sandbox.yml | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/actions/push-docker/action.yml b/.github/actions/push-docker/action.yml index 2589601a97..01d6aeea46 100644 --- a/.github/actions/push-docker/action.yml +++ b/.github/actions/push-docker/action.yml @@ -46,7 +46,7 @@ runs: uses: 'docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1' # ratchet:docker/login-action@v3 with: registry: 'ghcr.io' - username: '${{ inputs.github-actor }}' + username: '${{ github.repository_owner }}' password: '${{ inputs.github-secret }}' - name: 'Get branch name' id: 'branch_name' diff --git a/.github/workflows/release-sandbox.yml b/.github/workflows/release-sandbox.yml index 8dcad3e39a..4d35ee10dd 100644 --- a/.github/workflows/release-sandbox.yml +++ b/.github/workflows/release-sandbox.yml @@ -28,15 +28,12 @@ jobs: ref: '${{ github.event.inputs.ref || github.sha }}' fetch-depth: 0 - name: 'Push' - uses: './.github/actions/push-sandbox' + uses: './.github/actions/push-docker' with: - dockerhub-username: '${{ secrets.DOCKER_SERVICE_ACCOUNT_NAME }}' - dockerhub-token: '${{ secrets.DOCKER_SERVICE_ACCOUNT_KEY }}' github-actor: '${{ github.actor }}' github-secret: '${{ secrets.GITHUB_TOKEN }}' github-sha: '${{ github.sha }}' - github-ref-name: '${{github.event.inputs.ref}}' - dry-run: '${{ github.event.inputs.dry-run }}' + ref-name: '${{github.event.inputs.ref}}' - name: 'Create Issue on Failure' if: '${{ failure() && github.event.inputs.dry-run == false }}' env: