MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-07-04 23:27:00 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: address review bot feedback on concurrency and error handling

Browse Source 
- Reverted the 'isIdle' guard in AppContainer.tsx to ensure slash commands entered while the agent is busy are correctly processed or queued, preventing them from falling through as regular chat text.
- Enhanced the physical path validation in config.ts to gracefully handle 'mkdirSync' failures (e.g. EACCES). The CLI will now log a warning and return the lexically-validated path instead of throwing a misleading 'Security violation' via 'resolveToRealPath'.
This commit is contained in:
Mahima Shanware
2026-04-07 05:44:46 +00:00
parent 7c0cfd53df
commit df8f1a8f03
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/AppContainer.tsx
+1 -1
View File
@@ -1366,7 +1366,7 @@ Logging in with Google... Restarting Gemini CLI to continue.
}
const isMcpOrConfigReady = isConfigInitialized && isMcpReady;
if (isIdle && ((isSlash && isConfigInitialized) || isMcpOrConfigReady)) {
if ((isSlash && isConfigInitialized) || (isIdle && isMcpOrConfigReady)) {
if (!isSlash) {
const permissions = await checkPermissions(submittedValue, config);
if (permissions.length > 0) {