Update banner design (#13420)

This commit is contained in:
Adib234
2025-11-20 08:52:15 -08:00
committed by GitHub
parent 4adfdad47f
commit e20d282088
3 changed files with 63 additions and 27 deletions

View File

@@ -10,11 +10,9 @@ import { Tips } from './Tips.js';
import { useSettings } from '../contexts/SettingsContext.js';
import { useConfig } from '../contexts/ConfigContext.js';
import { useUIState } from '../contexts/UIStateContext.js';
import { Banner } from './Banner.js';
import { theme } from '../semantic-colors.js';
import { Colors } from '../colors.js';
import { persistentState } from '../../utils/persistentState.js';
import { useState, useEffect, useRef } from 'react';
import { useEffect, useRef, useState } from 'react';
import { Banner } from './Banner.js';
interface AppHeaderProps {
version: string;
@@ -35,11 +33,8 @@ export const AppHeader = ({ version }: AppHeaderProps) => {
warningText === '' &&
!config.getPreviewFeatures() &&
defaultBannerShownCount < 5;
const bannerText = showDefaultBanner ? defaultText : warningText;
const unescapedBannerText = bannerText.replace(/\\n/g, '\n');
const defaultColor = Colors.AccentBlue;
const fontColor = warningText === '' ? defaultColor : theme.status.warning;
const bannerText = showDefaultBanner ? defaultText : warningText;
const hasIncrementedRef = useRef(false);
useEffect(() => {
@@ -55,11 +50,11 @@ export const AppHeader = ({ version }: AppHeaderProps) => {
{!(settings.merged.ui?.hideBanner || config.getScreenReader()) && (
<>
<Header version={version} nightly={nightly} />
{bannerVisible && unescapedBannerText && (
{bannerVisible && bannerText && (
<Banner
width={mainAreaWidth}
bannerText={unescapedBannerText}
color={fontColor}
bannerText={bannerText}
isWarning={warningText !== ''}
/>
)}
</>