MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-25 12:34:38 -07:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): finish createHookScript refactor and cleanup

Browse Source 
- Ensure all hook tests use rig.createHookScript for consistent path normalization.
- Remove unused writeFileSync and readFileSync imports from integration tests.
- Fix assertions in 'input override' test to match new .cjs extension and be more robust.
This commit is contained in:
Abhi
2026-02-06 13:19:31 -05:00
parent e1d8cc78d7
commit e2b96018bd
3 changed files with 151 additions and 155 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-tests/hooks-agent-flow.test.ts
+18 -25
View File
@@ -7,7 +7,6 @@
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import { TestRig } from './test-helper.js';
import { join } from 'node:path';
import { writeFileSync } from 'node:fs';
describe('Hooks Agent Flow', () => {
let rig: TestRig;
@@ -49,11 +48,10 @@ describe('Hooks Agent Flow', () => {
console.error('DEBUG: BeforeAgent hook executed');
`;
const scriptPath = join(rig.testDir!, 'before_agent_context.cjs').replace(
/\\/g,
'/',
const scriptPath = rig.createHookScript(
'before_agent_context.cjs',
hookScript,
);
writeFileSync(scriptPath, hookScript);
await rig.configure({
settings: {
@@ -118,11 +116,10 @@ describe('Hooks Agent Flow', () => {
}
`;
const scriptPath = join(rig.testDir!, 'after_agent_verify.cjs').replace(
/\\/g,
'/',
const scriptPath = rig.createHookScript(
'after_agent_verify.cjs',
hookScript,
);
writeFileSync(scriptPath, hookScript);
await rig.configure({
settings: {
@@ -182,11 +179,10 @@ describe('Hooks Agent Flow', () => {
fs.writeFileSync('${messageCountFile}', JSON.stringify(counts));
console.log(JSON.stringify({ decision: 'allow' }));
`;
const beforeModelScriptPath = join(
rig.testDir!,
const beforeModelScriptPath = rig.createHookScript(
'before_model_counter.cjs',
).replace(/\\/g, '/');
writeFileSync(beforeModelScriptPath, beforeModelScript);
beforeModelScript,
);
const afterAgentScript = `
console.log(JSON.stringify({
@@ -198,11 +194,10 @@ describe('Hooks Agent Flow', () => {
}
}));
`;
const afterAgentScriptPath = join(
rig.testDir!,
const afterAgentScriptPath = rig.createHookScript(
'after_agent_clear.cjs',
).replace(/\\/g, '/');
writeFileSync(afterAgentScriptPath, afterAgentScript);
afterAgentScript,
);
await rig.configure({
fakeResponsesPath: join(
@@ -270,18 +265,16 @@ describe('Hooks Agent Flow', () => {
);
const beforeAgentScript = "console.log('BeforeAgent Fired')";
const beforeAgentScriptPath = join(
rig.testDir!,
const beforeAgentScriptPath = rig.createHookScript(
'before_agent_loop.cjs',
).replace(/\\/g, '/');
writeFileSync(beforeAgentScriptPath, beforeAgentScript);
beforeAgentScript,
);
const afterAgentScript = "console.log('AfterAgent Fired')";
const afterAgentScriptPath = join(
rig.testDir!,
const afterAgentScriptPath = rig.createHookScript(
'after_agent_loop.cjs',
).replace(/\\/g, '/');
writeFileSync(afterAgentScriptPath, afterAgentScript);
afterAgentScript,
);
await rig.configure({
fakeResponsesPath: join(