From e63d273e4e242caff6ee6fdc1b87b0b2c8d12443 Mon Sep 17 00:00:00 2001 From: "N. Taylor Mullen" Date: Wed, 4 Mar 2026 13:20:08 -0800 Subject: [PATCH] fix(ui): suppress redundant failure note when tool error note is shown (#21078) --- packages/cli/src/ui/hooks/useGeminiStream.test.tsx | 4 ++-- packages/cli/src/ui/hooks/useGeminiStream.ts | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/cli/src/ui/hooks/useGeminiStream.test.tsx b/packages/cli/src/ui/hooks/useGeminiStream.test.tsx index 25fbb8f451..ec8ea0751a 100644 --- a/packages/cli/src/ui/hooks/useGeminiStream.test.tsx +++ b/packages/cli/src/ui/hooks/useGeminiStream.test.tsx @@ -1050,9 +1050,9 @@ describe('useGeminiStream', () => { ); expect(noteIndex).toBeGreaterThanOrEqual(0); expect(stopIndex).toBeGreaterThanOrEqual(0); - expect(failureHintIndex).toBeGreaterThanOrEqual(0); + // The failure hint should NOT be present if the suppressed error note was shown + expect(failureHintIndex).toBe(-1); expect(noteIndex).toBeLessThan(stopIndex); - expect(stopIndex).toBeLessThan(failureHintIndex); }); it('should group multiple cancelled tool call responses into a single history entry', async () => { diff --git a/packages/cli/src/ui/hooks/useGeminiStream.ts b/packages/cli/src/ui/hooks/useGeminiStream.ts index 2add6b6adc..3066d1c173 100644 --- a/packages/cli/src/ui/hooks/useGeminiStream.ts +++ b/packages/cli/src/ui/hooks/useGeminiStream.ts @@ -596,7 +596,10 @@ export const useGeminiStream = ( if (!isLowErrorVerbosity || config.getDebugMode()) { return; } - if (lowVerbosityFailureNoteShownRef.current) { + if ( + lowVerbosityFailureNoteShownRef.current || + suppressedToolErrorNoteShownRef.current + ) { return; }