MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-02 01:11:24 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(core): fallback to chat-base when using unrecognized models for chat (#19016)

Browse Source
This commit is contained in:
Sandy Tao
2026-02-13 11:00:08 -08:00
committed by GitHub
parent 9c285eaf15
commit e844a57bfc
4 changed files with 100 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
packages/core/src/core/client.test.ts
View File

@@ -892,7 +892,7 @@ ${JSON.stringify(
// Assert
expect(ideContextStore.get).toHaveBeenCalled();
expect(mockTurnRunFn).toHaveBeenCalledWith(
{ model: 'default-routed-model' },
{ model: 'default-routed-model', isChatModel: true },
initialRequest,
expect.any(AbortSignal),
undefined,
@@ -1722,7 +1722,7 @@ ${JSON.stringify(
expect(mockConfig.getModelRouterService).toHaveBeenCalled();
expect(mockRouterService.route).toHaveBeenCalled();
expect(mockTurnRunFn).toHaveBeenCalledWith(
{ model: 'routed-model' },
{ model: 'routed-model', isChatModel: true },
[{ text: 'Hi' }],
expect.any(AbortSignal),
undefined,
@@ -1740,7 +1740,7 @@ ${JSON.stringify(
expect(mockRouterService.route).toHaveBeenCalledTimes(1);
expect(mockTurnRunFn).toHaveBeenCalledWith(
{ model: 'routed-model' },
{ model: 'routed-model', isChatModel: true },
[{ text: 'Hi' }],
expect.any(AbortSignal),
undefined,
@@ -1758,7 +1758,7 @@ ${JSON.stringify(
expect(mockRouterService.route).toHaveBeenCalledTimes(1);
// Should stick to the first model
expect(mockTurnRunFn).toHaveBeenCalledWith(
{ model: 'routed-model' },
{ model: 'routed-model', isChatModel: true },
[{ text: 'Continue' }],
expect.any(AbortSignal),
undefined,
@@ -1776,7 +1776,7 @@ ${JSON.stringify(
expect(mockRouterService.route).toHaveBeenCalledTimes(1);
expect(mockTurnRunFn).toHaveBeenCalledWith(
{ model: 'routed-model' },
{ model: 'routed-model', isChatModel: true },
[{ text: 'Hi' }],
expect.any(AbortSignal),
undefined,
@@ -1798,7 +1798,7 @@ ${JSON.stringify(
expect(mockRouterService.route).toHaveBeenCalledTimes(2);
// Should use the newly routed model
expect(mockTurnRunFn).toHaveBeenCalledWith(
{ model: 'new-routed-model' },
{ model: 'new-routed-model', isChatModel: true },
[{ text: 'A new topic' }],
expect.any(AbortSignal),
undefined,
@@ -1826,7 +1826,7 @@ ${JSON.stringify(
expect(mockRouterService.route).toHaveBeenCalledTimes(1);
expect(mockTurnRunFn).toHaveBeenNthCalledWith(
1,
{ model: 'original-model' },
{ model: 'original-model', isChatModel: true },
[{ text: 'Hi' }],
expect.any(AbortSignal),
undefined,
@@ -1849,7 +1849,7 @@ ${JSON.stringify(
expect(mockRouterService.route).toHaveBeenCalledTimes(2);
expect(mockTurnRunFn).toHaveBeenNthCalledWith(
2,
{ model: 'fallback-model' },
{ model: 'fallback-model', isChatModel: true },
[{ text: 'Continue' }],
expect.any(AbortSignal),
undefined,
@@ -1935,7 +1935,7 @@ ${JSON.stringify(
// First call with original request
expect(mockTurnRunFn).toHaveBeenNthCalledWith(
1,
{ model: 'default-routed-model' },
{ model: 'default-routed-model', isChatModel: true },
initialRequest,
expect.any(AbortSignal),
undefined,
@@ -1944,7 +1944,7 @@ ${JSON.stringify(
// Second call with "Please continue."
expect(mockTurnRunFn).toHaveBeenNthCalledWith(
2,
{ model: 'default-routed-model' },
{ model: 'default-routed-model', isChatModel: true },
[{ text: 'System: Please continue.' }],
expect.any(AbortSignal),
undefined,

5
packages/core/src/core/client.ts
View File

@@ -656,7 +656,10 @@ export class GeminiClient {
}
// availability logic
const modelConfigKey: ModelConfigKey = { model: modelToUse };
const modelConfigKey: ModelConfigKey = {
model: modelToUse,
isChatModel: true,
};
const { model: finalModel } = applyModelSelection(
this.config,
modelConfigKey,