From e9c7a80b12d4a0a5f21af604c85e44f9916a6faa Mon Sep 17 00:00:00 2001 From: Sehoon Shon Date: Fri, 31 Oct 2025 14:52:56 -0400 Subject: [PATCH] migrate console.error to coreEvents for mcp-client-manager and google-auth-provider (#12342) --- packages/core/src/mcp/google-auth-provider.ts | 6 +++++- packages/core/src/tools/mcp-client-manager.ts | 6 ++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/core/src/mcp/google-auth-provider.ts b/packages/core/src/mcp/google-auth-provider.ts index d152b4d256..6196914cb4 100644 --- a/packages/core/src/mcp/google-auth-provider.ts +++ b/packages/core/src/mcp/google-auth-provider.ts @@ -14,6 +14,7 @@ import type { import { GoogleAuth } from 'google-auth-library'; import type { MCPServerConfig } from '../config/config.js'; import { FIVE_MIN_BUFFER_MS } from './oauth-utils.js'; +import { coreEvents } from '../utils/events.js'; const ALLOWED_HOSTS = [/^.+\.googleapis\.com$/, /^(.*\.)?luci\.app$/]; @@ -85,7 +86,10 @@ export class GoogleCredentialProvider implements OAuthClientProvider { const accessTokenResponse = await client.getAccessToken(); if (!accessTokenResponse.token) { - console.error('Failed to get access token from Google ADC'); + coreEvents.emitFeedback( + 'error', + 'Failed to get access token from Google ADC', + ); return undefined; } diff --git a/packages/core/src/tools/mcp-client-manager.ts b/packages/core/src/tools/mcp-client-manager.ts index 1116778125..0b8f2180d2 100644 --- a/packages/core/src/tools/mcp-client-manager.ts +++ b/packages/core/src/tools/mcp-client-manager.ts @@ -220,8 +220,10 @@ export class McpClientManager { try { await client.disconnect(); } catch (error) { - console.error( - `Error stopping client '${name}': ${getErrorMessage(error)}`, + coreEvents.emitFeedback( + 'error', + `Error stopping client '${name}':`, + error, ); } },