MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-07-10 01:50:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(core): implement JIT plan directory provisioning with path safety

Browse Source
This commit is contained in:
Mahima Shanware
2026-04-14 05:45:22 +00:00
parent b143c40bbe
commit ece2b0c3a0
2 changed files with 98 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/tools/enter-plan-mode.test.ts
+60 -2
View File
@@ -39,6 +39,8 @@ describe('EnterPlanModeTool', () => {
mockConfig = {
setApprovalMode: vi.fn(),
getExtensions: vi.fn().mockReturnValue([]),
getExtensionSetting: vi.fn(),
storage: {
getPlansDir: vi.fn().mockReturnValue('/mock/plans/dir'),
} as unknown as Config['storage'],
@@ -132,15 +134,71 @@ describe('EnterPlanModeTool', () => {
expect(result.returnDisplay).toBe('Switching to Plan mode');
});
it('should create plans directory if it does not exist', async () => {
const invocation = tool.build({});
it('should create custom plan directories for active extensions', async () => {
vi.mocked(mockConfig.getExtensions!).mockReturnValue([
{
name: 'ext-a',
isActive: true,
} as import('../config/config.js').GeminiCLIExtension,
{
name: 'ext-b',
isActive: false,
} as import('../config/config.js').GeminiCLIExtension,
]);
vi.mocked(mockConfig.getExtensionSetting!).mockImplementation(
(name, setting) => {
if (name === 'ext-a' && setting === 'plan.directory')
return '.ext-a-plans';
return undefined;
},
);
vi.mocked(mockConfig.storage!.getPlansDir).mockImplementation(
(customDir?: string) => {
if (customDir === '.ext-a-plans') return '/mock/plans/ext-a-plans';
return '/mock/plans/dir';
},
);
vi.mocked(fs.existsSync).mockReturnValue(false);
const invocation = tool.build({});
await invocation.execute({ abortSignal: new AbortController().signal });
expect(fs.mkdirSync).toHaveBeenCalledWith('/mock/plans/dir', {
recursive: true,
});
expect(fs.mkdirSync).toHaveBeenCalledWith('/mock/plans/ext-a-plans', {
recursive: true,
});
expect(fs.mkdirSync).toHaveBeenCalledTimes(2);
});
it('should ignore validation failures for extension-specific plan directories', async () => {
vi.mocked(mockConfig.getExtensions!).mockReturnValue([
{
name: 'ext-a',
isActive: true,
} as import('../config/config.js').GeminiCLIExtension,
]);
vi.mocked(mockConfig.getExtensionSetting!).mockReturnValue(
'../outside-workspace',
);
vi.mocked(mockConfig.storage!.getPlansDir).mockImplementation(
(customDir?: string) => {
if (customDir === '../outside-workspace')
throw new Error('Path traversal detected');
return '/mock/plans/dir';
},
);
vi.mocked(fs.existsSync).mockReturnValue(false);
const invocation = tool.build({});
await invocation.execute({ abortSignal: new AbortController().signal });
// Should only create the default one
expect(fs.mkdirSync).toHaveBeenCalledWith('/mock/plans/dir', {
recursive: true,
});
expect(fs.mkdirSync).toHaveBeenCalledTimes(1);
});
it('should include optional reason in output display but not in llmContent', async () => {