From ed65a2ff4e3e00a4957f527b3e1380977d4a22d7 Mon Sep 17 00:00:00 2001 From: jacob314 Date: Tue, 10 Mar 2026 13:59:15 -0700 Subject: [PATCH] fix(ui): address remaining migration bug and test snapshot --- packages/cli/src/config/settings.ts | 6 +++--- .../__snapshots__/ConfigInitDisplay.test.tsx.snap | 6 ------ .../ui/components/__snapshots__/StatusDisplay.test.tsx.snap | 2 +- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/cli/src/config/settings.ts b/packages/cli/src/config/settings.ts index dc20575458..806cbb50a2 100644 --- a/packages/cli/src/config/settings.ts +++ b/packages/cli/src/config/settings.ts @@ -932,14 +932,14 @@ export function migrateDeprecatedSettings( } } - // Migrate enableLoadingPhrases: false → loadingPhraseLayout: 'none' + // Migrate enableLoadingPhrases: false → loadingPhrases: 'off' const enableLP = newAccessibility['enableLoadingPhrases']; if ( typeof enableLP === 'boolean' && - newUi['loadingPhraseLayout'] === undefined + newUi['loadingPhrases'] === undefined ) { if (!enableLP) { - newUi['loadingPhraseLayout'] = 'none'; + newUi['loadingPhrases'] = 'off'; loadedSettings.setValue(scope, 'ui', newUi); if (!settingsFile.readOnly) { anyModified = true; diff --git a/packages/cli/src/ui/components/__snapshots__/ConfigInitDisplay.test.tsx.snap b/packages/cli/src/ui/components/__snapshots__/ConfigInitDisplay.test.tsx.snap index 1b14fadf55..8d03baaa49 100644 --- a/packages/cli/src/ui/components/__snapshots__/ConfigInitDisplay.test.tsx.snap +++ b/packages/cli/src/ui/components/__snapshots__/ConfigInitDisplay.test.tsx.snap @@ -18,12 +18,6 @@ Spinner Connecting to MCP servers... (0/5) - Waiting for: s1, s2, s3, +2 more " `; -exports[`ConfigInitDisplay > truncates list of waiting servers if too many 2`] = ` -" -Spinner Connecting to MCP servers... (0/5) - Waiting for: s1, s2, s3, +2 more -" -`; - exports[`ConfigInitDisplay > updates message on McpClientUpdate event 1`] = ` " Spinner Connecting to MCP servers... (1/2) - Waiting for: server2 diff --git a/packages/cli/src/ui/components/__snapshots__/StatusDisplay.test.tsx.snap b/packages/cli/src/ui/components/__snapshots__/StatusDisplay.test.tsx.snap index 2e6b4b75ad..2620531cc3 100644 --- a/packages/cli/src/ui/components/__snapshots__/StatusDisplay.test.tsx.snap +++ b/packages/cli/src/ui/components/__snapshots__/StatusDisplay.test.tsx.snap @@ -11,7 +11,7 @@ exports[`StatusDisplay > renders ContextSummaryDisplay by default 1`] = ` `; exports[`StatusDisplay > renders HookStatusDisplay when hooks are active 1`] = ` -"Mock Context Summary Display (Skills: 2, Shells: 0) +"Mock Hook Status Display " `;