diff --git a/packages/core/src/code_assist/oauth2.ts b/packages/core/src/code_assist/oauth2.ts index 7f59ee1da1..d5f1db8a8e 100644 --- a/packages/core/src/code_assist/oauth2.ts +++ b/packages/core/src/code_assist/oauth2.ts @@ -117,6 +117,12 @@ async function initOauthClient( authType: AuthType, config: Config, ): Promise { + const recordOnboardingEndIfApplicable = () => { + if (authType === AuthType.LOGIN_WITH_GOOGLE) { + recordOnboardingEnd(config); + } + }; + const credentials = await fetchCachedCredentials(); if ( @@ -172,10 +178,6 @@ async function initOauthClient( } await triggerPostAuthCallbacks(tokens); - - if (authType === AuthType.LOGIN_WITH_GOOGLE) { - recordOnboardingEnd(config); - } }); if (credentials) { @@ -201,10 +203,6 @@ async function initOauthClient( debugLogger.log('Loaded cached credentials.'); await triggerPostAuthCallbacks(credentials as Credentials); - if (authType === AuthType.LOGIN_WITH_GOOGLE) { - recordOnboardingEnd(config); - } - return client; } } catch (error) { @@ -296,9 +294,7 @@ async function initOauthClient( } await triggerPostAuthCallbacks(client.credentials); - if (authType === AuthType.LOGIN_WITH_GOOGLE) { - recordOnboardingEnd(config); - } + recordOnboardingEndIfApplicable(); } else { // In ACP mode, we skip the interactive consent and directly open the browser if (!config.getAcpMode()) { @@ -405,9 +401,7 @@ async function initOauthClient( }); await triggerPostAuthCallbacks(client.credentials); - if (authType === AuthType.LOGIN_WITH_GOOGLE) { - recordOnboardingEnd(config); - } + recordOnboardingEndIfApplicable(); } return client; diff --git a/packages/core/src/telemetry/metrics.ts b/packages/core/src/telemetry/metrics.ts index 75228ae2a5..72abfab8aa 100644 --- a/packages/core/src/telemetry/metrics.ts +++ b/packages/core/src/telemetry/metrics.ts @@ -266,6 +266,7 @@ const COUNTER_DEFINITIONS = { assign: (c: Counter) => (tokenStorageTypeCounter = c), // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion attributes: {} as { + type: string; forced: boolean; }, },