From f339e61a55aaee04acda7c763dec13765e50feb6 Mon Sep 17 00:00:00 2001 From: Spencer Date: Tue, 24 Mar 2026 17:27:13 +0000 Subject: [PATCH] chore: fix TS compilation errors resulting from rebase --- .../components/ApprovalModeIndicator.test.tsx | 2 +- .../ui/hooks/useApprovalModeIndicator.test.ts | 34 ++++++------------- .../src/scheduler/scheduler_hooks.test.ts | 6 ++-- .../src/test-utils/mockWorkspaceContext.ts | 1 - 4 files changed, 15 insertions(+), 28 deletions(-) diff --git a/packages/cli/src/ui/components/ApprovalModeIndicator.test.tsx b/packages/cli/src/ui/components/ApprovalModeIndicator.test.tsx index 07ce90e3be..f58db43269 100644 --- a/packages/cli/src/ui/components/ApprovalModeIndicator.test.tsx +++ b/packages/cli/src/ui/components/ApprovalModeIndicator.test.tsx @@ -35,7 +35,7 @@ describe('ApprovalModeIndicator', () => { }); it('renders correctly for YOLO mode', async () => { - const { lastFrame, waitUntilReady } = await render( + const { lastFrame } = await render( { expect(mockConfigInstance.getApprovalMode).toHaveBeenCalledTimes(1); }); - it('should initialize with ApprovalMode.YOLO if config.getApprovalMode returns ApprovalMode.YOLO', async () => { - mockConfigInstance.getApprovalMode.mockReturnValue(ApprovalMode.YOLO); - const { result } = await renderHook(() => - useApprovalModeIndicator({ - config: mockConfigInstance as unknown as ActualConfigType, - addItem: vi.fn(), - }), - ); - expect(result.current).toBe(ApprovalMode.YOLO); - expect(mockConfigInstance.getApprovalMode).toHaveBeenCalledTimes(1); - }); - it('should cycle the indicator and update config when Shift+Tab or Ctrl+Y is pressed', async () => { mockConfigInstance.getApprovalMode.mockReturnValue(ApprovalMode.DEFAULT); const { result } = await renderHook(() => @@ -200,9 +188,9 @@ describe('useApprovalModeIndicator', () => { capturedUseKeypressHandler({ name: 'y', ctrl: true } as Key); }); expect(mockConfigInstance.setApprovalMode).toHaveBeenCalledWith( - ApprovalMode.YOLO, + ApprovalMode.DEFAULT, ); - expect(result.current).toBe(ApprovalMode.YOLO); + expect(result.current).toBe(ApprovalMode.DEFAULT); // Shift+Tab cycles back to AUTO_EDIT (from YOLO) act(() => { @@ -221,9 +209,9 @@ describe('useApprovalModeIndicator', () => { capturedUseKeypressHandler({ name: 'y', ctrl: true } as Key); }); expect(mockConfigInstance.setApprovalMode).toHaveBeenCalledWith( - ApprovalMode.YOLO, + ApprovalMode.DEFAULT, ); - expect(result.current).toBe(ApprovalMode.YOLO); + expect(result.current).toBe(ApprovalMode.DEFAULT); // Shift+Tab from YOLO jumps to AUTO_EDIT act(() => { @@ -349,7 +337,7 @@ describe('useApprovalModeIndicator', () => { // We expect setApprovalMode to be called, and the error to be caught. expect(mockConfigInstance.setApprovalMode).toHaveBeenCalledWith( - ApprovalMode.YOLO, + ApprovalMode.DEFAULT, ); expect(mockAddItem).toHaveBeenCalled(); // Verify the underlying config value was not changed @@ -390,7 +378,7 @@ describe('useApprovalModeIndicator', () => { }); it('should disable YOLO mode when Ctrl+Y is pressed', async () => { - mockConfigInstance.getApprovalMode.mockReturnValue(ApprovalMode.YOLO); + mockConfigInstance.getApprovalMode.mockReturnValue(ApprovalMode.DEFAULT); const mockAddItem = vi.fn(); await renderHook(() => useApprovalModeIndicator({ @@ -594,9 +582,9 @@ describe('useApprovalModeIndicator', () => { }); expect(mockConfigInstance.setApprovalMode).toHaveBeenCalledWith( - ApprovalMode.YOLO, + ApprovalMode.DEFAULT, ); - expect(mockOnApprovalModeChange).toHaveBeenCalledWith(ApprovalMode.YOLO); + expect(mockOnApprovalModeChange).toHaveBeenCalledWith(ApprovalMode.DEFAULT); }); it('should call onApprovalModeChange when switching to AUTO_EDIT mode', async () => { @@ -624,7 +612,7 @@ describe('useApprovalModeIndicator', () => { }); it('should call onApprovalModeChange when switching to DEFAULT mode', async () => { - mockConfigInstance.getApprovalMode.mockReturnValue(ApprovalMode.YOLO); + mockConfigInstance.getApprovalMode.mockReturnValue(ApprovalMode.DEFAULT); const mockOnApprovalModeChange = vi.fn(); @@ -659,7 +647,7 @@ describe('useApprovalModeIndicator', () => { }); expect(mockConfigInstance.setApprovalMode).toHaveBeenCalledWith( - ApprovalMode.YOLO, + ApprovalMode.DEFAULT, ); // Should not throw an error when callback is not provided }); @@ -689,7 +677,7 @@ describe('useApprovalModeIndicator', () => { expect(mockOnApprovalModeChange).toHaveBeenCalledTimes(2); expect(mockOnApprovalModeChange).toHaveBeenNthCalledWith( 1, - ApprovalMode.YOLO, + ApprovalMode.DEFAULT, ); expect(mockOnApprovalModeChange).toHaveBeenNthCalledWith( 2, diff --git a/packages/core/src/scheduler/scheduler_hooks.test.ts b/packages/core/src/scheduler/scheduler_hooks.test.ts index 3134ccd701..cf847c2ff8 100644 --- a/packages/core/src/scheduler/scheduler_hooks.test.ts +++ b/packages/core/src/scheduler/scheduler_hooks.test.ts @@ -103,7 +103,7 @@ describe('Scheduler Hooks', () => { const mockConfig = createMockConfig({ getToolRegistry: () => toolRegistry, getMessageBus: () => mockMessageBus, - getApprovalMode: () => ApprovalMode.YOLO, + getApprovalMode: () => ApprovalMode.DEFAULT, }); const hookSystem = new HookSystem(mockConfig); @@ -172,7 +172,7 @@ describe('Scheduler Hooks', () => { const mockConfig = createMockConfig({ getToolRegistry: () => toolRegistry, getMessageBus: () => mockMessageBus, - getApprovalMode: () => ApprovalMode.YOLO, + getApprovalMode: () => ApprovalMode.DEFAULT, }); const hookSystem = new HookSystem(mockConfig); @@ -243,7 +243,7 @@ describe('Scheduler Hooks', () => { const mockConfig = createMockConfig({ getToolRegistry: () => toolRegistry, getMessageBus: () => mockMessageBus, - getApprovalMode: () => ApprovalMode.YOLO, + getApprovalMode: () => ApprovalMode.DEFAULT, }); const hookSystem = new HookSystem(mockConfig); diff --git a/packages/core/src/test-utils/mockWorkspaceContext.ts b/packages/core/src/test-utils/mockWorkspaceContext.ts index 640b51f616..67c614e9f5 100644 --- a/packages/core/src/test-utils/mockWorkspaceContext.ts +++ b/packages/core/src/test-utils/mockWorkspaceContext.ts @@ -19,7 +19,6 @@ export function createMockWorkspaceContext( ): WorkspaceContext { const allDirs = [rootDir, ...additionalDirs]; - // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion const mockWorkspaceContext = { addDirectory: vi.fn(), getDirectories: vi.fn().mockReturnValue(allDirs),