MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-08 04:10:35 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): resolve skill uninstall failure when skill name is updated (#22085)

Browse Source
This commit is contained in:
N. Taylor Mullen
2026-03-11 16:23:20 -07:00
committed by GitHub
parent 4a6d1fad9d
commit f368e80baf
2 changed files with 97 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/cli/src/utils/skillUtils.ts
View File

@@ -269,14 +269,32 @@ export async function uninstallSkill(
? storage.getProjectSkillsDir()
: Storage.getUserSkillsDir();
const skillPath = path.join(targetDir, name);
// Load all skills in the target directory to find the one with the matching name
const discoveredSkills = await loadSkillsFromDir(targetDir);
const skillToUninstall = discoveredSkills.find((s) => s.name === name);
const exists = await fs.stat(skillPath).catch(() => null);
if (!skillToUninstall) {
// Fallback: Check if a directory with the given name exists.
// This maintains backward compatibility for cases where the metadata might be missing or corrupted
// but the directory name matches the user's request.
const skillPath = path.resolve(targetDir, name);
if (!exists) {
return null;
// Security check: ensure the resolved path is within the target directory to prevent path traversal
if (!skillPath.startsWith(path.resolve(targetDir))) {
return null;
}
const exists = await fs.lstat(skillPath).catch(() => null);
if (!exists) {
return null;
}
await fs.rm(skillPath, { recursive: true, force: true });
return { location: skillPath };
}
await fs.rm(skillPath, { recursive: true, force: true });
return { location: skillPath };
const skillDir = path.dirname(skillToUninstall.location);
await fs.rm(skillDir, { recursive: true, force: true });
return { location: skillDir };
}