fix(async): prevent missed async errors from bypassing catch handlers (#13714)

Co-authored-by: Tommaso Sciortino <sciortino@gmail.com>

packages/core/src/code_assist/experiments/client_metadata.ts

@@ -52,5 +52,5 @@ export async function getClientMetadata(): Promise<ClientMetadata> {
       updateChannel: await getReleaseChannel(__dirname),
     }))();
   }
-  return await clientMetadataPromise;
+  return clientMetadataPromise;
 }

packages/core/src/code_assist/experiments/experiments.ts

@@ -24,7 +24,7 @@ export async function getExperiments(
   server: CodeAssistServer,
 ): Promise<Experiments> {
   if (experimentsPromise) {
-    return await experimentsPromise;
+    return experimentsPromise;
   }
 
   experimentsPromise = (async () => {
@@ -32,7 +32,7 @@ export async function getExperiments(
     const response = await server.listExperiments(metadata);
     return parseExperiments(response);
   })();
-  return await experimentsPromise;
+  return experimentsPromise;
 }
 
 function parseExperiments(response: ListExperimentsResponse): Experiments {

packages/core/src/code_assist/oauth2.ts

@@ -546,7 +546,7 @@ async function fetchCachedCredentials(): Promise<
 > {
   const useEncryptedStorage = getUseEncryptedStorageFlag();
   if (useEncryptedStorage) {
-    return await OAuthCredentialStorage.loadCredentials();
+    return OAuthCredentialStorage.loadCredentials();
   }
 
   const pathsToTry = [

packages/core/src/code_assist/server.ts

@@ -102,10 +102,7 @@ export class CodeAssistServer implements ContentGenerator {
   async onboardUser(
     req: OnboardUserRequest,
   ): Promise<LongRunningOperationResponse> {
-    return await this.requestPost<LongRunningOperationResponse>(
-      'onboardUser',
-      req,
-    );
+    return this.requestPost<LongRunningOperationResponse>('onboardUser', req);
   }
 
   async loadCodeAssist(
@@ -128,7 +125,7 @@ export class CodeAssistServer implements ContentGenerator {
   }
 
   async getCodeAssistGlobalUserSetting(): Promise<CodeAssistGlobalUserSettingResponse> {
-    return await this.requestGet<CodeAssistGlobalUserSettingResponse>(
+    return this.requestGet<CodeAssistGlobalUserSettingResponse>(
       'getCodeAssistGlobalUserSetting',
     );
   }
@@ -136,7 +133,7 @@ export class CodeAssistServer implements ContentGenerator {
   async setCodeAssistGlobalUserSetting(
     req: SetCodeAssistGlobalUserSettingRequest,
   ): Promise<CodeAssistGlobalUserSettingResponse> {
-    return await this.requestPost<CodeAssistGlobalUserSettingResponse>(
+    return this.requestPost<CodeAssistGlobalUserSettingResponse>(
       'setCodeAssistGlobalUserSetting',
       req,
     );
@@ -167,16 +164,13 @@ export class CodeAssistServer implements ContentGenerator {
       project: projectId,
       metadata: { ...metadata, duetProject: projectId },
     };
-    return await this.requestPost<ListExperimentsResponse>(
-      'listExperiments',
-      req,
-    );
+    return this.requestPost<ListExperimentsResponse>('listExperiments', req);
   }
 
   async retrieveUserQuota(
     req: RetrieveUserQuotaRequest,
   ): Promise<RetrieveUserQuotaResponse> {
-    return await this.requestPost<RetrieveUserQuotaResponse>(
+    return this.requestPost<RetrieveUserQuotaResponse>(
       'retrieveUserQuota',
       req,
     );