MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-12 12:54:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

test(ui): update snapshots and address reviewer feedback

Browse Source
This commit is contained in:
Keith Guerin
2026-02-27 16:25:23 -08:00
parent e7a2b1864b
commit f576e5b55b
8 changed files with 123 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/__snapshots__/App.test.tsx.snap
+12 -11
View File
@@ -9,10 +9,10 @@ exports[`App > Snapshots > renders default layout correctly 1`] = `
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
@@ -54,9 +54,10 @@ Footer
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
Composer Composer
" "
`; `;
@@ -113,9 +114,10 @@ exports[`App > should render ToolConfirmationQueue along with Composer when tool
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
HistoryItemDisplay HistoryItemDisplay
╭──────────────────────────────────────────────────────────────────────────────────────────────────╮ ╭──────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Action Required │ │ Action Required │
@@ -141,7 +143,6 @@ HistoryItemDisplay
Notifications Notifications
Composer Composer
" "
packages/cli/src/ui/components/Tips.test.tsx
+10 -10
View File
@@ -1,28 +1,28 @@
/** /**
* @license * @license
* Copyright 2025 Google LLC * Copyright 2026 Google LLC
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
import { render } from '../../test-utils/render.js'; import { render } from '../../test-utils/render.js';
import { Tips } from './Tips.js'; import { Tips } from './Tips.js';
import { describe, it, expect } from 'vitest'; import { describe, it, expect, vi } from 'vitest';
import type { Config } from '@google/gemini-cli-core'; import type { Config } from '@google/gemini-cli-core';
describe('Tips', () => { describe('Tips', () => {
it('renders correct tips', async () => { it.each([
const config = {} as unknown as Config; { fileCount: 0, description: 'renders all tips including GEMINI.md tip' },
{ fileCount: 5, description: 'renders fewer tips when GEMINI.md exists' },
])('$description', async ({ fileCount }) => {
const config = {
getGeminiMdFileCount: vi.fn().mockReturnValue(fileCount),
} as unknown as Config;
const { lastFrame, waitUntilReady, unmount } = render( const { lastFrame, waitUntilReady, unmount } = render(
<Tips config={config} />, <Tips config={config} />,
); );
await waitUntilReady(); await waitUntilReady();
const output = lastFrame(); expect(lastFrame()).toMatchSnapshot();
expect(output).toContain('1. /help for more information');
expect(output).toContain(
'2. Ask coding questions, edit code or run commands',
);
expect(output).toContain('3. Be specific for the best results');
unmount(); unmount();
}); });
}); });
packages/cli/src/ui/components/Tips.tsx
+27 -13
View File
@@ -1,6 +1,6 @@
/** /**
* @license * @license
* Copyright 2025 Google LLC * Copyright 2026 Google LLC
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
@@ -13,15 +13,29 @@ interface TipsProps {
config: Config; config: Config;
} }
export const Tips: React.FC<TipsProps> = () => ( export const Tips: React.FC<TipsProps> = ({ config }) => {
<Box flexDirection="column" marginTop={1}> const geminiMdFileCount = config.getGeminiMdFileCount();
<Text color={theme.text.primary}>Tips for getting started:</Text>
<Text color={theme.text.primary}> return (
1. <Text color={theme.text.secondary}>/help</Text> for more information <Box flexDirection="column" marginTop={1}>
</Text> <Text color={theme.text.primary}>Tips for getting started:</Text>
<Text color={theme.text.primary}> {geminiMdFileCount === 0 && (
2. Ask coding questions, edit code or run commands <Text color={theme.text.primary}>
</Text> 1. Create <Text bold>GEMINI.md</Text> files to customize your
<Text color={theme.text.primary}>3. Be specific for the best results</Text> interactions
</Box> </Text>
); )}
<Text color={theme.text.primary}>
{geminiMdFileCount === 0 ? '2.' : '1.'}{' '}
<Text color={theme.text.secondary}>/help</Text> for more information
</Text>
<Text color={theme.text.primary}>
{geminiMdFileCount === 0 ? '3.' : '2.'} Ask coding questions, edit code
or run commands
</Text>
<Text color={theme.text.primary}>
{geminiMdFileCount === 0 ? '4.' : '3.'} Be specific for the best results
</Text>
</Box>
);
};
packages/cli/src/ui/components/UserIdentity.tsx
+3 -3
View File
@@ -1,6 +1,6 @@
/** /**
* @license * @license
* Copyright 2025 Google LLC * Copyright 2026 Google LLC
* SPDX-License-Identifier: Apache-2.0 * SPDX-License-Identifier: Apache-2.0
*/ */
@@ -42,7 +42,7 @@ export const UserIdentity: React.FC<UserIdentityProps> = ({ config }) => {
<Box flexDirection="column"> <Box flexDirection="column">
{/* User Email /auth */} {/* User Email /auth */}
<Box> <Box>
<Text color={theme.text.primary}> <Text color={theme.text.primary} wrap="truncate-end">
{authType === AuthType.LOGIN_WITH_GOOGLE ? ( {authType === AuthType.LOGIN_WITH_GOOGLE ? (
<Text>{email ?? 'Logged in with Google'}</Text> <Text>{email ?? 'Logged in with Google'}</Text>
) : ( ) : (
@@ -54,7 +54,7 @@ export const UserIdentity: React.FC<UserIdentityProps> = ({ config }) => {
{/* Tier Name /upgrade */} {/* Tier Name /upgrade */}
<Box> <Box>
<Text color={theme.text.primary}> <Text color={theme.text.primary} wrap="truncate-end">
{tierName ?? 'Gemini Code Assist for individuals'} {tierName ?? 'Gemini Code Assist for individuals'}
</Text> </Text>
<Text color={theme.text.secondary}> /upgrade</Text> <Text color={theme.text.secondary}> /upgrade</Text>
packages/cli/src/ui/components/__snapshots__/AlternateBufferQuittingDisplay.test.tsx.snap
+24 -18
View File
@@ -9,9 +9,10 @@ exports[`AlternateBufferQuittingDisplay > renders with a tool awaiting confirmat
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
Action Required (was prompted): Action Required (was prompted):
@@ -28,9 +29,10 @@ exports[`AlternateBufferQuittingDisplay > renders with active and pending tool m
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
╭──────────────────────────────────────────────────────────────────────────╮ ╭──────────────────────────────────────────────────────────────────────────╮
│ ✓ tool1 Description for tool 1 │ │ ✓ tool1 Description for tool 1 │
│ │ │ │
@@ -51,9 +53,10 @@ exports[`AlternateBufferQuittingDisplay > renders with empty history and no pend
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
" "
`; `;
@@ -66,9 +69,10 @@ exports[`AlternateBufferQuittingDisplay > renders with history but no pending it
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
╭──────────────────────────────────────────────────────────────────────────╮ ╭──────────────────────────────────────────────────────────────────────────╮
│ ✓ tool1 Description for tool 1 │ │ ✓ tool1 Description for tool 1 │
│ │ │ │
@@ -89,9 +93,10 @@ exports[`AlternateBufferQuittingDisplay > renders with pending items but no hist
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
" "
`; `;
@@ -104,9 +109,10 @@ exports[`AlternateBufferQuittingDisplay > renders with user and gemini messages
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀ ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
> Hello Gemini > Hello Gemini
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
packages/cli/src/ui/components/__snapshots__/AppHeader.test.tsx.snap
+16 -12
View File
@@ -9,9 +9,10 @@ exports[`<AppHeader /> > should not render the banner when no flags are set 1`]
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
" "
`; `;
@@ -24,9 +25,10 @@ exports[`<AppHeader /> > should not render the default banner if shown count is
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
" "
`; `;
@@ -42,9 +44,10 @@ exports[`<AppHeader /> > should render the banner with default text 1`] = `
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯ ╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
" "
`; `;
@@ -60,8 +63,9 @@ exports[`<AppHeader /> > should render the banner with warning text 1`] = `
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯ ╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
Tips for getting started: Tips for getting started:
1. /help for more information 1. Create GEMINI.md files to customize your interactions
2. Ask coding questions, edit code or run commands 2. /help for more information
3. Be specific for the best results 3. Ask coding questions, edit code or run commands
4. Be specific for the best results
" "
`; `;
packages/cli/src/ui/components/__snapshots__/Tips.test.tsx.snap
+20
View File
@@ -0,0 +1,20 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
exports[`Tips > 'renders all tips including GEMINI.md …' 1`] = `
"
Tips for getting started:
1. Create GEMINI.md files to customize your interactions
2. /help for more information
3. Ask coding questions, edit code or run commands
4. Be specific for the best results
"
`;
exports[`Tips > 'renders fewer tips when GEMINI.md exi…' 1`] = `
"
Tips for getting started:
1. /help for more information
2. Ask coding questions, edit code or run commands
3. Be specific for the best results
"
`;
packages/cli/src/ui/components/shared/HorizontalLine.tsx
+11 -48
View File
@@ -8,57 +8,20 @@ import type React from 'react';
import { Box } from 'ink'; import { Box } from 'ink';
import { theme } from '../../semantic-colors.js'; import { theme } from '../../semantic-colors.js';
export type LinePosition = 'top' | 'center' | 'bottom';
interface HorizontalLineProps { interface HorizontalLineProps {
color?: string; color?: string;
width?: number | string;
position?: LinePosition;
} }
const overlineStyle = {
top: '‾',
bottom: '',
left: '',
right: '',
topLeft: '',
topRight: '',
bottomLeft: '',
bottomRight: '',
};
const underlineStyle = {
top: '_',
bottom: '',
left: '',
right: '',
topLeft: '',
topRight: '',
bottomLeft: '',
bottomRight: '',
};
export const HorizontalLine: React.FC<HorizontalLineProps> = ({ export const HorizontalLine: React.FC<HorizontalLineProps> = ({
color = theme.border.default, color = theme.border.default,
width = '100%', }) => (
position = 'center', <Box
}) => { width="100%"
const borderStyle = borderStyle="single"
position === 'top' borderTop
? overlineStyle borderBottom={false}
: position === 'bottom' borderLeft={false}
? underlineStyle borderRight={false}
: 'single'; borderColor={color}
/>
return ( );
<Box
width={width}
borderStyle={borderStyle}
borderTop
borderBottom={false}
borderLeft={false}
borderRight={false}
borderColor={color}
/>
);
};