MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-07-15 04:20:57 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): throw explicit error on dropped tool responses (#26668)

Browse Source
This commit is contained in:
Aishanee Shah
2026-05-08 14:36:39 -04:00
committed by GitHub
parent 01635ddb83
commit f86e0ee418
2 changed files with 87 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/agents/local-executor.test.ts
+72 -1
View File
@@ -2227,6 +2227,69 @@ describe('LocalAgentExecutor', () => {
// Agent should terminate with ABORTED status
expect(output.terminate_reason).toBe(AgentTerminateMode.ABORTED);
});
it('should throw a critical error when a tool response is dropped by the scheduler', async () => {
const definition = createTestDefinition([LS_TOOL_NAME]);
const executor = await LocalAgentExecutor.create(
definition,
mockConfig,
onActivity,
);
// Turn 1: Model calls two tools
mockModelResponse([
{ name: LS_TOOL_NAME, args: { path: 'dir1' }, id: 'call1' },
{ name: LS_TOOL_NAME, args: { path: 'dir2' }, id: 'call2' },
]);
// Simulate scheduler returning only ONE result for TWO calls (dropped response)
mockScheduleAgentTools.mockResolvedValueOnce([
{
status: 'success',
request: { callId: 'call1', name: LS_TOOL_NAME },
response: {
responseParts: [
{
functionResponse: {
name: LS_TOOL_NAME,
id: 'call1',
response: { ok: true },
},
},
],
},
},
]);
await expect(
executor.run({ goal: 'Protocol test' }, signal),
).rejects.toThrow(
'Critical System Failure: Tool execution result was lost/dropped by the scheduler',
);
});
it('should throw a critical error when all scheduler results are missing/dropped', async () => {
const definition = createTestDefinition([LS_TOOL_NAME]);
const executor = await LocalAgentExecutor.create(
definition,
mockConfig,
onActivity,
);
// Turn 1: Model calls one tool
mockModelResponse([
{ name: LS_TOOL_NAME, args: { path: 'dir1' }, id: 'call1' },
]);
// Simulate scheduler returning NO results (dropped response)
mockScheduleAgentTools.mockResolvedValueOnce([]);
await expect(
executor.run({ goal: 'Protocol test 2' }, signal),
).rejects.toThrow(
'Critical System Failure: Tool execution result was lost/dropped by the scheduler',
);
});
});
describe('Model Routing', () => {
@@ -2334,7 +2397,15 @@ describe('LocalAgentExecutor', () => {
},
response: {
resultDisplay: 'ls result',
responseParts: [],
responseParts: [
{
functionResponse: {
name: LS_TOOL_NAME,
id: 'call1',
response: { ok: true },
},
},
],
data: {},
},
},