Address feedback

This commit is contained in:
Abhi
2025-12-09 15:54:09 -05:00
committed by Tommaso Sciortino
parent 6d13e0b3a2
commit faf69f2c99
3 changed files with 4 additions and 9 deletions
+1 -1
View File
@@ -827,7 +827,7 @@ their corresponding top-level category object in your `settings.json` file.
- **`experimental.codebaseInvestigatorSettings.model`** (string): - **`experimental.codebaseInvestigatorSettings.model`** (string):
- **Description:** The model to use for the Codebase Investigator agent. - **Description:** The model to use for the Codebase Investigator agent.
- **Default:** `"gemini-2.5-pro"` - **Default:** `"pro"`
- **Requires restart:** Yes - **Requires restart:** Yes
#### `hooks` #### `hooks`
+2 -5
View File
@@ -34,7 +34,6 @@ import { logRipgrepFallback } from '../telemetry/loggers.js';
import { RipgrepFallbackEvent } from '../telemetry/types.js'; import { RipgrepFallbackEvent } from '../telemetry/types.js';
import { ToolRegistry } from '../tools/tool-registry.js'; import { ToolRegistry } from '../tools/tool-registry.js';
import { DEFAULT_MODEL_CONFIGS } from './defaultModelConfigs.js'; import { DEFAULT_MODEL_CONFIGS } from './defaultModelConfigs.js';
import { GEMINI_MODEL_ALIAS_PRO } from './models.js';
vi.mock('fs', async (importOriginal) => { vi.mock('fs', async (importOriginal) => {
const actual = await importOriginal<typeof import('fs')>(); const actual = await importOriginal<typeof import('fs')>();
@@ -889,11 +888,9 @@ describe('Server Config (config.ts)', () => {
expect(SubagentToolWrapperMock).not.toHaveBeenCalled(); expect(SubagentToolWrapperMock).not.toHaveBeenCalled();
}); });
it('should default codebase investigator model to PRO alias', () => { it('should not set default codebase investigator model in config (defaults in registry)', () => {
const config = new Config(baseParams); const config = new Config(baseParams);
expect(config.getCodebaseInvestigatorSettings()?.model).toBe( expect(config.getCodebaseInvestigatorSettings()?.model).toBeUndefined();
GEMINI_MODEL_ALIAS_PRO,
);
}); });
describe('with minified tool class names', () => { describe('with minified tool class names', () => {
+1 -3
View File
@@ -49,7 +49,6 @@ import {
DEFAULT_GEMINI_EMBEDDING_MODEL, DEFAULT_GEMINI_EMBEDDING_MODEL,
DEFAULT_GEMINI_FLASH_MODEL, DEFAULT_GEMINI_FLASH_MODEL,
DEFAULT_THINKING_MODE, DEFAULT_THINKING_MODE,
GEMINI_MODEL_ALIAS_PRO,
} from './models.js'; } from './models.js';
import { shouldAttemptBrowserLaunch } from '../utils/browser.js'; import { shouldAttemptBrowserLaunch } from '../utils/browser.js';
import type { MCPOAuthConfig } from '../mcp/oauth-provider.js'; import type { MCPOAuthConfig } from '../mcp/oauth-provider.js';
@@ -573,8 +572,7 @@ export class Config {
thinkingBudget: thinkingBudget:
params.codebaseInvestigatorSettings?.thinkingBudget ?? params.codebaseInvestigatorSettings?.thinkingBudget ??
DEFAULT_THINKING_MODE, DEFAULT_THINKING_MODE,
model: model: params.codebaseInvestigatorSettings?.model,
params.codebaseInvestigatorSettings?.model ?? GEMINI_MODEL_ALIAS_PRO,
}; };
this.continueOnFailedApiCall = params.continueOnFailedApiCall ?? true; this.continueOnFailedApiCall = params.continueOnFailedApiCall ?? true;
this.enableShellOutputEfficiency = this.enableShellOutputEfficiency =