MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-14 08:01:02 -07:00
Code Issues Packages Projects Releases Wiki Activity

Switch back to truncating headers. Unfortunately we have too many headers that are 10+ lines for no good reason so we need to add back this truncation until we fix them. (#13018)

Browse Source
This commit is contained in:
Jacob Richman
2025-11-13 11:38:19 -08:00
committed by GitHub
parent 60fe5acd60
commit fb99b95372
3 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/cli/src/ui/components/messages/ToolGroupMessage.test.tsx
View File

@@ -202,17 +202,20 @@ describe('<ToolGroupMessage />', () => {
unmount(); unmount();
}); });
it('renders sticky header when scrolled', () => { it('renders header when scrolled', () => {
const toolCalls = [ const toolCalls = [
createToolCall({ createToolCall({
callId: '1', callId: '1',
name: 'tool-1', name: 'tool-1',
description: 'Description 1\n'.repeat(5), description:
'Description 1. This is a long description that will need to be truncated if the terminal width is small.',
resultDisplay: 'line1\nline2\nline3\nline4\nline5',
}), }),
createToolCall({ createToolCall({
callId: '2', callId: '2',
name: 'tool-2', name: 'tool-2',
description: 'Description 2\n'.repeat(5), description: 'Description 2',
resultDisplay: 'line1\nline2',
}), }),
]; ];
const { lastFrame, unmount } = renderWithProviders( const { lastFrame, unmount } = renderWithProviders(

4
packages/cli/src/ui/components/messages/ToolMessage.tsx
View File

@@ -322,8 +322,8 @@ const ToolInfo: React.FC<ToolInfo> = ({
} }
}, [emphasis]); }, [emphasis]);
return ( return (
<Box> <Box overflow="hidden" height={1} flexGrow={1} flexShrink={1}>
<Text strikethrough={status === ToolCallStatus.Canceled}> <Text strikethrough={status === ToolCallStatus.Canceled} wrap="truncate">
<Text color={nameColor} bold> <Text color={nameColor} bold>
{name} {name}
</Text>{' '} </Text>{' '}

35
packages/cli/src/ui/components/messages/__snapshots__/ToolGroupMessage.test.tsx.snap
View File

@@ -30,7 +30,7 @@ exports[`<ToolGroupMessage /> > Border Color Logic > uses yellow border when too
exports[`<ToolGroupMessage /> > Confirmation Handling > shows confirmation dialog for first confirming tool only 1`] = ` exports[`<ToolGroupMessage /> > Confirmation Handling > shows confirmation dialog for first confirming tool only 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────╮ "╭──────────────────────────────────────────────────────────────────────────────╮
│ ? first-confirm A tool for testing ← │ │ ? first-confirm A tool for testing ← │
│ │ │ │
│ Test result │ │ Test result │
│ Confirm first tool │ │ Confirm first tool │
@@ -50,6 +50,19 @@ exports[`<ToolGroupMessage /> > Confirmation Handling > shows confirmation dialo
exports[`<ToolGroupMessage /> > Golden Snapshots > renders empty tool calls array 1`] = `""`; exports[`<ToolGroupMessage /> > Golden Snapshots > renders empty tool calls array 1`] = `""`;
exports[`<ToolGroupMessage /> > Golden Snapshots > renders header when scrolled 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────╮
│ ✓ tool-1 Description 1. This is a long description that will need to be tr… │
│──────────────────────────────────────────────────────────────────────────────│
│ line5 │ █
│ │ █
│ ✓ tool-2 Description 2 │ █
│ │ █
│ line1 │ █
│ line2 │ █
╰──────────────────────────────────────────────────────────────────────────────╯ █"
`;
exports[`<ToolGroupMessage /> > Golden Snapshots > renders mixed tool calls including shell command 1`] = ` exports[`<ToolGroupMessage /> > Golden Snapshots > renders mixed tool calls including shell command 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────╮ "╭──────────────────────────────────────────────────────────────────────────────╮
│ ✓ read_file Read a file │ │ ✓ read_file Read a file │
@@ -98,22 +111,9 @@ exports[`<ToolGroupMessage /> > Golden Snapshots > renders single successful too
╰──────────────────────────────────────────────────────────────────────────────╯" ╰──────────────────────────────────────────────────────────────────────────────╯"
`; `;
exports[`<ToolGroupMessage /> > Golden Snapshots > renders sticky header when scrolled 1`] = `
"│ │
│ ✓ tool-2 Description 2 │
│ Description 2 │
│ Description 2 │
│ Description 2 │ ▄
│ Description 2 │ █
│ │ █
│ │ █
│ Test result │ █
╰──────────────────────────────────────────────────────────────────────────────╯ █"
`;
exports[`<ToolGroupMessage /> > Golden Snapshots > renders tool call awaiting confirmation 1`] = ` exports[`<ToolGroupMessage /> > Golden Snapshots > renders tool call awaiting confirmation 1`] = `
"╭──────────────────────────────────────────────────────────────────────────────╮ "╭──────────────────────────────────────────────────────────────────────────────╮
│ ? confirmation-tool This tool needs confirmation ← │ │ ? confirmation-tool This tool needs confirmation ← │
│ │ │ │
│ Test result │ │ Test result │
│ Are you sure you want to proceed? │ │ Are you sure you want to proceed? │
@@ -158,10 +158,7 @@ exports[`<ToolGroupMessage /> > Golden Snapshots > renders with limited terminal
exports[`<ToolGroupMessage /> > Golden Snapshots > renders with narrow terminal width 1`] = ` exports[`<ToolGroupMessage /> > Golden Snapshots > renders with narrow terminal width 1`] = `
"╭──────────────────────────────────────╮ "╭──────────────────────────────────────╮
│ ✓ very-long-tool-name-that-might-wr │ │ ✓ very-long-tool-name-that-might-w… │
│ ap This is a very long │
│ description that might cause │
│ wrapping issues │
│ │ │ │
│ Test result │ │ Test result │
╰──────────────────────────────────────╯" ╰──────────────────────────────────────╯"