mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-04-22 02:54:31 -07:00
refactor(core): Centralize context management logic into src/context (#24380)
This commit is contained in:
joshualitt
@@ -0,0 +1,262 @@
|
||||
/**
|
||||
* @license
|
||||
* Copyright 2025 Google LLC
|
||||
* SPDX-License-Identifier: Apache-2.0
|
||||
*/
|
||||
|
||||
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
||||
import { ContextManager } from './contextManager.js';
|
||||
import * as memoryDiscovery from '../utils/memoryDiscovery.js';
|
||||
import type { Config } from '../config/config.js';
|
||||
import { coreEvents, CoreEvent } from '../utils/events.js';
|
||||
|
||||
// Mock memoryDiscovery module
|
||||
vi.mock('../utils/memoryDiscovery.js', async (importOriginal) => {
|
||||
const actual =
|
||||
await importOriginal<typeof import('../utils/memoryDiscovery.js')>();
|
||||
return {
|
||||
...actual,
|
||||
getGlobalMemoryPaths: vi.fn(),
|
||||
getUserProjectMemoryPaths: vi.fn(),
|
||||
getExtensionMemoryPaths: vi.fn(),
|
||||
getEnvironmentMemoryPaths: vi.fn(),
|
||||
readGeminiMdFiles: vi.fn(),
|
||||
loadJitSubdirectoryMemory: vi.fn(),
|
||||
deduplicatePathsByFileIdentity: vi.fn(),
|
||||
concatenateInstructions: vi
|
||||
.fn()
|
||||
.mockImplementation(actual.concatenateInstructions),
|
||||
};
|
||||
});
|
||||
|
||||
describe('ContextManager', () => {
|
||||
let contextManager: ContextManager;
|
||||
let mockConfig: Config;
|
||||
|
||||
beforeEach(() => {
|
||||
mockConfig = {
|
||||
getWorkingDir: vi.fn().mockReturnValue('/app'),
|
||||
getImportFormat: vi.fn().mockReturnValue('tree'),
|
||||
getWorkspaceContext: vi.fn().mockReturnValue({
|
||||
getDirectories: vi.fn().mockReturnValue(['/app']),
|
||||
}),
|
||||
getExtensionLoader: vi.fn().mockReturnValue({
|
||||
getExtensions: vi.fn().mockReturnValue([]),
|
||||
}),
|
||||
getMcpClientManager: vi.fn().mockReturnValue({
|
||||
getMcpInstructions: vi.fn().mockReturnValue('MCP Instructions'),
|
||||
}),
|
||||
isTrustedFolder: vi.fn().mockReturnValue(true),
|
||||
getMemoryBoundaryMarkers: vi.fn().mockReturnValue(['.git']),
|
||||
storage: {
|
||||
getProjectMemoryDir: vi
|
||||
.fn()
|
||||
.mockReturnValue('/home/user/.gemini/memory/test-project'),
|
||||
},
|
||||
} as unknown as Config;
|
||||
|
||||
contextManager = new ContextManager(mockConfig);
|
||||
vi.clearAllMocks();
|
||||
vi.spyOn(coreEvents, 'emit');
|
||||
vi.mocked(memoryDiscovery.getExtensionMemoryPaths).mockReturnValue([]);
|
||||
vi.mocked(memoryDiscovery.getUserProjectMemoryPaths).mockResolvedValue([]);
|
||||
// default mock: deduplication returns paths as-is (no deduplication)
|
||||
vi.mocked(
|
||||
memoryDiscovery.deduplicatePathsByFileIdentity,
|
||||
).mockImplementation(async (paths: string[]) => ({
|
||||
paths,
|
||||
identityMap: new Map<string, string>(),
|
||||
}));
|
||||
});
|
||||
|
||||
describe('refresh', () => {
|
||||
it('should load and format global and environment memory', async () => {
|
||||
const globalPaths = ['/home/user/.gemini/GEMINI.md'];
|
||||
const envPaths = ['/app/GEMINI.md'];
|
||||
|
||||
vi.mocked(memoryDiscovery.getGlobalMemoryPaths).mockResolvedValue(
|
||||
globalPaths,
|
||||
);
|
||||
vi.mocked(memoryDiscovery.getEnvironmentMemoryPaths).mockResolvedValue(
|
||||
envPaths,
|
||||
);
|
||||
|
||||
vi.mocked(memoryDiscovery.readGeminiMdFiles).mockResolvedValue([
|
||||
{ filePath: globalPaths[0], content: 'Global Content' },
|
||||
{ filePath: envPaths[0], content: 'Env Content' },
|
||||
]);
|
||||
|
||||
await contextManager.refresh();
|
||||
|
||||
expect(memoryDiscovery.getGlobalMemoryPaths).toHaveBeenCalled();
|
||||
expect(memoryDiscovery.getEnvironmentMemoryPaths).toHaveBeenCalledWith(
|
||||
['/app'],
|
||||
['.git'],
|
||||
);
|
||||
expect(memoryDiscovery.readGeminiMdFiles).toHaveBeenCalledWith(
|
||||
expect.arrayContaining([...globalPaths, ...envPaths]),
|
||||
'tree',
|
||||
['.git'],
|
||||
);
|
||||
|
||||
expect(contextManager.getGlobalMemory()).toContain('Global Content');
|
||||
expect(contextManager.getEnvironmentMemory()).toContain('Env Content');
|
||||
expect(contextManager.getEnvironmentMemory()).toContain(
|
||||
'MCP Instructions',
|
||||
);
|
||||
|
||||
expect(contextManager.getLoadedPaths()).toContain(globalPaths[0]);
|
||||
expect(contextManager.getLoadedPaths()).toContain(envPaths[0]);
|
||||
});
|
||||
|
||||
it('should emit MemoryChanged event when memory is refreshed', async () => {
|
||||
vi.mocked(memoryDiscovery.getGlobalMemoryPaths).mockResolvedValue([
|
||||
'/app/GEMINI.md',
|
||||
]);
|
||||
vi.mocked(memoryDiscovery.getEnvironmentMemoryPaths).mockResolvedValue([
|
||||
'/app/src/GEMINI.md',
|
||||
]);
|
||||
vi.mocked(memoryDiscovery.readGeminiMdFiles).mockResolvedValue([
|
||||
{ filePath: '/app/GEMINI.md', content: 'content' },
|
||||
{ filePath: '/app/src/GEMINI.md', content: 'env content' },
|
||||
]);
|
||||
|
||||
await contextManager.refresh();
|
||||
|
||||
expect(coreEvents.emit).toHaveBeenCalledWith(CoreEvent.MemoryChanged, {
|
||||
fileCount: 2,
|
||||
});
|
||||
});
|
||||
|
||||
it('should not load environment memory if folder is not trusted', async () => {
|
||||
vi.mocked(mockConfig.isTrustedFolder).mockReturnValue(false);
|
||||
vi.mocked(memoryDiscovery.getGlobalMemoryPaths).mockResolvedValue([
|
||||
'/home/user/.gemini/GEMINI.md',
|
||||
]);
|
||||
vi.mocked(memoryDiscovery.readGeminiMdFiles).mockResolvedValue([
|
||||
{ filePath: '/home/user/.gemini/GEMINI.md', content: 'Global Content' },
|
||||
]);
|
||||
|
||||
await contextManager.refresh();
|
||||
|
||||
expect(memoryDiscovery.getEnvironmentMemoryPaths).not.toHaveBeenCalled();
|
||||
expect(contextManager.getEnvironmentMemory()).toBe('');
|
||||
expect(contextManager.getGlobalMemory()).toContain('Global Content');
|
||||
});
|
||||
|
||||
it('should deduplicate files by file identity in case-insensitive filesystems', async () => {
|
||||
const globalPaths = ['/home/user/.gemini/GEMINI.md'];
|
||||
const envPaths = ['/app/gemini.md', '/app/GEMINI.md'];
|
||||
|
||||
vi.mocked(memoryDiscovery.getGlobalMemoryPaths).mockResolvedValue(
|
||||
globalPaths,
|
||||
);
|
||||
vi.mocked(memoryDiscovery.getEnvironmentMemoryPaths).mockResolvedValue(
|
||||
envPaths,
|
||||
);
|
||||
|
||||
// mock deduplication to return deduplicated paths (simulating same file)
|
||||
vi.mocked(
|
||||
memoryDiscovery.deduplicatePathsByFileIdentity,
|
||||
).mockResolvedValue({
|
||||
paths: ['/home/user/.gemini/GEMINI.md', '/app/gemini.md'],
|
||||
identityMap: new Map<string, string>(),
|
||||
});
|
||||
|
||||
vi.mocked(memoryDiscovery.readGeminiMdFiles).mockResolvedValue([
|
||||
{ filePath: '/home/user/.gemini/GEMINI.md', content: 'Global Content' },
|
||||
{ filePath: '/app/gemini.md', content: 'Project Content' },
|
||||
]);
|
||||
|
||||
await contextManager.refresh();
|
||||
|
||||
expect(
|
||||
memoryDiscovery.deduplicatePathsByFileIdentity,
|
||||
).toHaveBeenCalledWith(
|
||||
expect.arrayContaining([
|
||||
'/home/user/.gemini/GEMINI.md',
|
||||
'/app/gemini.md',
|
||||
'/app/GEMINI.md',
|
||||
]),
|
||||
);
|
||||
expect(memoryDiscovery.readGeminiMdFiles).toHaveBeenCalledWith(
|
||||
['/home/user/.gemini/GEMINI.md', '/app/gemini.md'],
|
||||
'tree',
|
||||
['.git'],
|
||||
);
|
||||
expect(contextManager.getEnvironmentMemory()).toContain(
|
||||
'Project Content',
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('discoverContext', () => {
|
||||
it('should discover and load new context', async () => {
|
||||
const mockResult: memoryDiscovery.MemoryLoadResult = {
|
||||
files: [{ path: '/app/src/GEMINI.md', content: 'Src Content' }],
|
||||
};
|
||||
vi.mocked(memoryDiscovery.loadJitSubdirectoryMemory).mockResolvedValue(
|
||||
mockResult,
|
||||
);
|
||||
|
||||
const result = await contextManager.discoverContext('/app/src/file.ts', [
|
||||
'/app',
|
||||
]);
|
||||
|
||||
expect(memoryDiscovery.loadJitSubdirectoryMemory).toHaveBeenCalledWith(
|
||||
'/app/src/file.ts',
|
||||
['/app'],
|
||||
expect.any(Set),
|
||||
expect.any(Set),
|
||||
['.git'],
|
||||
);
|
||||
expect(result).toMatch(/--- Context from: \/app\/src\/GEMINI\.md ---/);
|
||||
expect(result).toContain('Src Content');
|
||||
expect(contextManager.getLoadedPaths()).toContain('/app/src/GEMINI.md');
|
||||
});
|
||||
|
||||
it('should return empty string if no new files found', async () => {
|
||||
const mockResult: memoryDiscovery.MemoryLoadResult = { files: [] };
|
||||
vi.mocked(memoryDiscovery.loadJitSubdirectoryMemory).mockResolvedValue(
|
||||
mockResult,
|
||||
);
|
||||
|
||||
const result = await contextManager.discoverContext('/app/src/file.ts', [
|
||||
'/app',
|
||||
]);
|
||||
|
||||
expect(result).toBe('');
|
||||
});
|
||||
|
||||
it('should return empty string if folder is not trusted', async () => {
|
||||
vi.mocked(mockConfig.isTrustedFolder).mockReturnValue(false);
|
||||
|
||||
const result = await contextManager.discoverContext('/app/src/file.ts', [
|
||||
'/app',
|
||||
]);
|
||||
|
||||
expect(memoryDiscovery.loadJitSubdirectoryMemory).not.toHaveBeenCalled();
|
||||
expect(result).toBe('');
|
||||
});
|
||||
|
||||
it('should pass custom boundary markers from config', async () => {
|
||||
const customMarkers = ['.monorepo-root', 'package.json'];
|
||||
vi.mocked(mockConfig.getMemoryBoundaryMarkers).mockReturnValue(
|
||||
customMarkers,
|
||||
);
|
||||
vi.mocked(memoryDiscovery.loadJitSubdirectoryMemory).mockResolvedValue({
|
||||
files: [],
|
||||
});
|
||||
|
||||
await contextManager.discoverContext('/app/src/file.ts', ['/app']);
|
||||
|
||||
expect(memoryDiscovery.loadJitSubdirectoryMemory).toHaveBeenCalledWith(
|
||||
'/app/src/file.ts',
|
||||
['/app'],
|
||||
expect.any(Set),
|
||||
expect.any(Set),
|
||||
customMarkers,
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user