MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-07-16 04:50:29 -07:00
Code Issues Packages Projects Releases Wiki Activity

chore: limit MCP resources display to 10 by default (#15489)

Browse Source
This commit is contained in:
Jack Wotherspoon
2025-12-23 14:39:35 -05:00
committed by GitHub
parent 9885cbba48
commit fe951f8a78
3 changed files with 52 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/ui/components/views/McpStatus.test.tsx
+14
View File
@@ -184,4 +184,18 @@ describe('McpStatus', () => {
expect(lastFrame()).toMatchSnapshot(); expect(lastFrame()).toMatchSnapshot();
unmount(); unmount();
}); });
it('truncates resources when exceeding limit', () => {
const manyResources = Array.from({ length: 25 }, (_, i) => ({
serverName: 'server-1',
name: `resource-${i + 1}`,
uri: `file:///tmp/resource-${i + 1}.txt`,
}));
const { lastFrame, unmount } = render(
<McpStatus {...baseProps} resources={manyResources} />,
);
expect(lastFrame()).toContain('15 resources hidden');
unmount();
});
}); });
packages/cli/src/ui/components/views/McpStatus.tsx
+35 -22
View File
@@ -8,6 +8,7 @@ import type { MCPServerConfig } from '@google/gemini-cli-core';
import { MCPServerStatus } from '@google/gemini-cli-core'; import { MCPServerStatus } from '@google/gemini-cli-core';
import { Box, Text } from 'ink'; import { Box, Text } from 'ink';
import type React from 'react'; import type React from 'react';
import { MAX_MCP_RESOURCES_TO_SHOW } from '../../constants.js';
import { theme } from '../../semantic-colors.js'; import { theme } from '../../semantic-colors.js';
import type { import type {
HistoryItemMcpStatus, HistoryItemMcpStatus,
@@ -251,28 +252,40 @@ export const McpStatus: React.FC<McpStatusProps> = ({
{serverResources.length > 0 && ( {serverResources.length > 0 && (
<Box flexDirection="column" marginLeft={2}> <Box flexDirection="column" marginLeft={2}>
<Text color={theme.text.primary}>Resources:</Text> <Text color={theme.text.primary}>Resources:</Text>
{serverResources.map((resource, index) => { {serverResources
const label = resource.name || resource.uri || 'resource'; .slice(0, MAX_MCP_RESOURCES_TO_SHOW)
return ( .map((resource, index) => {
<Box const label = resource.name || resource.uri || 'resource';
key={`${resource.serverName}-resource-${index}`} return (
flexDirection="column" <Box
> key={`${resource.serverName}-resource-${index}`}
<Text> flexDirection="column"
- <Text color={theme.text.primary}>{label}</Text> >
{resource.uri ? ` (${resource.uri})` : ''} <Text>
{resource.mimeType ? ` [${resource.mimeType}]` : ''} - <Text color={theme.text.primary}>{label}</Text>
</Text> {resource.uri ? ` (${resource.uri})` : ''}
{showDescriptions && resource.description && ( {resource.mimeType ? ` [${resource.mimeType}]` : ''}
<Box marginLeft={2}> </Text>
<Text color={theme.text.secondary}> {showDescriptions && resource.description && (
{resource.description.trim()} <Box marginLeft={2}>
</Text> <Text color={theme.text.secondary}>
</Box> {resource.description.trim()}
)} </Text>
</Box> </Box>
); )}
})} </Box>
);
})}
{serverResources.length > MAX_MCP_RESOURCES_TO_SHOW && (
<Text color={theme.text.secondary}>
{' '}...{' '}
{serverResources.length - MAX_MCP_RESOURCES_TO_SHOW}{' '}
{serverResources.length - MAX_MCP_RESOURCES_TO_SHOW === 1
? 'resource'
: 'resources'}{' '}
hidden
</Text>
)}
</Box> </Box>
)} )}
</Box> </Box>
packages/cli/src/ui/constants.ts
+3
View File
@@ -25,3 +25,6 @@ export const TOOL_STATUS = {
CANCELED: '-', CANCELED: '-',
ERROR: 'x', ERROR: 'x',
} as const; } as const;
// Maximum number of MCP resources to display per server before truncating
export const MAX_MCP_RESOURCES_TO_SHOW = 10;