MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-04-22 11:04:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove virtual execution lifecycle aliases

Browse Source
This commit is contained in:
Adam Weidman
2026-03-08 23:31:18 -04:00
parent 0fc4247287
commit fff69df93e
3 changed files with 18 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/services/executionLifecycleService.test.ts
+11 -11
View File
@@ -35,7 +35,7 @@ describe('ExecutionLifecycleService', () => {
it('completes managed executions in the foreground and notifies exit subscribers', async () => {
const handle = ExecutionLifecycleService.createExecution();
if (handle.pid === undefined) {
throw new Error('Expected virtual execution ID.');
throw new Error('Expected execution ID.');
}
const onExit = vi.fn();
@@ -43,7 +43,7 @@ describe('ExecutionLifecycleService', () => {
ExecutionLifecycleService.appendOutput(handle.pid, 'Hello');
ExecutionLifecycleService.appendOutput(handle.pid, ' World');
ExecutionLifecycleService.completeVirtualExecution(handle.pid, {
ExecutionLifecycleService.completeExecution(handle.pid, {
exitCode: 0,
});
@@ -66,20 +66,20 @@ describe('ExecutionLifecycleService', () => {
'remote_agent',
);
if (handle.pid === undefined) {
throw new Error('Expected virtual execution ID.');
throw new Error('Expected execution ID.');
}
ExecutionLifecycleService.completeVirtualExecution(handle.pid, {
ExecutionLifecycleService.completeExecution(handle.pid, {
exitCode: 0,
});
const result = await handle.result;
expect(result.executionMethod).toBe('remote_agent');
});
it('supports backgrounding virtual executions and continues streaming updates', async () => {
const handle = ExecutionLifecycleService.createVirtualExecution();
it('supports backgrounding managed executions and continues streaming updates', async () => {
const handle = ExecutionLifecycleService.createExecution();
if (handle.pid === undefined) {
throw new Error('Expected virtual execution ID.');
throw new Error('Expected execution ID.');
}
const chunks: string[] = [];
@@ -103,7 +103,7 @@ describe('ExecutionLifecycleService', () => {
expect(backgroundResult.output).toBe('Chunk 1');
ExecutionLifecycleService.appendOutput(handle.pid, '\nChunk 2');
ExecutionLifecycleService.completeVirtualExecution(handle.pid, {
ExecutionLifecycleService.completeExecution(handle.pid, {
exitCode: 0,
});
@@ -116,11 +116,11 @@ describe('ExecutionLifecycleService', () => {
unsubscribeExit();
});
it('kills virtual executions and resolves with aborted result', async () => {
it('kills managed executions and resolves with aborted result', async () => {
const onKill = vi.fn();
const handle = ExecutionLifecycleService.createVirtualExecution('', onKill);
const handle = ExecutionLifecycleService.createExecution('', onKill);
if (handle.pid === undefined) {
throw new Error('Expected virtual execution ID.');
throw new Error('Expected execution ID.');
}
ExecutionLifecycleService.appendOutput(handle.pid, 'work');