Mahima Shanware
08ae3ff9b8
fix(core): align logging and error handling with strict development rules
...
Addressed reviewer feedback by replacing process.stderr.write with debugLogger.error in config.ts and using isNodeError in storage.ts to adhere to codebase standards.
2026-04-08 23:12:44 +00:00
Mahima Shanware
fd8cfad6f9
fix(core): ensure JIT provisioning of plan directory only occurs in active plan mode
...
Address review bot feedback to prevent EACCES errors during startup by restricting filesystem mutation and workspace context registration to when the user is actively in an interactive plan session. Non-plan tool registration now uses the safely resolved path without attempting to create the directory.
2026-04-08 16:36:40 +00:00
Mahima Shanware
073ecc1d4c
fix(core): handle plan dir EEXIST safely and rely on mkdir idempotency
...
This addresses a potential TOCTOU vulnerability and edge case identified during review. The redundant `fs.existsSync` check in `getPlansDir` has been removed, allowing `fs.mkdirSync(..., { recursive: true })` to safely handle directory idempotency.
By relying directly on `mkdirSync`, we ensure that if a non-directory file already exists at the target path, the system will correctly throw an `EEXIST` error rather than silently treating the file as a directory and crashing later during workspace registration.
2026-04-08 16:36:39 +00:00
Mahima Shanware
b9d987b08d
perf(core): cache initialized plan directories
...
Adds caching to getPlansDir to avoid redundant synchronous disk I/O and repeated workspace context registrations.
2026-04-08 16:36:39 +00:00
Mahima Shanware
0c63c05c45
fix(core): address extension context stickiness and symlink path resolution
...
This commit addresses two bugs identified during review:
1. Cleared the sticky `activeExtensionContext` when the standard `/plan` command is executed, ensuring subsequent prompts correctly target the default global plan directory.
2. Fixed a path resolution regression in `Storage.getPlansDir()` by constructing the fallback ENOENT path directly against the real project root. This prevents `isSubpath` validation failures and potential traversal vulnerabilities when the project root is a symlink.
2026-04-08 16:36:39 +00:00
Mahima Shanware
15aa924932
fix(core): migrate consumers to lazily-evaluated getPlansDir
...
Updates prompts and tool implementations (edit, write-file, enter/exit plan mode) to route through Config.getPlansDir() instead of Storage.getPlansDir(). This ensures the plan directory is lazily created exactly when these features attempt to use it, preventing ENOENT failures.
2026-04-08 16:34:05 +00:00
Mahima Shanware
2c4d03a843
feat(core): dynamic MRU plan directory resolution and lazy initialization
...
Introduces active extension context tracking in config to support dynamic switching of plan directories. Resolves circular dependency in storage by deferring plan directory creation until on-demand use, preventing ENOENT errors on non-existent paths.
2026-04-08 16:32:47 +00:00
Gaurav
e77b22e638
fix: isolate concurrent browser agent instances ( #24794 )
2026-04-08 14:31:10 +00:00
Gaurav Ghosh
e7f8d9cf1a
Revert "feat: Introduce an AI-driven interactive shell mode with new"
...
This reverts commit 651ad63ed6 .
2026-04-08 07:31:17 -07:00
Gaurav Ghosh
651ad63ed6
feat: Introduce an AI-driven interactive shell mode with new
...
`read-shell` and `write-to-shell` tools and a configurable mode setting.
2026-04-08 07:27:28 -07:00
Jacob Richman
7e1938c1bc
fix(cli): switch default back to terminalBuffer=false and fix regressions introduced for that mode ( #24873 )
2026-04-08 05:47:54 +00:00
Anjaligarhwal
b9f1d832c8
fix(core): dispose Scheduler to prevent McpProgress listener leak ( #24870 )
2026-04-08 03:05:53 +00:00
Jacob Richman
28efab483f
fix(cli): always show shell command description or actual command ( #24774 )
2026-04-08 01:52:33 +00:00
Michael Bleigh
16768c08f2
refactor(core): make LegacyAgentSession dependencies optional ( #24287 )
...
Co-authored-by: Adam Weidman <adamfweidman@gmail.com >
Co-authored-by: Adam Weidman <adamfweidman@google.com >
2026-04-07 23:45:22 +00:00
Yuna Seol
3c5b5db034
feat(core): use experiment flags for default fetch timeouts ( #24261 )
2026-04-07 22:35:04 +00:00
Michael Bleigh
986293bd38
feat(core): add agent protocol UI types and experimental flag ( #24275 )
...
Co-authored-by: Adam Weidman <adamfweidman@gmail.com >
Co-authored-by: Adam Weidman <adamfweidman@google.com >
2026-04-07 21:45:18 +00:00
David Pierce
adf7b3b717
Improve sandbox error matching and caching ( #24550 )
2026-04-07 21:08:18 +00:00
Jack Wotherspoon
9637fb3990
fix(core): remove tmux alternate buffer warning ( #24852 )
2026-04-07 21:01:14 +00:00
krishdef7
68fef8745e
fix(core): propagate BeforeModel hook model override end-to-end ( #24784 )
...
Signed-off-by: krishdef7 <gargkrish06@gmail.com >
Co-authored-by: Sandy Tao <sandytao520@icloud.com >
2026-04-07 17:49:26 +00:00
Michael Bleigh
e432f7c009
feat(hooks): display hook system messages in UI ( #24616 )
2026-04-07 17:42:39 +00:00
Emily Hedlund
1762c9c509
temporarily disable sandbox integration test on windows ( #24786 )
2026-04-07 15:33:40 +00:00
Gaurav
4c5e887732
feat(telemetry): add browser agent clearcut metrics ( #24688 )
2026-04-07 07:48:38 +00:00
Abhi
83096c68b0
fix(policy): allow complete_task in plan mode ( #24771 )
2026-04-07 03:43:42 +00:00
Christian Gunderman
d2b775f9a7
Add an eval for and fix unsafe cloning behavior. ( #24457 )
2026-04-07 03:17:44 +00:00
David Pierce
984f02c180
relax tool sandboxing overrides for plan mode to match defaults. ( #24762 )
2026-04-06 22:18:10 +00:00
Gaurav
e116aa34f4
fix(browser): remove premature browser cleanup after subagent invocation ( #24753 )
2026-04-06 21:17:31 +00:00
krishdef7
8ac560d2c9
fix(core): handle partial llm_request in BeforeModel hook override ( #22326 )
2026-04-06 20:11:38 +00:00
Christian Gunderman
8f131ffef7
Fix issue where topic headers can be posted back to back ( #24759 )
2026-04-06 18:36:22 +00:00
Gal Zahavi
7311e242ec
feat(cli): enhance tool confirmation UI and selection layout ( #24376 )
2026-04-04 01:32:35 +00:00
Jacob Richman
ec35ebbe57
fix(core): detect uninitialized lines ( #24646 )
2026-04-04 00:51:29 +00:00
Gal Zahavi
65024d4538
fix(core): ensure global temp directory is always in sandbox allowed paths ( #24638 )
...
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-04-04 00:23:27 +00:00
Samee Zahid
4fb3790051
feat(core): discourage update topic tool for simple tasks ( #24640 )
...
Co-authored-by: Samee Zahid <sameez@google.com >
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-04-03 23:52:24 +00:00
Gal Zahavi
893ae4d29a
fix(core): ensure sandbox approvals are correctly persisted and matched for proactive expansions ( #24577 )
2026-04-03 21:48:18 +00:00
Emily Hedlund
370c45de67
fix(core): improve windows sandbox reliability and fix integration tests ( #24480 )
2026-04-03 20:54:48 +00:00
Abhi
a93a1ebd65
fix(core): inject skill system instructions into subagent prompts if activated ( #24620 )
2026-04-03 18:45:11 +00:00
Emily Hedlund
ca0e6f9bd9
test: fix Windows CI execution and resolve exposed platform failures ( #24476 )
2026-04-03 15:50:29 +00:00
Aditya Bijalwan
7a70ab9a5d
Feat/browser agent metrics ( #24210 )
...
Co-authored-by: Gaurav Ghosh <gaghosh@google.com >
2026-04-03 08:21:09 +00:00
Tommaso Sciortino
8c215c7a88
fix(core): remove broken PowerShell translation and fix native __write in Windows sandbox ( #24571 )
2026-04-03 02:50:44 +00:00
Jacob Richman
1f5d7014c6
feat(ui): enable "TerminalBuffer" mode to solve flicker ( #24512 )
2026-04-03 00:39:49 +00:00
Gal Zahavi
1ae0499e5d
fix(core): pass includeDirectories to sandbox configuration ( #24573 )
2026-04-02 23:34:12 +00:00
Saurav Sharma
e5adeaca80
fix(core): unsafe type assertions in Core File System #19712 ( #19739 )
...
Co-authored-by: Dev Randalpura <devrandalpura@google.com >
2026-04-02 20:44:22 +00:00
Adam Weidman
6fb58bd31f
feat(cli): migrate nonInteractiveCli to LegacyAgentSession ( #22987 )
2026-04-02 20:21:40 +00:00
Jerop Kipruto
64c928fce7
feat(core): implement context-aware persistent policy approvals ( #23257 )
2026-04-02 20:01:33 +00:00
Aashir Javed
77027dff82
fix(cli): clear stale retry/loading state after cancellation ( #21096 ) ( #21960 )
...
Co-authored-by: Aashir Javed <Aaxhirrr@users.noreply.github.com >
Co-authored-by: Dev Randalpura <devrandalpura@google.com >
2026-04-02 19:44:39 +00:00
ruomeng
c0dfa1aec3
Enable 'Other' option for yesno question type ( #24545 )
2026-04-02 19:42:53 +00:00
Sandy Tao
06173c0885
fix(core): move project memory dir under tmp directory ( #24542 )
2026-04-02 17:50:43 +00:00
Jyo
08b926796c
Fix crash when vim editor is not found in PATH on Windows ( #22423 )
...
Co-authored-by: Tommaso Sciortino <sciortino@gmail.com >
2026-04-02 17:40:19 +00:00
Sandy Tao
63cc363606
feat(core): scope subagent workspace directories via AsyncLocalStorage ( #24445 )
2026-04-02 16:33:08 +00:00
joshualitt
e0044f2868
feat(core): Land ContextCompressionService ( #24483 )
2026-04-02 16:22:04 +00:00
Gaurav
beff8c91aa
fix(browser): handle computer-use model detection for analyze_screenshot ( #24502 )
2026-04-02 15:05:21 +00:00