Spencer
886025f6b9
chore: finish truncation and stream logging logic
2026-04-13 20:25:19 +00:00
jacob314
954835123f
Checkpoint of shell optimization
...
fix(cli): Write shell command output to a file and limit memory buffered in UI
Fixes.
Checkpoint.
fix(core, cli): await outputStream.end() to prevent race conditions
This commit fixes a critical race condition where
was called synchronously without being awaited. This led to potential file
truncation or EBUSY errors on Windows when attempting to manipulate the file
immediately after the call.
Additionally, this change removes fixed wait times (`setTimeout`) that
were previously used in test files as a band-aid.
fix(core): stream processed xterm output to file to remove spurious escape codes
test(core): update shell regression tests to use file_data events
2026-04-13 20:25:18 +00:00
Spencer
128e3567cb
fix(core): resolve PTY exhaustion and orphan MCP subprocess leaks ( #25079 )
2026-04-10 18:57:09 +00:00
Spencer
f6c08a114b
fix(core): remove buffer slice to prevent OOM on large output streams ( #25094 )
2026-04-10 16:33:36 +00:00
Spencer
5fc8fea8d7
fix: resolve lifecycle memory leaks by cleaning up listeners and root closures ( #25049 )
2026-04-10 04:21:14 +00:00
Jacob Richman
ec35ebbe57
fix(core): detect uninitialized lines ( #24646 )
2026-04-04 00:51:29 +00:00
Gal Zahavi
65024d4538
fix(core): ensure global temp directory is always in sandbox allowed paths ( #24638 )
...
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-04-04 00:23:27 +00:00
Coco Sheng
f510394721
Implement background process monitoring and inspection tools ( #23799 )
2026-04-02 15:01:00 +00:00
Gal Zahavi
13ccc16457
fix(core): enhance sandbox usability and fix build error ( #24460 )
...
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-04-01 23:51:06 +00:00
Tommaso Sciortino
8868b34c75
refactor(core): delegate sandbox denial parsing to SandboxManager ( #23928 )
2026-03-26 22:10:15 +00:00
Spencer
d25ce0e143
fix(core): remove shell outputChunks buffer caching to prevent memory bloat and sanitize prompt input ( #23751 )
2026-03-26 21:16:07 +00:00
Tommaso Sciortino
1b052df52f
feat(core): implement Windows sandbox dynamic expansion Phase 1 and 2.1 ( #23691 )
2026-03-25 17:54:45 +00:00
Gal Zahavi
fa024133e6
feat(core): integrate SandboxManager to sandbox all process-spawning tools ( #22231 )
2026-03-13 21:11:51 +00:00
Adam Weidman
10ab958378
refactor(core): extract ExecutionLifecycleService for tool backgrounding ( #21717 )
2026-03-12 04:03:54 +00:00
Manav Sharma
eaf6e8bbb1
fix(core)#20941: reap orphaned descendant processes on PTY abort ( #21124 )
...
Co-authored-by: Spencer <spencertang@google.com >
2026-03-11 15:36:25 +00:00
Gal Zahavi
524679d23c
feat: implement background process logging and cleanup ( #21189 )
2026-03-11 00:13:20 +00:00
Coco Sheng
519c75f410
fix: prevent hangs in non-interactive mode and improve agent guidance ( #20893 )
...
Co-authored-by: Keith Schaab <keith.schaab@gmail.com >
2026-03-10 20:30:58 +00:00
Nicholas Bardy
4653b126f3
fix(core): destroy PTY on kill() and exception to prevent fd leak ( #21693 )
...
Co-authored-by: Jacob Richman <jacob314@gmail.com >
2026-03-10 00:08:16 +00:00
nityam
28af4e127f
fix: merge duplicate imports in packages/core (3/4) ( #20928 )
2026-03-04 00:12:59 +00:00
Gal Zahavi
b611f9a519
feat: Implement background shell commands ( #14849 )
2026-01-30 17:53:09 +00:00
Gal Zahavi
013a4e02ff
fix(core): fix PTY descriptor shell leak ( #16773 )
2026-01-16 17:55:29 +00:00
Christian Gunderman
d75792703a
Always enable redaction in GitHub actions. ( #16200 )
2026-01-08 22:35:12 +00:00
Christian Gunderman
3b1dbcd42d
Implemented unified secrets sanitization and env. redaction options ( #15348 )
2025-12-23 03:18:27 +00:00
Christian Gunderman
942bcfc61e
Disallow redundant typecasts. ( #15030 )
2025-12-13 01:43:43 +00:00
Allen Hutchison
a47af8e261
fix(core): commandPrefix word boundary and compound command safety ( #15006 )
2025-12-12 23:02:19 +00:00
Gal Zahavi
171103aedc
refactor(core): Improve environment variable handling in shell execution ( #14742 )
...
Co-authored-by: Jack Wotherspoon <jackwoth@google.com >
Co-authored-by: christine betts <chrstn@uw.edu >
2025-12-09 00:22:46 +00:00
Jacob Richman
934b309b4c
Fix issue where we were passing the model content reflecting terminal line wrapping. ( #14566 )
2025-12-05 04:42:57 +00:00
Jacob Richman
d284fa66c0
Fix bug in the shellExecutionService resulting in both truncation and 3X bloat ( #14545 )
2025-12-04 18:26:12 -08:00
Aswin Ashok
84f521b1c6
fix(shell): cursor visibility when using interactive mode ( #14095 )
...
Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com >
2025-12-04 16:58:03 +00:00
Bryan Morgan
16113647de
Fix/windows pty crash ( #12587 )
...
Co-authored-by: LayorX <yor31117@gmail.com >
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-11-05 16:53:03 +00:00
cornmander
b8b6620365
Tighten bash shell option handling ( #12532 )
2025-11-04 16:11:29 +00:00
Mayur Vaid
2940b50811
fix: Ignore correct errors thrown when resizing or scrolling an exited pty ( #11440 )
2025-10-22 04:27:49 +00:00
cornmander
dcf362bcf9
Inline tree-sitter wasm and add runtime fallback ( #11157 )
2025-10-17 00:25:30 +00:00
cornmander
bd5c158a62
Revert "Shell approval rework" ( #11143 )
2025-10-14 22:55:28 +00:00
cornmander
92dbdbb93b
Shell approval rework ( #11073 )
2025-10-14 16:51:32 +00:00
Gal Zahavi
265d39f337
feat(core): improve shell execution service reliability ( #10607 )
2025-10-10 22:14:37 +00:00
Gal Zahavi
6695c32aa2
fix(shell): improve shell output presentation and usability ( #8837 )
2025-09-30 20:44:58 +00:00
Gal Zahavi
a34e375193
refactor(shell): Send AnsiOutput when ShowColor is false ( #8647 )
2025-09-18 20:04:46 +00:00
Gal Zahavi
181898cb5d
feat(shell): enable interactive commands with virtual terminal ( #6694 )
2025-09-11 20:27:27 +00:00
Jacob MacDonald
45d494a8d8
improve performance of shell commands with lots of output ( #7680 )
2025-09-04 16:20:24 +00:00
Tommaso Sciortino
19f2a07efa
Fix shell argument parsing in windows ( #7160 )
2025-08-27 19:14:22 +00:00
Pascal Birchler
0f031a7f89
Explict imports & exports with type modifier ( #3774 )
2025-08-25 22:04:53 +00:00
Pascal Birchler
ee4feea006
chore: consistently import node modules with prefix ( #3013 )
...
Co-authored-by: N. Taylor Mullen <ntaylormullen@google.com >
2025-08-25 20:11:27 +00:00
Gal Zahavi
f1575f6d8d
feat(core): refactor shell execution to use node-pty ( #6491 )
...
Co-authored-by: Jacob Richman <jacob314@gmail.com >
2025-08-19 23:03:51 +00:00
Abhi
33b9bdb11e
feat(cli): Introduce arguments for shell execution in custom commands ( #5966 )
2025-08-17 04:02:54 +00:00
Gal Zahavi
1a2906a8ad
Revert #6088 ( #6328 )
2025-08-15 17:27:33 +00:00
Gal Zahavi
980091cbc2
feat(core): refactor shell execution to use node-pty ( #6088 )
2025-08-14 20:40:12 +00:00
Richie Foreman
4782113ceb
fix(core): Improve errors in situations where the command spawn does … ( #5723 )
2025-08-06 23:31:42 +00:00
Tommaso Sciortino
a3a432e3cf
Fix bug executing commands in windows whose flags contain spaces ( #5317 )
2025-08-01 00:27:07 +00:00
Abhi
ca5dd28ab6
refactor(core): Centralize shell logic into ShellExecutionService ( #4823 )
2025-07-26 01:56:49 +00:00