Commit Graph

64 Commits

Author SHA1 Message Date
Srinath Padmanabhan
df1a6996e0 feat(telemetry): migrate Google Auth events to event-based logging and fix token storage metric
- Add GoogleAuthStartEvent and GoogleAuthEndEvent types
- Implement logGoogleAuthStart and logGoogleAuthEnd in telemetry loggers
- Update ClearcutLogger to support Google Auth events
- Update OAuth2 logic to use the new logging functions
- Fix missing 'type' attribute in recordTokenStorageInitialization metric
2026-03-11 12:21:45 -07:00
Srinath Padmanabhan
0b2c582d6b Merge remote-tracking branch 'origin/main' into pr-19267 2026-03-05 16:09:28 -08:00
Srinath Padmanabhan
81151d12b1 Fixing review comments 2026-03-05 16:06:08 -08:00
Shreya Keshive
0135b03c8a fix(acp): rename --experimental-acp to --acp & remove Zed-specific refrences (#21171) 2026-03-05 19:57:28 +00:00
Spencer
c59ef74837 fix(core, a2a-server): prevent hang during OAuth in non-interactive sessions (#21045) 2026-03-04 20:35:21 +00:00
nityam
28af4e127f fix: merge duplicate imports in packages/core (3/4) (#20928) 2026-03-04 00:12:59 +00:00
Srinath Padmanabhan
075ac296c6 fix(telemetry): record onboarding end for cached credentials success 2026-03-03 12:35:41 -08:00
Srinath Padmanabhan
1a94129b09 fix(telemetry): correct onboarding and token storage metrics
This commit addresses two issues with telemetry recording:

1.  The  metric was missing the  attribute, causing a TypeScript error when  was called. The  attribute has been added back to the metric definition.

2.  The  metric was being incorrectly called on every token refresh. This has been corrected by removing the calls from the token refresh listener and refactoring the valid success paths to call a new  helper function to avoid code duplication.
2026-03-03 12:35:41 -08:00
Srinath Padmanabhan
ed2204ffce feat(telemetry): add onboarding start and end metrics for login with google 2026-03-03 12:35:41 -08:00
Shreya Keshive
50947c57ce fix(acp): update auth handshake to spec (#19725) 2026-02-25 15:04:42 +00:00
sinisterchill
2e3cbd6363 fix(core): prevent OAuth server crash on unexpected requests (#19668) 2026-02-23 18:03:31 +00:00
N. Taylor Mullen
a7d851146a feat(core): remove unnecessary login verbiage from Code Assist auth (#19861) 2026-02-21 21:55:11 +00:00
Christian Gunderman
dfd7721e69 Disallow unsafe returns. (#19767) 2026-02-21 01:12:56 +00:00
Christian Gunderman
58d637f919 Disallow and suppress unsafe assignment (#19736) 2026-02-20 22:28:55 +00:00
Christian Gunderman
b7555ab1e1 Fix unsafe assertions in code_assist folder. (#19706)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-02-20 20:44:23 +00:00
Christian Gunderman
fd65416a2f Disallow unsafe type assertions (#18688) 2026-02-10 00:10:15 +00:00
Emily Hedlund
69f8273481 feat(core): require user consent before MCP server OAuth (#18132) 2026-02-03 21:26:00 +00:00
Emily Hedlund
2238802e97 feat(core): implement interactive and non-interactive consent for OAuth (#17699) 2026-01-30 14:57:34 +00:00
Shreya Keshive
1ec8f40096 fix(oauth): update oauth to use 127.0.0.1 instead of localhost (#17388) 2026-01-23 18:41:37 +00:00
N. Taylor Mullen
7956eb239e Introduce GEMINI_CLI_HOME for strict test isolation (#15907) 2026-01-07 04:09:39 +00:00
Christian Gunderman
3997c7ff80 Fix terminal hang when user exits browser without logging in (#15748) 2026-01-05 19:02:55 +00:00
Christian Gunderman
7f2d33458a Disallow unnecessary awaits. (#15172) 2025-12-17 05:28:18 +00:00
Marat Boshernitsan
4322137cee refactor(telemetry): Improve previous PR that allows telemetry to use the CLI auth and add testing (#14589) 2025-12-08 11:20:13 -08:00
Marat Boshernitsan
b9b3b8050d Allow telemetry exporters to GCP to utilize user's login credentials, if requested (#13778) 2025-12-03 05:27:37 +00:00
Allen Hutchison
828afe113e refactor(stdio): always patch stdout and use createWorkingStdio for clean output (#14159) 2025-12-02 23:08:25 +00:00
CHAEWAN KIM
f4babf172b fix(async): prevent missed async errors from bypassing catch handlers (#13714)
Co-authored-by: Tommaso Sciortino <sciortino@gmail.com>
2025-12-01 22:11:40 +00:00
Jacob Richman
030a5ace97 Fix multiple bugs with auth flow including using the implemented but unused restart support. (#13565) 2025-11-21 16:31:47 +00:00
Caroline Rose
9d74b7c0e8 feat(auth): Add option for metadata server application default credentials without project override (#12948) 2025-11-14 16:39:11 +00:00
Tommaso Sciortino
85f3a8c210 Migrate to coreEvents/debugLogger (#12107) 2025-10-27 23:46:35 +00:00
cocosheng-g
9e8f7c074c Create BYOID auth client when detecting BYOID credentials (#11592) 2025-10-27 20:05:11 +00:00
Abhi
b364f37655 refactor(logging): Centralize console logging with debugLogger (#11590) 2025-10-21 20:35:22 +00:00
shishu314
c999b7e354 feat(security) - Encrypted oauth flag (#8101)
Co-authored-by: Shi Shu <shii@google.com>
2025-09-16 14:05:29 +00:00
Arya Gummadi
876d091602 fix(auth): improve Google OAuth error handling and prevent empty error messages (#7539) 2025-09-03 20:51:29 +00:00
Manash
3529595e6c fix(core): Fix permissions for oauth_creds.json (#6662) 2025-08-29 17:35:07 +00:00
Tommaso Sciortino
7e31577813 Standardize exit codes (#7055) 2025-08-26 04:44:45 +00:00
Pascal Birchler
0f031a7f89 Explict imports & exports with type modifier (#3774) 2025-08-25 22:04:53 +00:00
Pascal Birchler
ee4feea006 chore: consistently import node modules with prefix (#3013)
Co-authored-by: N. Taylor Mullen <ntaylormullen@google.com>
2025-08-25 20:11:27 +00:00
Yuki Okita
21c6480b65 Refac: Centralize storage file management (#4078)
Co-authored-by: Taylor Mullen <ntaylormullen@google.com>
2025-08-20 01:55:47 +00:00
Arya Gummadi
6505b0c8e1 fix: allow re-auth with another google account (#6544) 2025-08-20 00:06:25 +00:00
Gaurav
5fe4e02310 fix: GCA creds loading order (#6498) 2025-08-18 21:11:19 +00:00
Richie Foreman
2998f27f70 chore(compiler): Enable strict property access TS compiler flag. (#6255)
Co-authored-by: Jacob Richman <jacob314@gmail.com>
2025-08-17 16:43:21 +00:00
Marat Boshernitsan
bc60257e22 feat(oauth): Make oauth client a singleton to survive cache failures (#6348) 2025-08-16 05:05:59 +00:00
Brian de Alwis
191cc01bf5 fix(core): restrict oauth_creds.json file permissions (#5245)
Co-authored-by: cornmander <shikhman@google.com>
2025-08-09 03:05:30 +00:00
Gal Zahavi
6321442865 feat(auth): Enhance non-interactive gcp auth (#4811) 2025-07-25 17:19:38 +00:00
Marat Boshernitsan
5066bc5384 Refactor the logic for deciding whether to launch a browser into config (#4622) 2025-07-21 23:23:28 +00:00
Marat Boshernitsan
5b7b6fe608 Automatically detect non-interactive environments and fall back to a manual, code-based authentication flow (#4475) 2025-07-19 00:22:50 +00:00
Yongsheng Xu
91c69731c7 feat(auth): Enhance OAuth callback for robust Docker support (#3532)
Co-authored-by: Scott Densmore <scottdensmore@mac.com>
2025-07-18 01:55:26 +00:00
warjiang
606a7702de feat(cli): add explicit proxy option in cli (#2526)
Co-authored-by: Dcatfly <dcatfly@gmail.com>
2025-07-17 18:57:37 +00:00
N. Taylor Mullen
4442e893c3 fix(auth): Remove sharp edges from headless auth (#3985) 2025-07-12 15:42:47 -07:00
Gaurav
8f12e8a114 fix: clearcut logging (retry #3744) (#3751) 2025-07-11 17:57:35 +00:00