MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-07-16 04:50:29 -07:00
Code Issues Packages Projects Releases Wiki Activity
5,720 Commits 1,144 Branches 564 Tags
f5dce650a4e454a93a3dfc9ffea6f00cfd1d6df3
Commit Graph

8 Commits

Author SHA1 Message Date
Adam Weidman f5dce650a4 Add Coast Assist auth and Clearcut telemetry validation to unified review 
Auth:
- Coast Assist / LOGIN_WITH_GOOGLE uses AuthClient.request() against a
  Code Assist backend, NOT the standard Gemini API
- GcliAgentModel must extend BaseLlm directly with dual transport
  (API-key via httpOptions.headers, Coast Assist via AuthClient.request())
- OAuth flow, token refresh, credential caching all work as-is

Telemetry:
- Stream-interceptor approach replaced with BasePlugin recommendation
- ClearcutTelemetryPlugin for token counts (afterModelCallback),
  per-tool timing (beforeToolCallback/afterToolCallback with functionCallId),
  agent lifecycle, and model errors
- Corrects earlier claim: token usage IS available on ADK events
  (llm_agent.ts spreads LlmResponse into events)
- HTTP-level metrics captured in GcliAgentModel wrapper
- ~70% of Clearcut metrics stay in existing call sites unchanged

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-04-07 11:24:22 -04:00
Adam Weidman 99267012bc Revise unified review with corrections and phased plan 
Key changes:
- Add compilation blockers (C1-C4) as front-and-center section
- Soften "god object" to "extract 2 concerns from orchestrator"
- Fix persistence assessment (drop DB concerns, keep rewind depth)
- Add BaseContextCompactor finding (native ADK compaction ignored)
- Add isStructuredError type-guard bug
- Add token metrics gap in telemetry
- Replace AgentTool with custom BaseTool subagent architecture
- Demote retry safety to a note (ADK-wide, not migration-specific)
- Add 4-phase migration plan (Foundation → Non-Interactive → Interactive → SDK)
- Add feature-gate note at top
- Add concern decomposition table
- Simplify concurrent sessions (single-writer is sufficient for CLI)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-04-06 06:35:15 -07:00
Adam Weidman 53bbc2b339 Add unified design review document (pre-edit baseline) 
Codex-generated unified review merging claude and codex design review
findings for the ADK migration design doc. Committing as-is before
applying corrections.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
 2026-04-06 00:31:05 -07:00
Adam Weidman a31412ba83 Fix minor inconsistencies in design doc types and snippets 2026-04-05 10:50:32 -07:00
Adam Weidman cf4114062b Add Section 4.3 (Decomposing AgentLoopContext) to design 2026-04-05 10:45:40 -07:00
Adam Weidman eb03bd16b9 Update ADK Migration Design Doc with compaction and masking details 2026-04-05 10:27:12 -07:00
Adam Weidman 9f3a154014 Add validated architectural notes 2026-04-05 09:13:57 -07:00
Adam Weidman 137c4cd59c feat: add ADK migration design document 2026-04-05 09:05:34 -07:00