mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-03-12 23:21:27 -07:00
61b35ff745
Major upgrade to the agent's self-validation, safety, and project integrity
capabilities through five iterations of system prompt enhancements:
Workflow & Quality Mandates:
1. Incremental Validation: Mandates building, linting, and testing after
every significant file change to maintain a "green" state.
2. Mandatory Reproduction: Requires creating a failing test case to confirm
a bug before fixing, and explicitly verifying the failure (Negative Verification).
3. Test Persistence & Locality: Requires integrating repro cases into the
permanent test suite, preferably by amending existing related test files.
4. Script Discovery: Mandates identifying project-specific validation
commands from configuration files (package.json, Makefile, etc.).
5. Self-Review: Mandates running `git diff` after every edit, using
`--name-only` for large changes to preserve context window tokens.
6. Fast-Path Validation: Prioritizes lightweight checks (e.g., `tsc --noEmit`)
for frequent feedback, reserving heavy builds for final verification.
7. Output Verification: Requires checking command output (not just exit codes)
to prevent false-positives from empty test runs or hidden warnings.
Semantic Integrity & Dependency Safety:
8. Global Usage Discovery: Mandates searching the entire workspace for all
usages (via `grep_search`) before modifying exported symbols or APIs.
9. Dependency Integrity: Requires verifying that new imports are explicitly
declared in the project's dependency manifest (e.g., package.json).
10. Configuration Sync: Mandates updating build/environment configs
(tsconfig, Dockerfile, etc.) to support new file types or entry points.
11. Documentation Sync: Requires searching for and updating documentation
references when public APIs or CLI interfaces change.
12. Anti-Silencing Mandate: Prohibits using `any`, `@ts-ignore`, or lint
suppressions to resolve validation errors.
Diagnostics, Safety & Runtime Verification:
13. Error Grounding: Mandates reading full error logs and stack traces upon
failure. Includes Smart Log Navigation to prioritize the tail of large files.
14. Scope Isolation: Instructs the agent to focus only on errors introduced
by its changes and ignore unrelated legacy technical debt.
15. Destructive Safety: Mandates a `git status` check before deleting files
or modifying critical project configurations.
16. Non-Blocking Smoke Tests: Requires briefly running applications to
verify boot stability, using background/timeout strategies for servers.
Includes 15 new behavioral evaluations verifying these mandates and updated
snapshots in packages/core/src/core/prompts.test.ts.
75 lines
2.2 KiB
TypeScript
75 lines
2.2 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2026 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import { describe, expect } from 'vitest';
|
|
import { evalTest } from './test-helper.js';
|
|
|
|
describe('Negative Verification', () => {
|
|
/**
|
|
* Verifies that the agent mandates negative verification (confirming test failure)
|
|
* before applying a fix.
|
|
*/
|
|
evalTest('USUALLY_PASSES', {
|
|
name: 'should confirm test failure before applying fix',
|
|
files: {
|
|
'src/math.ts':
|
|
'export const add = (a: number, b: number) => a - b; // BUG',
|
|
'src/math.test.ts': `
|
|
import { expect, test } from 'vitest';
|
|
import { add } from './math';
|
|
test('add adds two numbers', () => {
|
|
expect(add(2, 3)).toBe(5);
|
|
});
|
|
`,
|
|
'package.json': JSON.stringify({
|
|
name: 'test-project',
|
|
type: 'module',
|
|
scripts: {
|
|
test: 'vitest run',
|
|
},
|
|
devDependencies: {
|
|
vitest: '^1.0.0',
|
|
},
|
|
}),
|
|
},
|
|
prompt:
|
|
'Fix the bug in src/math.ts. Ensure you verify the bug exists before fixing it.',
|
|
assert: async (rig) => {
|
|
const toolLogs = rig.readToolLogs();
|
|
|
|
const editIndex = toolLogs.findIndex(
|
|
(log) =>
|
|
(log.toolRequest.name === 'replace' ||
|
|
log.toolRequest.name === 'write_file') &&
|
|
log.toolRequest.args.includes('src/math.ts'),
|
|
);
|
|
|
|
// We expect at least one test run BEFORE the edit
|
|
const testRunsBefore = toolLogs
|
|
.slice(0, editIndex)
|
|
.filter(
|
|
(log) =>
|
|
log.toolRequest.name === 'run_shell_command' &&
|
|
(log.toolRequest.args.includes('vitest') ||
|
|
log.toolRequest.args.includes('npm test') ||
|
|
log.toolRequest.args.includes('npm run test')),
|
|
);
|
|
|
|
expect(editIndex, 'Agent should have edited src/math.ts').toBeGreaterThan(
|
|
-1,
|
|
);
|
|
expect(
|
|
testRunsBefore.length,
|
|
'Agent should have run tests at least once BEFORE the fix to confirm the bug',
|
|
).toBeGreaterThanOrEqual(1);
|
|
|
|
// Verification of "confirm it fails" is harder to check automatically in eval rig
|
|
// because we don't see the agent's internal thought "it failed as expected".
|
|
// But running it before fixing is the necessary mechanical step.
|
|
},
|
|
});
|
|
});
|