mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-03-13 07:30:52 -07:00
524 lines
12 KiB
TypeScript
524 lines
12 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2025 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import { render } from '../../test-utils/render.js';
|
|
import {
|
|
ScrollProvider,
|
|
useScrollable,
|
|
type ScrollState,
|
|
} from './ScrollProvider.js';
|
|
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
|
|
import { useRef, useImperativeHandle, forwardRef, type RefObject } from 'react';
|
|
import { Box, type DOMElement } from 'ink';
|
|
import type { MouseEvent } from '../hooks/useMouse.js';
|
|
|
|
// Mock useMouse hook
|
|
const mockUseMouseCallbacks = new Set<(event: MouseEvent) => void | boolean>();
|
|
vi.mock('../hooks/useMouse.js', async () => {
|
|
// We need to import React dynamically because this factory runs before top-level imports
|
|
const React = await import('react');
|
|
return {
|
|
useMouse: (callback: (event: MouseEvent) => void | boolean) => {
|
|
React.useEffect(() => {
|
|
mockUseMouseCallbacks.add(callback);
|
|
return () => {
|
|
mockUseMouseCallbacks.delete(callback);
|
|
};
|
|
}, [callback]);
|
|
},
|
|
};
|
|
});
|
|
|
|
// Mock ink's getBoundingBox
|
|
vi.mock('ink', async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import('ink')>();
|
|
return {
|
|
...actual,
|
|
getBoundingBox: vi.fn(() => ({ x: 0, y: 0, width: 10, height: 10 })),
|
|
};
|
|
});
|
|
|
|
const TestScrollable = forwardRef(
|
|
(
|
|
props: {
|
|
id: string;
|
|
scrollBy: (delta: number) => void;
|
|
scrollTo?: (scrollTop: number) => void;
|
|
getScrollState: () => ScrollState;
|
|
},
|
|
ref,
|
|
) => {
|
|
const elementRef = useRef<DOMElement>(null);
|
|
useImperativeHandle(ref, () => elementRef.current);
|
|
|
|
useScrollable(
|
|
{
|
|
ref: elementRef as RefObject<DOMElement>,
|
|
getScrollState: props.getScrollState,
|
|
scrollBy: props.scrollBy,
|
|
scrollTo: props.scrollTo,
|
|
hasFocus: () => true,
|
|
flashScrollbar: () => {},
|
|
},
|
|
true,
|
|
);
|
|
|
|
return <Box ref={elementRef} />;
|
|
},
|
|
);
|
|
TestScrollable.displayName = 'TestScrollable';
|
|
|
|
describe('ScrollProvider', () => {
|
|
beforeEach(() => {
|
|
vi.useFakeTimers();
|
|
mockUseMouseCallbacks.clear();
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.useRealTimers();
|
|
});
|
|
|
|
describe('Event Handling Status', () => {
|
|
it('returns true when scroll event is handled', () => {
|
|
const scrollBy = vi.fn();
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 0,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
let handled = false;
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
if (
|
|
callback({
|
|
name: 'scroll-down',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
}) === true
|
|
) {
|
|
handled = true;
|
|
}
|
|
}
|
|
expect(handled).toBe(true);
|
|
});
|
|
|
|
it('returns false when scroll event is ignored (cannot scroll further)', () => {
|
|
const scrollBy = vi.fn();
|
|
// Already at bottom
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 90,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
let handled = false;
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
if (
|
|
callback({
|
|
name: 'scroll-down',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
}) === true
|
|
) {
|
|
handled = true;
|
|
}
|
|
}
|
|
expect(handled).toBe(false);
|
|
});
|
|
});
|
|
|
|
it('calls scrollTo when clicking scrollbar track if available', async () => {
|
|
const scrollBy = vi.fn();
|
|
const scrollTo = vi.fn();
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 0,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
scrollTo={scrollTo}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
// Scrollbar is at x + width = 0 + 10 = 10.
|
|
// Height is 10. y is 0.
|
|
// Click at col 10, row 5.
|
|
// Thumb height = 10/100 * 10 = 1.
|
|
// Max thumb Y = 10 - 1 = 9.
|
|
// Current thumb Y = 0.
|
|
// Click at row 5 (relative Y = 5). This is outside the thumb (0).
|
|
// It's a track click.
|
|
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'left-press',
|
|
col: 10,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'left',
|
|
});
|
|
}
|
|
|
|
expect(scrollTo).toHaveBeenCalled();
|
|
expect(scrollBy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('calls scrollBy when clicking scrollbar track if scrollTo is not available', async () => {
|
|
const scrollBy = vi.fn();
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 0,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'left-press',
|
|
col: 10,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'left',
|
|
});
|
|
}
|
|
|
|
expect(scrollBy).toHaveBeenCalled();
|
|
});
|
|
|
|
it('batches multiple scroll events into a single update', async () => {
|
|
const scrollBy = vi.fn();
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 0,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
// Simulate multiple scroll events
|
|
const mouseEvent: MouseEvent = {
|
|
name: 'scroll-down',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
};
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback(mouseEvent);
|
|
callback(mouseEvent);
|
|
callback(mouseEvent);
|
|
}
|
|
|
|
// Should not have called scrollBy yet
|
|
expect(scrollBy).not.toHaveBeenCalled();
|
|
|
|
// Advance timers to trigger the batched update
|
|
await vi.runAllTimersAsync();
|
|
|
|
// Should have called scrollBy once with accumulated delta (3)
|
|
expect(scrollBy).toHaveBeenCalledTimes(1);
|
|
expect(scrollBy).toHaveBeenCalledWith(3);
|
|
});
|
|
|
|
it('handles mixed direction scroll events in batch', async () => {
|
|
const scrollBy = vi.fn();
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 10,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
// Simulate mixed scroll events: down (1), down (1), up (-1)
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'scroll-down',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
});
|
|
callback({
|
|
name: 'scroll-down',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
});
|
|
callback({
|
|
name: 'scroll-up',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
});
|
|
}
|
|
|
|
expect(scrollBy).not.toHaveBeenCalled();
|
|
|
|
await vi.runAllTimersAsync();
|
|
|
|
expect(scrollBy).toHaveBeenCalledTimes(1);
|
|
expect(scrollBy).toHaveBeenCalledWith(1); // 1 + 1 - 1 = 1
|
|
});
|
|
|
|
it('respects scroll limits during batching', async () => {
|
|
const scrollBy = vi.fn();
|
|
// Start near bottom
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 89,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
// Try to scroll down 3 times, but only 1 is allowed before hitting bottom
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'scroll-down',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
});
|
|
callback({
|
|
name: 'scroll-down',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
});
|
|
callback({
|
|
name: 'scroll-down',
|
|
col: 5,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'none',
|
|
});
|
|
}
|
|
|
|
await vi.runAllTimersAsync();
|
|
|
|
// Should have accumulated only 1, because subsequent scrolls would be blocked
|
|
// Actually, the logic in ScrollProvider uses effectiveScrollTop to check bounds.
|
|
// scrollTop=89, max=90.
|
|
// 1st scroll: pending=1, effective=90. Allowed.
|
|
// 2nd scroll: pending=1, effective=90. canScrollDown checks effective < 90. 90 < 90 is false. Blocked.
|
|
expect(scrollBy).toHaveBeenCalledTimes(1);
|
|
expect(scrollBy).toHaveBeenCalledWith(1);
|
|
});
|
|
|
|
it('calls scrollTo when dragging scrollbar thumb if available', async () => {
|
|
const scrollBy = vi.fn();
|
|
const scrollTo = vi.fn();
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 0,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
scrollTo={scrollTo}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
// Start drag on thumb
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'left-press',
|
|
col: 10,
|
|
row: 0,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'left',
|
|
});
|
|
}
|
|
|
|
// Move mouse down
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'move',
|
|
col: 10,
|
|
row: 5, // Move down 5 units
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'left',
|
|
});
|
|
}
|
|
|
|
// Release
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'left-release',
|
|
col: 10,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'left',
|
|
});
|
|
}
|
|
|
|
expect(scrollTo).toHaveBeenCalled();
|
|
expect(scrollBy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('calls scrollBy when dragging scrollbar thumb if scrollTo is not available', async () => {
|
|
const scrollBy = vi.fn();
|
|
const getScrollState = vi.fn(() => ({
|
|
scrollTop: 0,
|
|
scrollHeight: 100,
|
|
innerHeight: 10,
|
|
}));
|
|
|
|
render(
|
|
<ScrollProvider>
|
|
<TestScrollable
|
|
id="test-scrollable"
|
|
scrollBy={scrollBy}
|
|
getScrollState={getScrollState}
|
|
/>
|
|
</ScrollProvider>,
|
|
);
|
|
|
|
// Start drag on thumb
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'left-press',
|
|
col: 10,
|
|
row: 0,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'left',
|
|
});
|
|
}
|
|
|
|
// Move mouse down
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'move',
|
|
col: 10,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'left',
|
|
});
|
|
}
|
|
|
|
for (const callback of mockUseMouseCallbacks) {
|
|
callback({
|
|
name: 'left-release',
|
|
col: 10,
|
|
row: 5,
|
|
shift: false,
|
|
ctrl: false,
|
|
meta: false,
|
|
button: 'left',
|
|
});
|
|
}
|
|
|
|
expect(scrollBy).toHaveBeenCalled();
|
|
});
|
|
});
|