mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-31 14:12:50 -07:00
7faa50cbae
## 1. What the change is This PR refactors the `open_issues.ts` and `open_prs.ts` metric scripts to use the GitHub GraphQL API's `totalCount` field instead of relying on the CLI's `gh issue list` command with a hardcoded limit. It also updates `review_distribution.ts` to include `COLLABORATOR` in the maintainer association check. ## 2. Why it is recommended The current implementation of `open_issues.ts` and `open_prs.ts` used `--limit 1000`, which caused metrics to be capped at 1000 even when the actual backlog was much larger (~2400 issues). This provided a misleading view of repository health and the true scale of the backlog. Using GraphQL `totalCount` ensures accurate counts regardless of list size. Additionally, `review_distribution.ts` was inconsistently excluding `COLLABORATOR` associations, which could lead to an inaccurate representation of review work distribution if many maintainers are designated as Collaborators. This led to a `review_distribution_variance` of 0 in recent runs. ## 3. Which metric or aspect of productivity is expected to be improved - **open_issues**: Will now reflect the true total count (expected to jump from 1000 to ~2400). - **open_prs**: Will reflect the true total count of open pull requests. - **review_distribution_variance**: Will more accurately reflect how review work is shared among all maintainers (including collaborators). ## 4. By how much the metric is expected to improve The `open_issues` metric is expected to increase by approximately **140%** (from 1000 to ~2400) once accurate data is collected. The `review_distribution_variance` is expected to become non-zero, providing a real baseline for monitoring reviewer workload balance.
166 lines
4.5 KiB
TypeScript
166 lines
4.5 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2026 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*
|
|
* @license
|
|
*/
|
|
|
|
import { GITHUB_OWNER, GITHUB_REPO, type MetricOutput } from '../types.js';
|
|
import { execSync } from 'node:child_process';
|
|
|
|
try {
|
|
const query = `
|
|
query($owner: String!, $repo: String!) {
|
|
repository(owner: $owner, name: $repo) {
|
|
pullRequests(last: 100) {
|
|
nodes {
|
|
authorAssociation
|
|
author { login }
|
|
createdAt
|
|
comments(first: 20) {
|
|
nodes {
|
|
author { login }
|
|
createdAt
|
|
}
|
|
}
|
|
reviews(first: 20) {
|
|
nodes {
|
|
author { login }
|
|
createdAt
|
|
}
|
|
}
|
|
}
|
|
}
|
|
issues(last: 100) {
|
|
nodes {
|
|
authorAssociation
|
|
author { login }
|
|
createdAt
|
|
comments(first: 20) {
|
|
nodes {
|
|
author { login }
|
|
createdAt
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`;
|
|
const output = execSync(
|
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
|
{
|
|
encoding: 'utf-8',
|
|
input: query,
|
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
|
},
|
|
);
|
|
const response = JSON.parse(output);
|
|
if (response.errors) {
|
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
|
}
|
|
const data = response.data.repository;
|
|
|
|
const getFirstResponseTime = (item: {
|
|
createdAt: string;
|
|
author: { login: string };
|
|
comments: { nodes: { createdAt: string; author?: { login: string } }[] };
|
|
reviews?: { nodes: { createdAt: string; author?: { login: string } }[] };
|
|
}) => {
|
|
const authorLogin = item.author?.login;
|
|
let earliestResponse: number | null = null;
|
|
|
|
const checkNodes = (
|
|
nodes: { createdAt: string; author?: { login: string } }[],
|
|
) => {
|
|
for (const node of nodes) {
|
|
if (node.author?.login && node.author.login !== authorLogin) {
|
|
const login = node.author.login.toLowerCase();
|
|
if (login.endsWith('[bot]') || login.includes('bot')) {
|
|
continue; // Ignore bots
|
|
}
|
|
const time = new Date(node.createdAt).getTime();
|
|
if (!earliestResponse || time < earliestResponse) {
|
|
earliestResponse = time;
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
if (item.comments?.nodes) checkNodes(item.comments.nodes);
|
|
if (item.reviews?.nodes) checkNodes(item.reviews.nodes);
|
|
|
|
if (earliestResponse) {
|
|
return (
|
|
(earliestResponse - new Date(item.createdAt).getTime()) /
|
|
(1000 * 60 * 60)
|
|
);
|
|
}
|
|
return null; // No response yet
|
|
};
|
|
const processItems = (
|
|
items: {
|
|
authorAssociation: string;
|
|
createdAt: string;
|
|
author: { login: string };
|
|
comments: {
|
|
nodes: { createdAt: string; author?: { login: string } }[];
|
|
};
|
|
reviews?: {
|
|
nodes: { createdAt: string; author?: { login: string } }[];
|
|
};
|
|
}[],
|
|
) => {
|
|
return items
|
|
.map((item) => ({
|
|
association: item.authorAssociation,
|
|
ttfr: getFirstResponseTime(item),
|
|
}))
|
|
.filter((i) => i.ttfr !== null) as {
|
|
association: string;
|
|
ttfr: number;
|
|
}[];
|
|
};
|
|
const prs = processItems(data.pullRequests.nodes);
|
|
const issues = processItems(data.issues.nodes);
|
|
const allItems = [...prs, ...issues];
|
|
|
|
const isMaintainer = (assoc: string) => ['MEMBER', 'OWNER'].includes(assoc);
|
|
const is1P = (assoc: string) => ['COLLABORATOR'].includes(assoc);
|
|
|
|
const calculateAvg = (items: { ttfr: number; association: string }[]) =>
|
|
items.length ? items.reduce((a, b) => a + b.ttfr, 0) / items.length : 0;
|
|
|
|
const maintainers = calculateAvg(
|
|
allItems.filter((i) => isMaintainer(i.association)),
|
|
);
|
|
const firstParty = calculateAvg(allItems.filter((i) => is1P(i.association)));
|
|
const overall = calculateAvg(allItems);
|
|
|
|
const timestamp = new Date().toISOString();
|
|
|
|
const metrics: MetricOutput[] = [
|
|
{
|
|
metric: 'time_to_first_response_overall_hours',
|
|
value: Math.round(overall * 100) / 100,
|
|
timestamp,
|
|
},
|
|
{
|
|
metric: 'time_to_first_response_maintainers_hours',
|
|
value: Math.round(maintainers * 100) / 100,
|
|
timestamp,
|
|
},
|
|
{
|
|
metric: 'time_to_first_response_1p_hours',
|
|
value: Math.round(firstParty * 100) / 100,
|
|
timestamp,
|
|
},
|
|
];
|
|
|
|
metrics.forEach((m) => process.stdout.write(JSON.stringify(m) + '\n'));
|
|
} catch (err) {
|
|
process.stderr.write(err instanceof Error ? err.message : String(err));
|
|
process.exit(1);
|
|
}
|