mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-19 00:02:51 -07:00
868913e446
This PR updates the metrics scripts to resolve lint errors and improve architectural consistency after the conversion to CSV format.
### 🛠 Fixes
1. **Lint Errors**: Resolved 6 `@typescript-eslint/no-unused-vars` errors by removing the unused `MetricOutput` import across the metric suite.
2. **License Standardization**: Removed redundant `@license` tags from all 8 metric scripts to match repository standards.
3. **GraphQL Consistency**: Updated `open_issues.ts` and `open_prs.ts` to use GraphQL variables (`-F`) and the `gh api graphql` pattern used by other scripts, improving security and readability.
4. **Output Consistency**: Migrated `open_issues.ts` and `open_prs.ts` from `console.log` to `process.stdout.write` for unified output behavior.
5. **Robust Execution**: Added `stdio: ['ignore', 'pipe', 'ignore']` to all `execSync` calls to ensure clean output streams and prevent unintentional inheritance of the parent process's stdio.
6. **Code Cleanup**: Removed the now-unused `MetricOutput` interface from `types.ts` and simplified `metrics/index.ts` by removing legacy JSON parsing logic.
### 🧪 Verification
- `npm run lint` now passes for all files in `tools/gemini-cli-bot/metrics/`.
- Validated all 8 scripts manually to ensure they still produce the correct CSV output.
134 lines
3.4 KiB
TypeScript
134 lines
3.4 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2026 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import { readdirSync, writeFileSync, existsSync, readFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { execFileSync } from 'node:child_process';
|
|
import { getHistoricalAverage } from './history-helper.js';
|
|
|
|
const SCRIPTS_DIR = join(
|
|
process.cwd(),
|
|
'tools',
|
|
'gemini-cli-bot',
|
|
'metrics',
|
|
'scripts',
|
|
);
|
|
const SYNC_SCRIPT = join(
|
|
process.cwd(),
|
|
'tools',
|
|
'gemini-cli-bot',
|
|
'history',
|
|
'sync.ts',
|
|
);
|
|
const OUTPUT_FILE = join(
|
|
process.cwd(),
|
|
'tools',
|
|
'gemini-cli-bot',
|
|
'history',
|
|
'metrics-before.csv',
|
|
);
|
|
const TIMESERIES_FILE = join(
|
|
process.cwd(),
|
|
'tools',
|
|
'gemini-cli-bot',
|
|
'history',
|
|
'metrics-timeseries.csv',
|
|
);
|
|
|
|
function processOutputLine(line: string, results: string[]) {
|
|
const trimmedLine = line.trim();
|
|
if (!trimmedLine) return;
|
|
|
|
const parts = trimmedLine.split(',');
|
|
if (parts.length !== 2) {
|
|
results.push(trimmedLine);
|
|
return;
|
|
}
|
|
|
|
const metricName = parts[0];
|
|
const metricValue = parseFloat(parts[1]);
|
|
results.push(trimmedLine);
|
|
|
|
// Calculate and append deltas if the metric is a valid number
|
|
if (metricName && !isNaN(metricValue)) {
|
|
const avg7d = getHistoricalAverage(metricName, 7);
|
|
if (avg7d !== null) {
|
|
results.push(
|
|
`${metricName}_delta_7d,${(metricValue - avg7d).toFixed(2)}`,
|
|
);
|
|
}
|
|
|
|
const avg30d = getHistoricalAverage(metricName, 30);
|
|
if (avg30d !== null) {
|
|
results.push(
|
|
`${metricName}_delta_30d,${(metricValue - avg30d).toFixed(2)}`,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
async function run() {
|
|
// Sync history first
|
|
console.log('Syncing history...');
|
|
try {
|
|
execFileSync('npx', ['tsx', SYNC_SCRIPT], { stdio: 'inherit' });
|
|
} catch (error) {
|
|
console.error('History sync failed, continuing without history:', error);
|
|
}
|
|
|
|
const scripts = readdirSync(SCRIPTS_DIR).filter(
|
|
(file) => file.endsWith('.ts') || file.endsWith('.js'),
|
|
);
|
|
|
|
const results: string[] = ['metric,value'];
|
|
|
|
for (const script of scripts) {
|
|
console.log(`Running metric script: ${script}`);
|
|
try {
|
|
const scriptPath = join(SCRIPTS_DIR, script);
|
|
const output = execFileSync('npx', ['tsx', scriptPath], {
|
|
encoding: 'utf-8',
|
|
shell: process.platform === 'win32',
|
|
});
|
|
|
|
const lines = output.trim().split('\n');
|
|
for (const line of lines) {
|
|
processOutputLine(line, results);
|
|
}
|
|
} catch (error) {
|
|
console.error(`Error running ${script}:`, error);
|
|
}
|
|
}
|
|
|
|
writeFileSync(OUTPUT_FILE, results.join('\n'));
|
|
console.log(`Saved metrics to ${OUTPUT_FILE}`);
|
|
|
|
// Update timeseries with rolling window (keep last 100 lines)
|
|
const timestamp = new Date().toISOString();
|
|
let timeseriesLines: string[] = [];
|
|
if (existsSync(TIMESERIES_FILE)) {
|
|
timeseriesLines = readFileSync(TIMESERIES_FILE, 'utf-8').trim().split('\n');
|
|
} else {
|
|
timeseriesLines = ['timestamp,metric,value'];
|
|
}
|
|
|
|
const newRows = results.slice(1).map((row) => `${timestamp},${row}`);
|
|
if (newRows.length > 0) {
|
|
timeseriesLines.push(...newRows);
|
|
|
|
// Keep header + last 100 data rows
|
|
if (timeseriesLines.length > 101) {
|
|
const header = timeseriesLines[0];
|
|
timeseriesLines = [header, ...timeseriesLines.slice(-100)];
|
|
}
|
|
|
|
writeFileSync(TIMESERIES_FILE, timeseriesLines.join('\n') + '\n');
|
|
console.log(`Updated timeseries at ${TIMESERIES_FILE} (rolling window)`);
|
|
}
|
|
}
|
|
|
|
run().catch(console.error);
|