mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-20 08:42:39 -07:00
gemini-cli[bot]
868913e446
This PR updates the metrics scripts to resolve lint errors and improve architectural consistency after the conversion to CSV format.
### 🛠 Fixes
1. **Lint Errors**: Resolved 6 `@typescript-eslint/no-unused-vars` errors by removing the unused `MetricOutput` import across the metric suite.
2. **License Standardization**: Removed redundant `@license` tags from all 8 metric scripts to match repository standards.
3. **GraphQL Consistency**: Updated `open_issues.ts` and `open_prs.ts` to use GraphQL variables (`-F`) and the `gh api graphql` pattern used by other scripts, improving security and readability.
4. **Output Consistency**: Migrated `open_issues.ts` and `open_prs.ts` from `console.log` to `process.stdout.write` for unified output behavior.
5. **Robust Execution**: Added `stdio: ['ignore', 'pipe', 'ignore']` to all `execSync` calls to ensure clean output streams and prevent unintentional inheritance of the parent process's stdio.
6. **Code Cleanup**: Removed the now-unused `MetricOutput` interface from `types.ts` and simplified `metrics/index.ts` by removing legacy JSON parsing logic.
### 🧪 Verification
- `npm run lint` now passes for all files in `tools/gemini-cli-bot/metrics/`.
- Validated all 8 scripts manually to ensure they still produce the correct CSV output.
72 lines
2.0 KiB
TypeScript
72 lines
2.0 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2026 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import { GITHUB_OWNER, GITHUB_REPO } from '../types.js';
|
|
import { execSync } from 'node:child_process';
|
|
|
|
try {
|
|
const query = `
|
|
query($owner: String!, $repo: String!) {
|
|
repository(owner: $owner, name: $repo) {
|
|
pullRequests(last: 100) {
|
|
nodes {
|
|
reviews(first: 50) {
|
|
nodes {
|
|
author { login }
|
|
authorAssociation
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`;
|
|
const output = execSync(
|
|
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
|
{ encoding: 'utf-8', stdio: ['ignore', 'pipe', 'ignore'] },
|
|
);
|
|
const data = JSON.parse(output).data.repository;
|
|
|
|
const reviewCounts: Record<string, number> = {};
|
|
|
|
for (const pr of data.pullRequests.nodes) {
|
|
if (!pr.reviews?.nodes) continue;
|
|
// We only count one review per author per PR to avoid counting multiple review comments as multiple reviews
|
|
const reviewersOnPR = new Set<string>();
|
|
|
|
for (const review of pr.reviews.nodes) {
|
|
if (
|
|
['MEMBER', 'OWNER', 'COLLABORATOR'].includes(review.authorAssociation) &&
|
|
review.author?.login
|
|
) {
|
|
const login = review.author.login.toLowerCase();
|
|
if (login.endsWith('[bot]') || login.includes('bot')) {
|
|
continue; // Ignore bots
|
|
}
|
|
reviewersOnPR.add(review.author.login);
|
|
}
|
|
}
|
|
|
|
for (const reviewer of reviewersOnPR) {
|
|
reviewCounts[reviewer] = (reviewCounts[reviewer] || 0) + 1;
|
|
}
|
|
}
|
|
|
|
const counts = Object.values(reviewCounts);
|
|
|
|
let variance = 0;
|
|
if (counts.length > 0) {
|
|
const mean = counts.reduce((a, b) => a + b, 0) / counts.length;
|
|
variance =
|
|
counts.reduce((a, b) => a + Math.pow(b - mean, 2), 0) / counts.length;
|
|
}
|
|
|
|
process.stdout.write(`review_distribution_variance,${Math.round(variance * 100) / 100}\n`);
|
|
} catch (err) {
|
|
process.stderr.write(err instanceof Error ? err.message : String(err));
|
|
process.exit(1);
|
|
}
|