mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-16 14:53:19 -07:00
868913e446
This PR updates the metrics scripts to resolve lint errors and improve architectural consistency after the conversion to CSV format.
### 🛠 Fixes
1. **Lint Errors**: Resolved 6 `@typescript-eslint/no-unused-vars` errors by removing the unused `MetricOutput` import across the metric suite.
2. **License Standardization**: Removed redundant `@license` tags from all 8 metric scripts to match repository standards.
3. **GraphQL Consistency**: Updated `open_issues.ts` and `open_prs.ts` to use GraphQL variables (`-F`) and the `gh api graphql` pattern used by other scripts, improving security and readability.
4. **Output Consistency**: Migrated `open_issues.ts` and `open_prs.ts` from `console.log` to `process.stdout.write` for unified output behavior.
5. **Robust Execution**: Added `stdio: ['ignore', 'pipe', 'ignore']` to all `execSync` calls to ensure clean output streams and prevent unintentional inheritance of the parent process's stdio.
6. **Code Cleanup**: Removed the now-unused `MetricOutput` interface from `types.ts` and simplified `metrics/index.ts` by removing legacy JSON parsing logic.
### 🧪 Verification
- `npm run lint` now passes for all files in `tools/gemini-cli-bot/metrics/`.
- Validated all 8 scripts manually to ensure they still produce the correct CSV output.
101 lines
3.6 KiB
TypeScript
101 lines
3.6 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2026 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import { GITHUB_OWNER, GITHUB_REPO } from '../types.js';
|
|
import { execSync } from 'node:child_process';
|
|
|
|
try {
|
|
const query = `
|
|
query($owner: String!, $repo: String!) {
|
|
repository(owner: $owner, name: $repo) {
|
|
pullRequests(last: 100, states: MERGED) {
|
|
nodes {
|
|
authorAssociation
|
|
mergedAt
|
|
}
|
|
}
|
|
issues(last: 100, states: CLOSED) {
|
|
nodes {
|
|
authorAssociation
|
|
closedAt
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`;
|
|
const output = execSync(
|
|
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
|
{ encoding: 'utf-8', stdio: ['ignore', 'pipe', 'ignore'] },
|
|
);
|
|
const data = JSON.parse(output).data.repository;
|
|
|
|
const prs = data.pullRequests.nodes
|
|
.map((p: { authorAssociation: string; mergedAt: string }) => ({
|
|
association: p.authorAssociation,
|
|
date: new Date(p.mergedAt).getTime(),
|
|
}))
|
|
.sort((a: { date: number }, b: { date: number }) => a.date - b.date);
|
|
|
|
const issues = data.issues.nodes
|
|
.map((i: { authorAssociation: string; closedAt: string }) => ({
|
|
association: i.authorAssociation,
|
|
date: new Date(i.closedAt).getTime(),
|
|
}))
|
|
.sort((a: { date: number }, b: { date: number }) => a.date - b.date);
|
|
|
|
const isMaintainer = (assoc: string) =>
|
|
['MEMBER', 'OWNER', 'COLLABORATOR'].includes(assoc);
|
|
|
|
const calculateThroughput = (
|
|
items: { association: string; date: number }[],
|
|
) => {
|
|
if (items.length < 2) return 0;
|
|
const first = items[0].date;
|
|
const last = items[items.length - 1].date;
|
|
const days = (last - first) / (1000 * 60 * 60 * 24);
|
|
return days > 0 ? items.length / days : items.length; // items per day
|
|
};
|
|
|
|
const prOverall = calculateThroughput(prs);
|
|
const prMaintainers = calculateThroughput(
|
|
prs.filter((i: { association: string; date: number }) =>
|
|
isMaintainer(i.association),
|
|
),
|
|
);
|
|
const prCommunity = calculateThroughput(
|
|
prs.filter(
|
|
(i: { association: string; date: number }) =>
|
|
!isMaintainer(i.association),
|
|
),
|
|
);
|
|
|
|
const issueOverall = calculateThroughput(issues);
|
|
const issueMaintainers = calculateThroughput(
|
|
issues.filter((i: { association: string; date: number }) =>
|
|
isMaintainer(i.association),
|
|
),
|
|
);
|
|
const issueCommunity = calculateThroughput(
|
|
issues.filter(
|
|
(i: { association: string; date: number }) =>
|
|
!isMaintainer(i.association),
|
|
),
|
|
);
|
|
|
|
process.stdout.write(`throughput_pr_overall_per_day,${Math.round(prOverall * 100) / 100}\n`);
|
|
process.stdout.write(`throughput_pr_maintainers_per_day,${Math.round(prMaintainers * 100) / 100}\n`);
|
|
process.stdout.write(`throughput_pr_community_per_day,${Math.round(prCommunity * 100) / 100}\n`);
|
|
process.stdout.write(`throughput_issue_overall_per_day,${Math.round(issueOverall * 100) / 100}\n`);
|
|
process.stdout.write(`throughput_issue_maintainers_per_day,${Math.round(issueMaintainers * 100) / 100}\n`);
|
|
process.stdout.write(`throughput_issue_community_per_day,${Math.round(issueCommunity * 100) / 100}\n`);
|
|
process.stdout.write(`throughput_issue_overall_days_per_issue,${issueOverall > 0 ? Math.round((1 / issueOverall) * 100) / 100 : 0}\n`);
|
|
process.stdout.write(`throughput_issue_maintainers_days_per_issue,${issueMaintainers > 0 ? Math.round((1 / issueMaintainers) * 100) / 100 : 0}\n`);
|
|
process.stdout.write(`throughput_issue_community_days_per_issue,${issueCommunity > 0 ? Math.round((1 / issueCommunity) * 100) / 100 : 0}\n`);
|
|
} catch (err) {
|
|
process.stderr.write(err instanceof Error ? err.message : String(err));
|
|
process.exit(1);
|
|
}
|