mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-19 00:02:51 -07:00
gemini-cli[bot]
868913e446
This PR updates the metrics scripts to resolve lint errors and improve architectural consistency after the conversion to CSV format.
### 🛠 Fixes
1. **Lint Errors**: Resolved 6 `@typescript-eslint/no-unused-vars` errors by removing the unused `MetricOutput` import across the metric suite.
2. **License Standardization**: Removed redundant `@license` tags from all 8 metric scripts to match repository standards.
3. **GraphQL Consistency**: Updated `open_issues.ts` and `open_prs.ts` to use GraphQL variables (`-F`) and the `gh api graphql` pattern used by other scripts, improving security and readability.
4. **Output Consistency**: Migrated `open_issues.ts` and `open_prs.ts` from `console.log` to `process.stdout.write` for unified output behavior.
5. **Robust Execution**: Added `stdio: ['ignore', 'pipe', 'ignore']` to all `execSync` calls to ensure clean output streams and prevent unintentional inheritance of the parent process's stdio.
6. **Code Cleanup**: Removed the now-unused `MetricOutput` interface from `types.ts` and simplified `metrics/index.ts` by removing legacy JSON parsing logic.
### 🧪 Verification
- `npm run lint` now passes for all files in `tools/gemini-cli-bot/metrics/`.
- Validated all 8 scripts manually to ensure they still produce the correct CSV output.
85 lines
2.3 KiB
TypeScript
85 lines
2.3 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2026 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import { GITHUB_OWNER, GITHUB_REPO } from '../types.js';
|
|
import { execSync } from 'node:child_process';
|
|
|
|
try {
|
|
const query = `
|
|
query($owner: String!, $repo: String!) {
|
|
repository(owner: $owner, name: $repo) {
|
|
pullRequests(last: 100, states: MERGED) {
|
|
nodes {
|
|
authorAssociation
|
|
comments { totalCount }
|
|
reviews { totalCount }
|
|
}
|
|
}
|
|
issues(last: 100, states: CLOSED) {
|
|
nodes {
|
|
authorAssociation
|
|
comments { totalCount }
|
|
}
|
|
}
|
|
}
|
|
}
|
|
`;
|
|
const output = execSync(
|
|
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
|
{ encoding: 'utf-8', stdio: ['ignore', 'pipe', 'ignore'] },
|
|
);
|
|
const data = JSON.parse(output).data.repository;
|
|
|
|
const prs = data.pullRequests.nodes;
|
|
const issues = data.issues.nodes;
|
|
|
|
const allItems = [
|
|
...prs.map(
|
|
(p: {
|
|
authorAssociation: string;
|
|
comments: { totalCount: number };
|
|
reviews?: { totalCount: number };
|
|
}) => ({
|
|
association: p.authorAssociation,
|
|
touches: p.comments.totalCount + (p.reviews ? p.reviews.totalCount : 0),
|
|
}),
|
|
),
|
|
...issues.map(
|
|
(i: { authorAssociation: string; comments: { totalCount: number } }) => ({
|
|
association: i.authorAssociation,
|
|
touches: i.comments.totalCount,
|
|
}),
|
|
),
|
|
];
|
|
|
|
const isMaintainer = (assoc: string) =>
|
|
['MEMBER', 'OWNER', 'COLLABORATOR'].includes(assoc);
|
|
|
|
const calculateAvg = (items: { touches: number; association: string }[]) =>
|
|
items.length ? items.reduce((a, b) => a + b.touches, 0) / items.length : 0;
|
|
|
|
const overall = calculateAvg(allItems);
|
|
const maintainers = calculateAvg(
|
|
allItems.filter((i) => isMaintainer(i.association)),
|
|
);
|
|
const community = calculateAvg(
|
|
allItems.filter((i) => !isMaintainer(i.association)),
|
|
);
|
|
|
|
process.stdout.write(
|
|
`user_touches_overall,${Math.round(overall * 100) / 100}\n`,
|
|
);
|
|
process.stdout.write(
|
|
`user_touches_maintainers,${Math.round(maintainers * 100) / 100}\n`,
|
|
);
|
|
process.stdout.write(
|
|
`user_touches_community,${Math.round(community * 100) / 100}\n`,
|
|
);
|
|
} catch (err) {
|
|
process.stderr.write(err instanceof Error ? err.message : String(err));
|
|
process.exit(1);
|
|
}
|