MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-16 00:51:25 -07:00
Code Issues Packages Projects Releases Wiki Activity

Restrict integration tests tools (#14403)

Browse Source
This commit is contained in:
Tommaso Sciortino
2025-12-02 17:43:06 -08:00
committed by GitHub
parent bdbbe9232d
commit 035bea3699
10 changed files with 63 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
integration-tests/file-system.test.ts
View File

@@ -12,7 +12,9 @@ import { TestRig, printDebugInfo, validateModelOutput } from './test-helper.js';
describe('file-system', () => {
it('should be able to read a file', async () => {
const rig = new TestRig();
await rig.setup('should be able to read a file');
await rig.setup('should be able to read a file', {
settings: { tools: { core: ['read_file'] } },
});
rig.createFile('test.txt', 'hello world');
const result = await rig.run(
@@ -40,7 +42,9 @@ describe('file-system', () => {
it('should be able to write a file', async () => {
const rig = new TestRig();
await rig.setup('should be able to write a file');
await rig.setup('should be able to write a file', {
settings: { tools: { core: ['write_file', 'replace', 'read_file'] } },
});
rig.createFile('test.txt', '');
const result = await rig.run(`edit test.txt to have a hello world message`);
@@ -95,7 +99,9 @@ describe('file-system', () => {
it('should correctly handle file paths with spaces', async () => {
const rig = new TestRig();
await rig.setup('should correctly handle file paths with spaces');
await rig.setup('should correctly handle file paths with spaces', {
settings: { tools: { core: ['write_file', 'read_file'] } },
});
const fileName = 'my test file.txt';
const result = await rig.run(
@@ -117,7 +123,9 @@ describe('file-system', () => {
it('should perform a read-then-write sequence', async () => {
const rig = new TestRig();
await rig.setup('should perform a read-then-write sequence');
await rig.setup('should perform a read-then-write sequence', {
settings: { tools: { core: ['read_file', 'replace', 'write_file'] } },
});
const fileName = 'version.txt';
rig.createFile(fileName, '1.0.0');
@@ -206,6 +214,7 @@ describe('file-system', () => {
const rig = new TestRig();
await rig.setup(
'should fail safely when trying to edit a non-existent file',
{ settings: { tools: { core: ['read_file', 'replace'] } } },
);
const fileName = 'non_existent.txt';

4
integration-tests/google_web_search.test.ts
View File

@@ -11,7 +11,9 @@ import { TestRig, printDebugInfo, validateModelOutput } from './test-helper.js';
describe(WEB_SEARCH_TOOL_NAME, () => {
it('should be able to search the web', async () => {
const rig = new TestRig();
await rig.setup('should be able to search the web');
await rig.setup('should be able to search the web', {
settings: { tools: { core: [WEB_SEARCH_TOOL_NAME] } },
});
let result;
try {

4
integration-tests/list_directory.test.ts
View File

@@ -17,7 +17,9 @@ import { join } from 'node:path';
describe('list_directory', () => {
it('should be able to list a directory', async () => {
const rig = new TestRig();
rig.setup('should be able to list a directory');
await rig.setup('should be able to list a directory', {
settings: { tools: { core: ['list_directory'] } },
});
rig.createFile('file1.txt', 'file 1 content');
rig.mkdir('subdir');
rig.sync();

4
integration-tests/read_many_files.test.ts
View File

@@ -10,7 +10,9 @@ import { TestRig, printDebugInfo, validateModelOutput } from './test-helper.js';
describe('read_many_files', () => {
it.skip('should be able to read multiple files', async () => {
const rig = new TestRig();
await rig.setup('should be able to read multiple files');
await rig.setup('should be able to read multiple files', {
settings: { tools: { core: ['read_many_files', 'read_file'] } },
});
rig.createFile('file1.txt', 'file 1 content');
rig.createFile('file2.txt', 'file 2 content');

13
integration-tests/replace.test.ts
View File

@@ -10,7 +10,9 @@ import { TestRig } from './test-helper.js';
describe('replace', () => {
it('should be able to replace content in a file', async () => {
const rig = new TestRig();
await rig.setup('should be able to replace content in a file');
await rig.setup('should be able to replace content in a file', {
settings: { tools: { core: ['replace', 'read_file'] } },
});
const fileName = 'file_to_replace.txt';
const originalContent = 'foo content';
@@ -30,6 +32,7 @@ describe('replace', () => {
const rig = new TestRig();
await rig.setup(
'should handle $ literally when replacing text ending with $',
{ settings: { tools: { core: ['replace', 'read_file'] } } },
);
const fileName = 'regex.yml';
@@ -50,7 +53,9 @@ describe('replace', () => {
it.skip('should insert a multi-line block of text', async () => {
const rig = new TestRig();
await rig.setup('should insert a multi-line block of text');
await rig.setup('should insert a multi-line block of text', {
settings: { tools: { core: ['replace', 'read_file'] } },
});
const fileName = 'insert_block.txt';
const originalContent = 'Line A\n<INSERT_TEXT_HERE>\nLine C';
const newBlock = 'First line\nSecond line\nThird line';
@@ -69,7 +74,9 @@ describe('replace', () => {
it.skip('should delete a block of text', async () => {
const rig = new TestRig();
await rig.setup('should delete a block of text');
await rig.setup('should delete a block of text', {
settings: { tools: { core: ['replace', 'read_file'] } },
});
const fileName = 'delete_block.txt';
const blockToDelete =
'## DELETE THIS ##\nThis is a block of text to delete.\n## END DELETE ##';

27
integration-tests/run_shell_command.test.ts
View File

@@ -86,7 +86,9 @@ function getChainedEchoCommand(): { allowPattern: string; command: string } {
describe('run_shell_command', () => {
it('should be able to run a shell command', async () => {
const rig = new TestRig();
await rig.setup('should be able to run a shell command');
await rig.setup('should be able to run a shell command', {
settings: { tools: { core: ['run_shell_command'] } },
});
const prompt = `Please run the command "echo hello-world" and show me the output`;
@@ -118,7 +120,9 @@ describe('run_shell_command', () => {
it('should be able to run a shell command via stdin', async () => {
const rig = new TestRig();
await rig.setup('should be able to run a shell command via stdin');
await rig.setup('should be able to run a shell command via stdin', {
settings: { tools: { core: ['run_shell_command'] } },
});
const prompt = `Please run the command "echo test-stdin" and show me what it outputs`;
@@ -230,7 +234,9 @@ describe('run_shell_command', () => {
it('should succeed with --yolo mode', async () => {
const rig = new TestRig();
await rig.setup('should succeed with --yolo mode');
await rig.setup('should succeed with --yolo mode', {
settings: { tools: { core: ['run_shell_command'] } },
});
const testFile = rig.createFile('test.txt', 'Lorem\nIpsum\nDolor\n');
const { command } = getLineCountCommand();
@@ -362,7 +368,9 @@ describe('run_shell_command', () => {
it('should reject commands not on the allowlist', async () => {
const rig = new TestRig();
await rig.setup('should reject commands not on the allowlist');
await rig.setup('should reject commands not on the allowlist', {
settings: { tools: { core: ['run_shell_command'] } },
});
const testFile = rig.createFile('test.txt', 'Disallowed command check\n');
const allowedCommand = getAllowedListCommand();
@@ -461,6 +469,9 @@ describe('run_shell_command', () => {
const rig = new TestRig();
await rig.setup(
'should allow all with "ShellTool" and other specific tools',
{
settings: { tools: { core: ['run_shell_command'] } },
},
);
const { tool } = getLineCountCommand();
@@ -506,7 +517,9 @@ describe('run_shell_command', () => {
it('should propagate environment variables to the child process', async () => {
const rig = new TestRig();
await rig.setup('should propagate environment variables');
await rig.setup('should propagate environment variables', {
settings: { tools: { core: ['run_shell_command'] } },
});
const varName = 'GEMINI_CLI_TEST_VAR';
const varValue = `test-value-${Math.random().toString(36).substring(7)}`;
@@ -566,7 +579,9 @@ describe('run_shell_command', () => {
it('rejects invalid shell expressions', async () => {
const rig = new TestRig();
await rig.setup('rejects invalid shell expressions');
await rig.setup('rejects invalid shell expressions', {
settings: { tools: { core: ['run_shell_command'] } },
});
const invalidCommand = getInvalidCommand();
const result = await rig.run(
`I am testing the error handling of the run_shell_command tool. Please attempt to run the following command, which I know has invalid syntax: \`${invalidCommand}\`. If the command fails as expected, please return the word FAIL, otherwise return the word SUCCESS.`,

4
integration-tests/save_memory.test.ts
View File

@@ -10,7 +10,9 @@ import { TestRig, printDebugInfo, validateModelOutput } from './test-helper.js';
describe('save_memory', () => {
it('should be able to save to memory', async () => {
const rig = new TestRig();
await rig.setup('should be able to save to memory');
await rig.setup('should be able to save to memory', {
settings: { tools: { core: ['save_memory'] } },
});
const prompt = `remember that my favorite color is blue.

1
integration-tests/simple-mcp-server.test.ts
View File

@@ -177,6 +177,7 @@ describe('simple-mcp-server', () => {
args: ['mcp-server.cjs'],
},
},
tools: { core: [] },
},
});

4
integration-tests/utf-bom-encoding.test.ts
View File

@@ -53,7 +53,9 @@ let dir: string;
describe('BOM end-to-end integraion', () => {
beforeAll(async () => {
rig = new TestRig();
await rig.setup('bom-integration');
await rig.setup('bom-integration', {
settings: { tools: { core: ['read_file'] } },
});
dir = rig.testDir!;
});

4
integration-tests/write_file.test.ts
View File

@@ -15,7 +15,9 @@ import {
describe('write_file', () => {
it('should be able to write a file', async () => {
const rig = new TestRig();
await rig.setup('should be able to write a file');
await rig.setup('should be able to write a file', {
settings: { tools: { core: ['write_file', 'read_file'] } },
});
const prompt = `show me an example of using the write tool. put a dad joke in dad.txt`;
const result = await rig.run(prompt);