MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-29 13:13:21 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(hooks): use file-based hooks instead of node -e for Windows reliability

Browse Source
This commit is contained in:
Taylor Mullen
2026-02-12 10:57:47 -08:00
parent 8f108b039f
commit 0d2be9492e
1 changed files with 25 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-tests/hooks-system.test.ts
+25 -9
View File
@@ -528,8 +528,9 @@ console.log(JSON.stringify({
},
});
// Use node -e to avoid file system and PTY overhead
const nodeCmd = `node -e "console.log(JSON.stringify(${toolConfigJson.replace(/"/g, '\\"')}))"`;
// Use file-based hook to avoid quoting issues
const hookScript = `console.log(JSON.stringify(${toolConfigJson}));`;
const hookFilename = 'before_tool_selection_hook.js';
rig.setup('BeforeToolSelection Hooks', {
fakeResponsesPath: join(
@@ -545,7 +546,7 @@ console.log(JSON.stringify({
hooks: [
{
type: 'command',
command: nodeCmd,
command: `node ${hookFilename}`,
timeout: 60000,
},
],
@@ -555,6 +556,9 @@ console.log(JSON.stringify({
},
});
// Create the hook script after setup
rig.createScript(hookFilename, hookScript);
// Create a test file
rig.createFile('new_file_data.txt', 'test data');
@@ -1773,9 +1777,12 @@ console.log(JSON.stringify({
reason: disabledMsg,
});
// Use node -e to avoid file system and PTY overhead
const enabledCmd = `node -e "console.log(JSON.stringify(${enabledJson.replace(/"/g, '\\"')}))"`;
const disabledCmd = `node -e "console.log(JSON.stringify(${disabledJson.replace(/"/g, '\\"')}))"`;
const enabledScript = `console.log(JSON.stringify(${enabledJson}));`;
const disabledScript = `console.log(JSON.stringify(${disabledJson}));`;
const enabledFilename = 'enabled_hook.js';
const disabledFilename = 'disabled_hook.js';
const enabledCmd = `node ${enabledFilename}`;
const disabledCmd = `node ${disabledFilename}`;
// 3. Final setup with full settings
rig.setup('Hook Disabling', {
@@ -1807,6 +1814,9 @@ console.log(JSON.stringify({
},
});
rig.createScript(enabledFilename, enabledScript);
rig.createScript(disabledFilename, disabledScript);
await rig.run({
args: 'Create a file called disabled-test.txt with content "test"',
});
@@ -1841,9 +1851,12 @@ console.log(JSON.stringify({
reason: disabledMsg,
});
// Use node -e to avoid file system and PTY overhead
const activeCmd = `node -e "console.log(JSON.stringify(${activeJson.replace(/"/g, '\\"')}))"`;
const disabledCmd = `node -e "console.log(JSON.stringify(${disabledJson.replace(/"/g, '\\"')}))"`;
const activeScript = `console.log(JSON.stringify(${activeJson}));`;
const disabledScript = `console.log(JSON.stringify(${disabledJson}));`;
const activeFilename = 'active_hook.js';
const disabledFilename = 'disabled_hook.js';
const activeCmd = `node ${activeFilename}`;
const disabledCmd = `node ${disabledFilename}`;
// 3. Final setup with full settings
rig.setup('Hook Disabling', {
@@ -1871,6 +1884,9 @@ console.log(JSON.stringify({
},
});
rig.createScript(activeFilename, activeScript);
rig.createScript(disabledFilename, disabledScript);
// First run - only active hook should execute
await rig.run({
args: 'Create a file called first-run.txt with "test1"',