MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-11 22:51:00 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): set default maxAttempts in baseLLMClient (#9533)

Browse Source
This commit is contained in:
anthony bushong
2025-09-24 18:18:26 -07:00
committed by GitHub
parent 8abe7e151c
commit 275a12fd45
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/core/baseLlmClient.test.ts
View File

@@ -207,7 +207,7 @@ describe('BaseLlmClient', () => {
await client.generateJson(defaultOptions);
expect(retryWithBackoff).toHaveBeenCalledWith(expect.any(Function), {
maxAttempts: undefined,
maxAttempts: 5,
});
});
});

6
packages/core/src/core/baseLlmClient.ts
View File

@@ -19,6 +19,8 @@ import { logMalformedJsonResponse } from '../telemetry/loggers.js';
import { MalformedJsonResponseEvent } from '../telemetry/types.js';
import { retryWithBackoff } from '../utils/retry.js';
const DEFAULT_MAX_ATTEMPTS = 5;
/**
* Options for the generateJson utility function.
*/
@@ -105,7 +107,9 @@ export class BaseLlmClient {
promptId,
);
const result = await retryWithBackoff(apiCall, { maxAttempts });
const result = await retryWithBackoff(apiCall, {
maxAttempts: maxAttempts ?? DEFAULT_MAX_ATTEMPTS,
});
let text = getResponseText(result)?.trim();
if (!text) {