mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-15 22:33:05 -07:00
Eliminate the critique.
This commit is contained in:
@@ -63,8 +63,6 @@
|
||||
"lint:all": "node scripts/lint.js",
|
||||
"format": "prettier --experimental-cli --write .",
|
||||
"typecheck": "npm run typecheck --workspaces --if-present && tsc -b evals/tsconfig.json integration-tests/tsconfig.json memory-tests/tsconfig.json",
|
||||
"metrics": "tsx tools/gemini-cli-bot/metrics/index.ts",
|
||||
"brain": "node bundle/gemini.js --policy tools/gemini-cli-bot/ci-policy.toml tools/gemini-cli-bot/investigations/metrics_analysis.md && node bundle/gemini.js --policy tools/gemini-cli-bot/ci-policy.toml tools/gemini-cli-bot/critique/policy_evaluation.md",
|
||||
"preflight": "npm run clean && npm ci && npm run format && npm run build && npm run lint:ci && npm run typecheck && npm run test:ci",
|
||||
"prepare": "husky && npm run bundle",
|
||||
"prepare:package": "node scripts/prepare-package.js",
|
||||
|
||||
@@ -1,32 +0,0 @@
|
||||
# Phase: Policy Critique & Evaluation
|
||||
|
||||
## Goal
|
||||
|
||||
Evaluate the effectiveness of current repository policies and automation, and
|
||||
suggest improvements based on empirical data.
|
||||
|
||||
## Context
|
||||
|
||||
- Current "Pulse" scripts are in `tools/gemini-cli-bot/processes/scripts/`.
|
||||
(Note: These may be empty if not yet implemented).
|
||||
- Metrics and investigation results are available.
|
||||
- Previous lessons learned are in `tools/gemini-cli-bot/lessons-learned.md`.
|
||||
|
||||
## Instructions
|
||||
|
||||
1. **Review Policies**: Examine the existing automation in `.github/workflows/`
|
||||
and any scripts in `tools/gemini-cli-bot/processes/scripts/`.
|
||||
2. **Analyze Effectiveness**: Based on the metrics analysis from the
|
||||
Investigation phase, determine if the current policies are achieving their
|
||||
goals.
|
||||
- Is the "Pulse" triage effectively reducing issue/PR latency?
|
||||
- Are stale issues being closed as expected?
|
||||
- Is the "Brain" identifying the right problems?
|
||||
3. **Identify Gaps**: Where is the automation failing? Are there manual tasks
|
||||
that should be automated?
|
||||
4. **Propose Changes**: Recommend specific changes to:
|
||||
- GitHub Workflows.
|
||||
- Triage scripts.
|
||||
- Repository `CONTRIBUTING.md` or `GEMINI.md` guidelines.
|
||||
5. **Record Critique**: Append your evaluation and proposed changes to
|
||||
`tools/gemini-cli-bot/lessons-learned.md`.
|
||||
@@ -73,16 +73,28 @@ Before proposing an intervention, accurately identify the blocker:
|
||||
(do not nudge the author).
|
||||
- **Waiting on System (CI/Infra)**: Needs tooling fixes or reporting.
|
||||
|
||||
### 5. Record Findings & Propose Actions
|
||||
### 5. Policy Critique & Evaluation
|
||||
|
||||
- **Review Existing Policies**: Examine the existing automation in
|
||||
`.github/workflows/` and scripts in `tools/gemini-cli-bot/processes/scripts/`.
|
||||
- **Analyze Effectiveness**: Based on your metrics analysis, determine if
|
||||
current policies are achieving their goals (e.g., Is triage reducing latency?
|
||||
Are stale issues closed as expected?).
|
||||
- **Identify Gaps**: Where is the automation failing? Are there manual tasks
|
||||
that should be automated?
|
||||
|
||||
### 6. Record Findings & Propose Actions
|
||||
|
||||
- Document your formulated hypotheses, the evidence gathered, and your final
|
||||
conclusions in `tools/gemini-cli-bot/lessons-learned.md`.
|
||||
- Propose specific, data-backed actions or script updates to address the root
|
||||
cause. Ensure proposed actions align with the Repo Policy Priorities and
|
||||
include concepts like graceful closures and terminal escalations to prevent
|
||||
spam.
|
||||
cause and any identified policy gaps. Ensure proposed actions align with the
|
||||
Repo Policy Priorities and include concepts like graceful closures and
|
||||
terminal escalations to prevent spam.
|
||||
- Recommend specific changes to GitHub Workflows, Triage scripts, or repository
|
||||
`CONTRIBUTING.md`/`GEMINI.md` guidelines.
|
||||
|
||||
### 6. Execution Constraints
|
||||
### 7. Execution Constraints
|
||||
|
||||
- **Do NOT use the `invoke_agent` tool.**
|
||||
- **Do NOT delegate tasks to subagents (like the `generalist`).**
|
||||
|
||||
Reference in New Issue
Block a user