MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-14 05:42:54 -07:00
Code Issues Packages Projects Releases Wiki Activity

chore(core): add TODOs about parallel tool calls and callId in local session invocation

Browse Source
This commit is contained in:
Adam Weidman
2026-05-13 10:42:21 -04:00
parent 34d41c3e8d
commit 3229726a4e
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/agents/local-session-invocation.ts
+5
View File
@@ -163,6 +163,7 @@ export class LocalSessionInvocation extends BaseToolInvocation<
? sanitizeErrorMessage(String(activity.data['description']))
: undefined;
const args = JSON.stringify(sanitizeToolArgs(activity.data['args']));
// TODO: Use unique callId when available instead of randomUUID to support parallel calls reliably.
recentActivity.push({
id: randomUUID(),
type: 'tool_call',
@@ -186,6 +187,8 @@ export class LocalSessionInvocation extends BaseToolInvocation<
const data = activity.data['data'];
const isError = isToolActivityError(data);
// TODO: Matching tool calls by name is unreliable when parallel tool calls are active.
// Use unique callId when available to find the correct TOOL_CALL_START item.
for (let i = recentActivity.length - 1; i >= 0; i--) {
if (
recentActivity[i].type === 'tool_call' &&
@@ -219,6 +222,8 @@ export class LocalSessionInvocation extends BaseToolInvocation<
? String(activity.data['name'])
: undefined;
// TODO: Matching tool calls by name is unreliable when parallel tool calls are active.
// Use unique callId when available to find the correct TOOL_CALL_START item.
if (toolName && (isCancellation || isRejection)) {
for (let i = recentActivity.length - 1; i >= 0; i--) {
if (