Add consent flag to Link command (#13832)

This commit is contained in:
kevinjwang1
2025-11-26 19:22:26 +00:00
committed by GitHub
parent 4a82b0d891
commit 3406dc5b2e
2 changed files with 28 additions and 2 deletions

View File

@@ -138,6 +138,7 @@ describe('extensions link command', () => {
describe('builder', () => {
interface MockYargs {
positional: Mock;
option: Mock;
check: Mock;
}
@@ -145,6 +146,7 @@ describe('extensions link command', () => {
beforeEach(() => {
yargsMock = {
positional: vi.fn().mockReturnThis(),
option: vi.fn().mockReturnThis(),
check: vi.fn().mockReturnThis(),
};
});
@@ -157,6 +159,12 @@ describe('extensions link command', () => {
describe: 'The name of the extension to link.',
type: 'string',
});
expect(yargsMock.option).toHaveBeenCalledWith('consent', {
describe:
'Acknowledge the security risks of installing an extension and skip the confirmation prompt.',
type: 'boolean',
default: false,
});
expect(yargsMock.check).toHaveBeenCalled();
});
});

View File

@@ -11,7 +11,10 @@ import {
} from '@google/gemini-cli-core';
import { getErrorMessage } from '../../utils/errors.js';
import { requestConsentNonInteractive } from '../../config/extensions/consent.js';
import {
INSTALL_WARNING_MESSAGE,
requestConsentNonInteractive,
} from '../../config/extensions/consent.js';
import { ExtensionManager } from '../../config/extension-manager.js';
import { loadSettings } from '../../config/settings.js';
import { promptForSetting } from '../../config/extensions/extensionSettings.js';
@@ -19,6 +22,7 @@ import { exitCli } from '../utils.js';
interface InstallArgs {
path: string;
consent?: boolean;
}
export async function handleLink(args: InstallArgs) {
@@ -27,10 +31,17 @@ export async function handleLink(args: InstallArgs) {
source: args.path,
type: 'link',
};
const requestConsent = args.consent
? () => Promise.resolve(true)
: requestConsentNonInteractive;
if (args.consent) {
debugLogger.log('You have consented to the following:');
debugLogger.log(INSTALL_WARNING_MESSAGE);
}
const workspaceDir = process.cwd();
const extensionManager = new ExtensionManager({
workspaceDir,
requestConsent: requestConsentNonInteractive,
requestConsent,
requestSetting: promptForSetting,
settings: loadSettings(workspaceDir).merged,
});
@@ -56,10 +67,17 @@ export const linkCommand: CommandModule = {
describe: 'The name of the extension to link.',
type: 'string',
})
.option('consent', {
describe:
'Acknowledge the security risks of installing an extension and skip the confirmation prompt.',
type: 'boolean',
default: false,
})
.check((_) => true),
handler: async (argv) => {
await handleLink({
path: argv['path'] as string,
consent: argv['consent'] as boolean | undefined,
});
await exitCli();
},