MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-06-13 04:48:09 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): ensure global gemini dir resolution is crash-safe during plan validation

Browse Source
This commit is contained in:
Mahima Shanware
2026-04-07 04:25:48 +00:00
parent e42b762553
commit 35fd166bce
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/config/config.ts
+14 -3
View File
@@ -2276,11 +2276,22 @@ export class Config implements McpContext, AgentLoopContext {
} catch (e: unknown) {
mkdirError = e;
}
let realPlansDir: string;
try {
realPlansDir = resolveToRealPath(plansDir);
} catch {
// Fallback to path.resolve if the directory doesn't exist yet (e.g. mkdirSync failed)
// so that the security check can still be performed on the absolute path.
realPlansDir = path.resolve(plansDir);
}
const realPlansDir = resolveToRealPath(plansDir);
const realProjectRoot = this.storage.getRealProjectRoot();
const realGlobalGeminiDir = resolveToRealPath(Storage.getGlobalGeminiDir());
let realGlobalGeminiDir: string;
try {
realGlobalGeminiDir = resolveToRealPath(Storage.getGlobalGeminiDir());
} catch {
realGlobalGeminiDir = path.resolve(Storage.getGlobalGeminiDir());
}
if (
!isSubpath(realProjectRoot, realPlansDir) &&
!isSubpath(realGlobalGeminiDir, realPlansDir)