fix(admin): rename advanced features admin setting (#17786)

This commit is contained in:
Shreya Keshive
2026-01-28 10:53:05 -05:00
committed by GitHub
parent 899e8a9edc
commit 370b165769
3 changed files with 7 additions and 8 deletions

View File

@@ -2302,18 +2302,18 @@ describe('Settings Loading and Merging', () => {
expect(loadedSettings.merged.admin?.extensions?.enabled).toBe(false);
});
it('should set skills based on advancedFeaturesEnabled', () => {
it('should set skills based on unmanagedCapabilitiesEnabled', () => {
const loadedSettings = loadSettings();
loadedSettings.setRemoteAdminSettings({
cliFeatureSetting: {
advancedFeaturesEnabled: true,
unmanagedCapabilitiesEnabled: true,
},
});
expect(loadedSettings.merged.admin.skills?.enabled).toBe(true);
loadedSettings.setRemoteAdminSettings({
cliFeatureSetting: {
advancedFeaturesEnabled: false,
unmanagedCapabilitiesEnabled: false,
},
});
expect(loadedSettings.merged.admin.skills?.enabled).toBe(false);

View File

@@ -361,10 +361,9 @@ export class LoadedSettings {
admin.extensions = {
enabled: cliFeatureSetting?.extensionsSetting?.extensionsEnabled ?? false,
};
if (cliFeatureSetting?.advancedFeaturesEnabled !== undefined) {
admin.skills = { enabled: cliFeatureSetting.advancedFeaturesEnabled };
}
admin.skills = {
enabled: cliFeatureSetting?.unmanagedCapabilitiesEnabled ?? false,
};
this._remoteAdminSettings = { admin };
this._merged = this.computeMergedSettings();

View File

@@ -308,7 +308,7 @@ const ExtensionsSettingSchema = z.object({
const CliFeatureSettingSchema = z.object({
extensionsSetting: ExtensionsSettingSchema.optional(),
advancedFeaturesEnabled: z.boolean().optional(),
unmanagedCapabilitiesEnabled: z.boolean().optional(),
});
const McpSettingSchema = z.object({