MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-11 06:31:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): keep thought summary when loading phrases are off (#20497)

Browse Source 
Co-authored-by: Jacob Richman <jacob314@gmail.com>
This commit is contained in:
Dmitry Lyalin
2026-02-27 09:11:13 -08:00
committed by GitHub
parent e709789067
commit 3b2632fe40
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/cli/src/ui/components/Composer.test.tsx
View File

@@ -402,7 +402,7 @@ describe('Composer', () => {
expect(output).not.toContain('ShortcutsHint');
});
it('renders LoadingIndicator without thought when loadingPhrases is off', async () => {
it('renders LoadingIndicator with thought when loadingPhrases is off', async () => {
const uiState = createMockUIState({
streamingState: StreamingState.Responding,
thought: { subject: 'Hidden', description: 'Should not show' },
@@ -415,7 +415,7 @@ describe('Composer', () => {
const output = lastFrame();
expect(output).toContain('LoadingIndicator');
expect(output).not.toContain('Should not show');
expect(output).toContain('LoadingIndicator: Hidden');
});
it('does not render LoadingIndicator when waiting for confirmation', async () => {

6
packages/cli/src/ui/components/Composer.tsx
View File

@@ -229,8 +229,7 @@ export const Composer = ({ isFocused = true }: { isFocused?: boolean }) => {
inline
thought={
uiState.streamingState ===
StreamingState.WaitingForConfirmation ||
settings.merged.ui.loadingPhrases === 'off'
StreamingState.WaitingForConfirmation
? undefined
: uiState.thought
}
@@ -273,8 +272,7 @@ export const Composer = ({ isFocused = true }: { isFocused?: boolean }) => {
inline
thought={
uiState.streamingState ===
StreamingState.WaitingForConfirmation ||
settings.merged.ui.loadingPhrases === 'off'
StreamingState.WaitingForConfirmation
? undefined
: uiState.thought
}