MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-12 07:01:09 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat(core): simplify subagent success UI and improve early termination display (#21917)

Browse Source
This commit is contained in:
Abhi
2026-03-11 17:11:07 -04:00
committed by GitHub
parent 775bcbf3a6
commit 3bf4f885d8
2 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
packages/core/src/agents/local-invocation.test.ts
View File

@@ -207,8 +207,24 @@ describe('LocalSubagentInvocation', () => {
),
},
]);
expect(result.returnDisplay).toContain('Result:\nAnalysis complete.');
expect(result.returnDisplay).toContain('Termination Reason:\n GOAL');
expect(result.returnDisplay).toBe('Analysis complete.');
expect(result.returnDisplay).not.toContain('Termination Reason');
});
it('should show detailed UI for non-goal terminations (e.g., TIMEOUT)', async () => {
const mockOutput = {
result: 'Partial progress...',
terminate_reason: AgentTerminateMode.TIMEOUT,
};
mockExecutorInstance.run.mockResolvedValue(mockOutput);
const result = await invocation.execute(signal, updateOutput);
expect(result.returnDisplay).toContain(
'### Subagent MockAgent Finished Early',
);
expect(result.returnDisplay).toContain('**Termination Reason:** TIMEOUT');
expect(result.returnDisplay).toContain('Partial progress...');
});
it('should stream THOUGHT_CHUNK activities from the executor', async () => {
@@ -296,7 +312,7 @@ describe('LocalSubagentInvocation', () => {
// Execute without the optional callback
const result = await invocation.execute(signal);
expect(result.error).toBeUndefined();
expect(result.returnDisplay).toContain('Result:\nDone');
expect(result.returnDisplay).toBe('Done');
});
it('should handle executor run failure', async () => {

11
packages/core/src/agents/local-invocation.ts
View File

@@ -253,12 +253,15 @@ Termination Reason: ${output.terminate_reason}
Result:
${output.result}`;
const displayContent = `
Subagent ${this.definition.name} Finished
const displayContent =
output.terminate_reason === AgentTerminateMode.GOAL
? displayResult
: `
### Subagent ${this.definition.name} Finished Early
Termination Reason:\n ${output.terminate_reason}
**Termination Reason:** ${output.terminate_reason}
Result:
**Result/Summary:**
${displayResult}
`;