MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-29 13:13:21 -07:00
Code Issues Packages Projects Releases Wiki Activity

repro: retry rmdir, add more logging, and focus on failing tests

Browse Source
This commit is contained in:
Taylor Mullen
2026-02-10 00:30:48 -08:00
parent a3b4a0a677
commit 4946a5be73
2 changed files with 40 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-tests/hooks-system.test.ts
+7 -4
View File
@@ -87,7 +87,7 @@ describe('Hooks System Integration', () => {
expect(hookTelemetryFound).toBeTruthy();
});
it('should block tool execution and use stderr as reason when hook exits with code 2', async () => {
it.only('should block tool execution and use stderr as reason when hook exits with code 2', async () => {
rig.setup(
'should block tool execution and use stderr as reason when hook exits with code 2',
{
@@ -103,6 +103,9 @@ describe('Hooks System Integration', () => {
"process.stderr.write('File writing blocked by security policy'); process.exit(2);",
);
const normalizedCmd = normalizePath(`node "${scriptPath}"`);
console.log(`[Test] normalizedCmd: ${normalizedCmd}`);
rig.setup(
'should block tool execution and use stderr as reason when hook exits with code 2',
{
@@ -119,7 +122,7 @@ describe('Hooks System Integration', () => {
{
type: 'command',
// Exit with code 2 and write reason to stderr
command: normalizePath(`node "${scriptPath}"`),
command: normalizedCmd!,
timeout: 5000,
},
],
@@ -1885,7 +1888,7 @@ console.log(JSON.stringify({decision: "block", systemMessage: "Disabled hook sho
expect(disabledHookLog).toBeUndefined();
});
it('should respect disabled hooks across multiple operations', async () => {
it.only('should respect disabled hooks across multiple operations', async () => {
rig.setup('should respect disabled hooks across multiple operations', {
fakeResponsesPath: join(
import.meta.dirname,
@@ -1910,7 +1913,7 @@ console.log(JSON.stringify({decision: "block", systemMessage: "Disabled hook sho
settings: {
hooksConfig: {
enabled: true,
disabled: [`node "${disabledPath}"`], // Disable the second hook,
disabled: [normalizePath(`node "${disabledPath}"`)!], // Disable the second hook,
},
hooks: {
BeforeTool: [
packages/test-utils/src/test-rig.ts
+33 -15
View File
@@ -377,22 +377,35 @@ export class TestRig {
if (!this._initialized) {
// Clean up existing directories from previous runs (e.g. retries)
if (fs.existsSync(this.testDir)) {
if (env['VERBOSE'] === 'true' || env['CI'] === 'true') {
console.log(
`[TestRig] Cleaning up existing testDir: ${this.testDir}`,
);
const cleanDir = (dir: string, name: string) => {
if (fs.existsSync(dir)) {
if (env['VERBOSE'] === 'true' || env['CI'] === 'true') {
console.log(`[TestRig] Cleaning up existing ${name}: ${dir}`);
}
for (let i = 0; i < 5; i++) {
try {
fs.rmSync(dir, { recursive: true, force: true });
return;
} catch (err) {
if (i === 4) throw err;
if (env['VERBOSE'] === 'true' || env['CI'] === 'true') {
console.log(
`[TestRig] Failed to clean ${name} (attempt ${i + 1}): ${err}`,
);
}
// Use timeout on windows, sleep on others
const sleepCmd =
process.platform === 'win32' ? 'timeout /t 1' : 'sleep 1';
try {
execSync(sleepCmd);
} catch {}
}
}
}
fs.rmSync(this.testDir, { recursive: true, force: true });
}
if (fs.existsSync(this.homeDir)) {
if (env['VERBOSE'] === 'true' || env['CI'] === 'true') {
console.log(
`[TestRig] Cleaning up existing homeDir: ${this.homeDir}`,
);
}
fs.rmSync(this.homeDir, { recursive: true, force: true });
}
};
cleanDir(this.testDir, 'testDir');
cleanDir(this.homeDir, 'homeDir');
this._initialized = true;
}
@@ -592,6 +605,11 @@ export class TestRig {
});
this._spawnedProcesses.push(child);
if (env['VERBOSE'] === 'true' || env['CI'] === 'true') {
console.log(`[TestRig] Running: ${command} ${commandArgs.join(' ')}`);
console.log(`[TestRig] CWD: ${this.testDir}`);
}
let stdout = '';
let stderr = '';