MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-03-18 01:51:20 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): Correct mouse click cursor positioning for wide characters (#13537)

Browse Source
This commit is contained in:
Sandy Tao
2025-11-21 07:56:31 +08:00
committed by GitHub
parent 78b10dccf1
commit 5982abeffb
2 changed files with 53 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
packages/cli/src/ui/components/shared/text-buffer.test.ts
View File

@@ -963,6 +963,34 @@ describe('useTextBuffer', () => {
expect(state.cursor).toEqual([0, 1]);
expect(state.visualCursor).toEqual([0, 1]);
});
it('moveToVisualPosition: should correctly handle wide characters (Chinese)', () => {
const { result } = renderHook(() =>
useTextBuffer({
initialText: '你好', // 2 chars, width 4
viewport: { width: 10, height: 1 },
isValidPath: () => false,
}),
);
// '你' (width 2): visual 0-1. '好' (width 2): visual 2-3.
// Click on '你' (first half, x=0) -> index 0
act(() => result.current.moveToVisualPosition(0, 0));
expect(getBufferState(result).cursor).toEqual([0, 0]);
// Click on '你' (second half, x=1) -> index 1 (after first char)
act(() => result.current.moveToVisualPosition(0, 1));
expect(getBufferState(result).cursor).toEqual([0, 1]);
// Click on '好' (first half, x=2) -> index 1 (before second char)
act(() => result.current.moveToVisualPosition(0, 2));
expect(getBufferState(result).cursor).toEqual([0, 1]);
// Click on '好' (second half, x=3) -> index 2 (after second char)
act(() => result.current.moveToVisualPosition(0, 3));
expect(getBufferState(result).cursor).toEqual([0, 2]);
});
});
describe('handleInput', () => {