MediaMetz/gemini-cli
1
0
Fork 0
mirror of https://github.com/google-gemini/gemini-cli.git synced 2026-05-15 14:23:02 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli): deduplicate startup extension warnings in terminal UI

Browse Source 
This change introduces a module-level Set to deduplicate warning messages
emitted by the ExtensionManager. This prevents identical warnings (like
missing settings or built-in replacements) from being displayed twice
due to loadCliConfig being invoked multiple times during startup.

Fixes #23175
See also #23171 for the planned long-term refactor.
This commit is contained in:
Moisés Gana Obregón
2026-03-19 23:58:44 +00:00
parent c0bf255c4b
commit 6bc2f89ee9
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/config/extension-manager.ts
+17 -6
View File
@@ -85,6 +85,8 @@ import type { EventEmitter } from 'node:stream';
import { themeManager } from '../ui/themes/theme-manager.js';
import { getFormattedSettingValue } from '../commands/extensions/utils.js';
const emittedWarnings = new Set<string>();
interface ExtensionManagerParams {
enabledExtensionOverrides?: string[];
settings: MergedSettings;
@@ -421,8 +423,11 @@ Would you like to attempt to install via "git clone" instead?`,
.join(
', ',
)}. Please run "gemini extensions config ${newExtensionConfig.name} [setting-name]" to configure them.`;
debugLogger.warn(message);
coreEvents.emitFeedback('warning', message);
if (!emittedWarnings.has(message)) {
debugLogger.warn(message);
coreEvents.emitFeedback('warning', message);
emittedWarnings.add(message);
}
}
if (
@@ -682,8 +687,11 @@ Would you like to attempt to install via "git clone" instead?`,
if (existingIdx !== -1) {
// If the user has a manually installed version of the builtin extension, we warn them.
const message = `Extension "${builtinExt.name}" is now built-in. Your manual installation at "${builtExtensions[existingIdx].path}" is being ignored. Please run "gemini extensions uninstall ${builtinExt.name}" to clean up.`;
debugLogger.warn(message);
coreEvents.emitFeedback('warning', message);
if (!emittedWarnings.has(message)) {
debugLogger.warn(message);
coreEvents.emitFeedback('warning', message);
emittedWarnings.add(message);
}
builtExtensions[existingIdx] = builtinExt;
} else {
// Check if this is the new 'sdd' extension and if 'conductor' is installed.
@@ -693,8 +701,11 @@ Would you like to attempt to install via "git clone" instead?`,
);
if (conductorIdx !== -1) {
const message = `The "conductor" extension has been replaced by built-in Spec-Driven Development. Your project files in "/conductor" are preserved. Run "/spec:setup" to get started.`;
debugLogger.warn(message);
coreEvents.emitFeedback('warning', message);
if (!emittedWarnings.has(message)) {
debugLogger.warn(message);
coreEvents.emitFeedback('warning', message);
emittedWarnings.add(message);
}
}
}
builtExtensions.push(builtinExt);