fix spacing (#19494)

This commit is contained in:
Jacob Richman
2026-02-18 22:39:54 -08:00
committed by GitHub
parent a804f99fe0
commit 70b427c7dd
3 changed files with 75 additions and 1 deletions

View File

@@ -427,6 +427,65 @@ describe('MainContent', () => {
unmount();
});
it('renders a split tool group without a gap between static and pending areas', async () => {
const toolCalls = [
{
callId: 'tool-1',
name: 'test-tool',
description: 'A tool for testing',
resultDisplay: 'Part 1',
status: CoreToolCallStatus.Success,
} as IndividualToolCallDisplay,
];
const pendingToolCalls = [
{
callId: 'tool-2',
name: 'test-tool',
description: 'A tool for testing',
resultDisplay: 'Part 2',
status: CoreToolCallStatus.Success,
} as IndividualToolCallDisplay,
];
const uiState = {
...defaultMockUiState,
history: [
{
id: 1,
type: 'tool_group' as const,
tools: toolCalls,
borderBottom: false,
},
],
pendingHistoryItems: [
{
type: 'tool_group' as const,
tools: pendingToolCalls,
borderTop: false,
borderBottom: true,
},
],
};
const { lastFrame, waitUntilReady, unmount } = renderWithProviders(
<MainContent />,
{
uiState: uiState as Partial<UIState>,
},
);
await waitUntilReady();
const output = lastFrame();
// Verify Part 1 and Part 2 are rendered.
expect(output).toContain('Part 1');
expect(output).toContain('Part 2');
// The snapshot will be the best way to verify there is no gap (empty line) between them.
expect(output).toMatchSnapshot();
unmount();
});
describe('MainContent Tool Output Height Logic', () => {
const testCases = [
{

View File

@@ -107,3 +107,18 @@ exports[`MainContent > MainContent Tool Output Height Logic > 'Normal mode - Unc
ShowMoreLines
"
`;
exports[`MainContent > renders a split tool group without a gap between static and pending areas 1`] = `
"AppHeader(full)
╭──────────────────────────────────────────────────────────────────────────────────────────────╮
│ ✓ test-tool A tool for testing │
│ │
│ Part 1 │
│ │
│ ✓ test-tool A tool for testing │
│ │
│ Part 2 │
╰──────────────────────────────────────────────────────────────────────────────────────────────╯
ShowMoreLines
"
`;

View File

@@ -148,7 +148,7 @@ export const ToolGroupMessage: React.FC<ToolGroupMessageProps> = ({
*/
width={terminalWidth}
paddingRight={TOOL_MESSAGE_HORIZONTAL_MARGIN}
marginBottom={1}
marginBottom={borderBottomOverride === false ? 0 : 1}
>
{visibleToolCalls.map((tool, index) => {
const isFirst = index === 0;