fix(cli): add missing response key to custom theme text schema (#25822)

Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com>
This commit is contained in:
Gaurav Dubey
2026-04-27 20:31:30 +05:30
committed by GitHub
parent 42587de733
commit 743518e1b8
3 changed files with 31 additions and 0 deletions
@@ -298,6 +298,33 @@ describe('settings-validation', () => {
expect(issue).toBeDefined();
}
});
it('should accept customThemes with text.response color override', () => {
// Regression test for #25610: `response` is a documented and
// implemented color override for model responses (see
// packages/cli/src/ui/themes/theme.ts and semantic-tokens.ts),
// but was missing from the CustomTheme validation schema.
const validSettings = {
ui: {
theme: 'LimeWhite',
customThemes: {
LimeWhite: {
type: 'custom',
name: 'LimeWhite',
text: {
primary: '#00FF00',
response: '#FFFFFF',
secondary: '#a0a0a0',
accent: '#00FF00',
},
},
},
},
};
const result = validateSettings(validSettings);
expect(result.success).toBe(true);
});
});
describe('formatValidationError', () => {
@@ -3278,6 +3278,7 @@ export const SETTINGS_SCHEMA_DEFINITIONS: Record<
secondary: { type: 'string' },
link: { type: 'string' },
accent: { type: 'string' },
response: { type: 'string' },
},
},
background: {
+3
View File
@@ -3880,6 +3880,9 @@
},
"accent": {
"type": "string"
},
"response": {
"type": "string"
}
}
},