mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-04-28 05:55:17 -07:00
fix(cli): add missing response key to custom theme text schema (#25822)
Co-authored-by: Adib234 <30782825+Adib234@users.noreply.github.com>
This commit is contained in:
@@ -298,6 +298,33 @@ describe('settings-validation', () => {
|
|||||||
expect(issue).toBeDefined();
|
expect(issue).toBeDefined();
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('should accept customThemes with text.response color override', () => {
|
||||||
|
// Regression test for #25610: `response` is a documented and
|
||||||
|
// implemented color override for model responses (see
|
||||||
|
// packages/cli/src/ui/themes/theme.ts and semantic-tokens.ts),
|
||||||
|
// but was missing from the CustomTheme validation schema.
|
||||||
|
const validSettings = {
|
||||||
|
ui: {
|
||||||
|
theme: 'LimeWhite',
|
||||||
|
customThemes: {
|
||||||
|
LimeWhite: {
|
||||||
|
type: 'custom',
|
||||||
|
name: 'LimeWhite',
|
||||||
|
text: {
|
||||||
|
primary: '#00FF00',
|
||||||
|
response: '#FFFFFF',
|
||||||
|
secondary: '#a0a0a0',
|
||||||
|
accent: '#00FF00',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
const result = validateSettings(validSettings);
|
||||||
|
expect(result.success).toBe(true);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('formatValidationError', () => {
|
describe('formatValidationError', () => {
|
||||||
|
|||||||
@@ -3278,6 +3278,7 @@ export const SETTINGS_SCHEMA_DEFINITIONS: Record<
|
|||||||
secondary: { type: 'string' },
|
secondary: { type: 'string' },
|
||||||
link: { type: 'string' },
|
link: { type: 'string' },
|
||||||
accent: { type: 'string' },
|
accent: { type: 'string' },
|
||||||
|
response: { type: 'string' },
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
background: {
|
background: {
|
||||||
|
|||||||
@@ -3880,6 +3880,9 @@
|
|||||||
},
|
},
|
||||||
"accent": {
|
"accent": {
|
||||||
"type": "string"
|
"type": "string"
|
||||||
|
},
|
||||||
|
"response": {
|
||||||
|
"type": "string"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|||||||
Reference in New Issue
Block a user