mirror of
https://github.com/google-gemini/gemini-cli.git
synced 2026-05-15 06:12:50 -07:00
# Improve Metric Accuracy for Issues, PRs, and Review Distribution
## 1. What the change is This PR refactors the `open_issues.ts` and `open_prs.ts` metric scripts to use the GitHub GraphQL API's `totalCount` field instead of relying on the CLI's `gh issue list` command with a hardcoded limit. It also updates `review_distribution.ts` to include `COLLABORATOR` in the maintainer association check. ## 2. Why it is recommended The current implementation of `open_issues.ts` and `open_prs.ts` used `--limit 1000`, which caused metrics to be capped at 1000 even when the actual backlog was much larger (~2400 issues). This provided a misleading view of repository health and the true scale of the backlog. Using GraphQL `totalCount` ensures accurate counts regardless of list size. Additionally, `review_distribution.ts` was inconsistently excluding `COLLABORATOR` associations, which could lead to an inaccurate representation of review work distribution if many maintainers are designated as Collaborators. This led to a `review_distribution_variance` of 0 in recent runs. ## 3. Which metric or aspect of productivity is expected to be improved - **open_issues**: Will now reflect the true total count (expected to jump from 1000 to ~2400). - **open_prs**: Will reflect the true total count of open pull requests. - **review_distribution_variance**: Will more accurately reflect how review work is shared among all maintainers (including collaborators). ## 4. By how much the metric is expected to improve The `open_issues` metric is expected to increase by approximately **140%** (from 1000 to ~2400) once accurate data is collected. The `review_distribution_variance` is expected to become non-zero, providing a real baseline for monitoring reviewer workload balance.
This commit is contained in:
@@ -35,10 +35,19 @@ try {
|
|||||||
}
|
}
|
||||||
`;
|
`;
|
||||||
const output = execSync(
|
const output = execSync(
|
||||||
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
||||||
{ encoding: 'utf-8', stdio: ['ignore', 'pipe', 'ignore'] },
|
{
|
||||||
|
encoding: 'utf-8',
|
||||||
|
input: query,
|
||||||
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
||||||
|
stdio: ['pipe', 'pipe', 'ignore'],
|
||||||
|
},
|
||||||
);
|
);
|
||||||
const data = JSON.parse(output).data.repository;
|
const response = JSON.parse(output);
|
||||||
|
if (response.errors) {
|
||||||
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
||||||
|
}
|
||||||
|
const data = response.data.repository;
|
||||||
|
|
||||||
// 2. Map PR numbers to local commits using git log
|
// 2. Map PR numbers to local commits using git log
|
||||||
const logOutput = execSync('git log -n 5000 --format="%H|%s"', {
|
const logOutput = execSync('git log -n 5000 --format="%H|%s"', {
|
||||||
@@ -97,7 +106,7 @@ try {
|
|||||||
const reviewersOnPR = new Map<string, { name?: string }>();
|
const reviewersOnPR = new Map<string, { name?: string }>();
|
||||||
for (const review of pr.reviews.nodes) {
|
for (const review of pr.reviews.nodes) {
|
||||||
if (
|
if (
|
||||||
['MEMBER', 'OWNER'].includes(review.authorAssociation) &&
|
['MEMBER', 'OWNER', 'COLLABORATOR'].includes(review.authorAssociation) &&
|
||||||
review.author?.login
|
review.author?.login
|
||||||
) {
|
) {
|
||||||
const login = review.author.login.toLowerCase();
|
const login = review.author.login.toLowerCase();
|
||||||
|
|||||||
@@ -31,10 +31,18 @@ try {
|
|||||||
}
|
}
|
||||||
`;
|
`;
|
||||||
const output = execSync(
|
const output = execSync(
|
||||||
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
||||||
{ encoding: 'utf-8' },
|
{
|
||||||
|
encoding: 'utf-8',
|
||||||
|
input: query,
|
||||||
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
||||||
|
},
|
||||||
);
|
);
|
||||||
const data = JSON.parse(output).data.repository;
|
const response = JSON.parse(output);
|
||||||
|
if (response.errors) {
|
||||||
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
||||||
|
}
|
||||||
|
const data = response.data.repository;
|
||||||
|
|
||||||
const prs = data.pullRequests.nodes.map(
|
const prs = data.pullRequests.nodes.map(
|
||||||
(p: {
|
(p: {
|
||||||
|
|||||||
@@ -4,17 +4,34 @@
|
|||||||
* SPDX-License-Identifier: Apache-2.0
|
* SPDX-License-Identifier: Apache-2.0
|
||||||
*/
|
*/
|
||||||
|
|
||||||
|
import { GITHUB_OWNER, GITHUB_REPO } from '../types.js';
|
||||||
import { execSync } from 'node:child_process';
|
import { execSync } from 'node:child_process';
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const count = execSync(
|
const query = `
|
||||||
'gh issue list --state open --limit 1000 --json number --jq length',
|
query($owner: String!, $repo: String!) {
|
||||||
|
repository(owner: $owner, name: $repo) {
|
||||||
|
issues(states: OPEN) {
|
||||||
|
totalCount
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
`;
|
||||||
|
const output = execSync(
|
||||||
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
||||||
{
|
{
|
||||||
encoding: 'utf-8',
|
encoding: 'utf-8',
|
||||||
|
input: query,
|
||||||
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
||||||
},
|
},
|
||||||
).trim();
|
);
|
||||||
|
const response = JSON.parse(output);
|
||||||
|
if (response.errors) {
|
||||||
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
||||||
|
}
|
||||||
|
const count = response.data.repository.issues.totalCount;
|
||||||
console.log(`open_issues,${count}`);
|
console.log(`open_issues,${count}`);
|
||||||
} catch {
|
} catch (err) {
|
||||||
// Fallback if gh fails or no issues found
|
process.stderr.write(err instanceof Error ? err.message : String(err));
|
||||||
console.log('open_issues,0');
|
process.exit(1);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -4,17 +4,34 @@
|
|||||||
* SPDX-License-Identifier: Apache-2.0
|
* SPDX-License-Identifier: Apache-2.0
|
||||||
*/
|
*/
|
||||||
|
|
||||||
|
import { GITHUB_OWNER, GITHUB_REPO } from '../types.js';
|
||||||
import { execSync } from 'node:child_process';
|
import { execSync } from 'node:child_process';
|
||||||
|
|
||||||
try {
|
try {
|
||||||
const count = execSync(
|
const query = `
|
||||||
'gh pr list --state open --limit 1000 --json number --jq length',
|
query($owner: String!, $repo: String!) {
|
||||||
|
repository(owner: $owner, name: $repo) {
|
||||||
|
pullRequests(states: OPEN) {
|
||||||
|
totalCount
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
`;
|
||||||
|
const output = execSync(
|
||||||
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
||||||
{
|
{
|
||||||
encoding: 'utf-8',
|
encoding: 'utf-8',
|
||||||
|
input: query,
|
||||||
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
||||||
},
|
},
|
||||||
).trim();
|
);
|
||||||
|
const response = JSON.parse(output);
|
||||||
|
if (response.errors) {
|
||||||
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
||||||
|
}
|
||||||
|
const count = response.data.repository.pullRequests.totalCount;
|
||||||
console.log(`open_prs,${count}`);
|
console.log(`open_prs,${count}`);
|
||||||
} catch {
|
} catch (err) {
|
||||||
// Fallback if gh fails or no PRs found
|
process.stderr.write(err instanceof Error ? err.message : String(err));
|
||||||
console.log('open_prs,0');
|
process.exit(1);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -27,10 +27,18 @@ try {
|
|||||||
}
|
}
|
||||||
`;
|
`;
|
||||||
const output = execSync(
|
const output = execSync(
|
||||||
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
||||||
{ encoding: 'utf-8' },
|
{
|
||||||
|
encoding: 'utf-8',
|
||||||
|
input: query,
|
||||||
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
||||||
|
},
|
||||||
);
|
);
|
||||||
const data = JSON.parse(output).data.repository;
|
const response = JSON.parse(output);
|
||||||
|
if (response.errors) {
|
||||||
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
||||||
|
}
|
||||||
|
const data = response.data.repository;
|
||||||
|
|
||||||
const reviewCounts: Record<string, number> = {};
|
const reviewCounts: Record<string, number> = {};
|
||||||
|
|
||||||
@@ -41,7 +49,7 @@ try {
|
|||||||
|
|
||||||
for (const review of pr.reviews.nodes) {
|
for (const review of pr.reviews.nodes) {
|
||||||
if (
|
if (
|
||||||
['MEMBER', 'OWNER'].includes(review.authorAssociation) &&
|
['MEMBER', 'OWNER', 'COLLABORATOR'].includes(review.authorAssociation) &&
|
||||||
review.author?.login
|
review.author?.login
|
||||||
) {
|
) {
|
||||||
const login = review.author.login.toLowerCase();
|
const login = review.author.login.toLowerCase();
|
||||||
|
|||||||
@@ -29,10 +29,18 @@ try {
|
|||||||
}
|
}
|
||||||
`;
|
`;
|
||||||
const output = execSync(
|
const output = execSync(
|
||||||
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
||||||
{ encoding: 'utf-8' },
|
{
|
||||||
|
encoding: 'utf-8',
|
||||||
|
input: query,
|
||||||
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
||||||
|
},
|
||||||
);
|
);
|
||||||
const data = JSON.parse(output).data.repository;
|
const response = JSON.parse(output);
|
||||||
|
if (response.errors) {
|
||||||
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
||||||
|
}
|
||||||
|
const data = response.data.repository;
|
||||||
|
|
||||||
const prs = data.pullRequests.nodes
|
const prs = data.pullRequests.nodes
|
||||||
.map((p: { authorAssociation: string; mergedAt: string }) => ({
|
.map((p: { authorAssociation: string; mergedAt: string }) => ({
|
||||||
|
|||||||
@@ -49,10 +49,18 @@ try {
|
|||||||
}
|
}
|
||||||
`;
|
`;
|
||||||
const output = execSync(
|
const output = execSync(
|
||||||
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
||||||
{ encoding: 'utf-8' },
|
{
|
||||||
|
encoding: 'utf-8',
|
||||||
|
input: query,
|
||||||
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
||||||
|
},
|
||||||
);
|
);
|
||||||
const data = JSON.parse(output).data.repository;
|
const response = JSON.parse(output);
|
||||||
|
if (response.errors) {
|
||||||
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
||||||
|
}
|
||||||
|
const data = response.data.repository;
|
||||||
|
|
||||||
const getFirstResponseTime = (item: {
|
const getFirstResponseTime = (item: {
|
||||||
createdAt: string;
|
createdAt: string;
|
||||||
|
|||||||
@@ -30,10 +30,18 @@ try {
|
|||||||
}
|
}
|
||||||
`;
|
`;
|
||||||
const output = execSync(
|
const output = execSync(
|
||||||
`gh api graphql -F owner=${GITHUB_OWNER} -F repo=${GITHUB_REPO} -f query='${query}'`,
|
'gh api graphql -F owner=$OWNER -F repo=$REPO -f query=@-',
|
||||||
{ encoding: 'utf-8' },
|
{
|
||||||
|
encoding: 'utf-8',
|
||||||
|
input: query,
|
||||||
|
env: { ...process.env, OWNER: GITHUB_OWNER, REPO: GITHUB_REPO },
|
||||||
|
},
|
||||||
);
|
);
|
||||||
const data = JSON.parse(output).data.repository;
|
const response = JSON.parse(output);
|
||||||
|
if (response.errors) {
|
||||||
|
throw new Error(response.errors.map((e: any) => e.message).join(', '));
|
||||||
|
}
|
||||||
|
const data = response.data.repository;
|
||||||
|
|
||||||
const prs = data.pullRequests.nodes;
|
const prs = data.pullRequests.nodes;
|
||||||
const issues = data.issues.nodes;
|
const issues = data.issues.nodes;
|
||||||
|
|||||||
Reference in New Issue
Block a user