test(cli): simplify createMockSettings calls (#22952)

This commit is contained in:
Tommaso Sciortino
2026-03-18 18:12:44 +00:00
committed by GitHub
parent fac3661980
commit a5a461c234
21 changed files with 145 additions and 365 deletions

View File

@@ -46,9 +46,7 @@ index 0000000..e69de29
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() =>
@@ -83,9 +81,7 @@ index 0000000..e69de29
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() =>
@@ -116,9 +112,7 @@ index 0000000..e69de29
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() =>
@@ -154,9 +148,7 @@ index 0000001..0000002 100644
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
// colorizeCode is used internally by the line-by-line rendering, not for the whole block
@@ -190,9 +182,7 @@ index 1234567..1234567 100644
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() => expect(lastFrame()).toBeDefined());
@@ -207,9 +197,7 @@ index 1234567..1234567 100644
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() => expect(lastFrame()).toBeDefined());
@@ -242,9 +230,7 @@ index 123..456 100644
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() => expect(lastFrame()).toContain('added line'));
@@ -281,9 +267,7 @@ index abc..def 100644
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() => expect(lastFrame()).toContain('context line 15'));
@@ -336,9 +320,7 @@ index 123..789 100644
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() => expect(lastFrame()).toContain('anotherNew'));
@@ -375,9 +357,7 @@ fileDiff Index: file.txt
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() => expect(lastFrame()).toContain('newVar'));
@@ -407,9 +387,7 @@ fileDiff Index: Dockerfile
</OverflowProvider>,
{
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitFor(() => expect(lastFrame()).toContain('RUN npm run build'));

View File

@@ -147,9 +147,7 @@ describe('<ShellToolMessage />', () => {
},
{
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
uiState: {
embeddedShellFocused: true,
activePtyId: 1,
@@ -164,9 +162,7 @@ describe('<ShellToolMessage />', () => {
},
{
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
uiState: {
embeddedShellFocused: false,
activePtyId: 1,
@@ -235,9 +231,7 @@ describe('<ShellToolMessage />', () => {
{
uiActions,
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
uiState: {
activePtyId: focused ? 1 : 2,
embeddedShellFocused: focused,
@@ -266,9 +260,7 @@ describe('<ShellToolMessage />', () => {
{
uiActions,
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);
@@ -293,9 +285,7 @@ describe('<ShellToolMessage />', () => {
{
uiActions,
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
uiState: {
constrainHeight: false,
},
@@ -325,9 +315,7 @@ describe('<ShellToolMessage />', () => {
{
uiActions,
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
uiState: {
constrainHeight: false,
},

View File

@@ -65,14 +65,10 @@ describe('<ToolGroupMessage />', () => {
enableInteractiveShell: true,
});
const fullVerbositySettings = createMockSettings({
merged: {
ui: { errorVerbosity: 'full' },
},
ui: { errorVerbosity: 'full' },
});
const lowVerbositySettings = createMockSettings({
merged: {
ui: { errorVerbosity: 'low' },
},
ui: { errorVerbosity: 'low' },
});
describe('Golden Snapshots', () => {

View File

@@ -465,9 +465,7 @@ describe('<ToolMessage />', () => {
},
width: 80,
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);
await waitUntilReady();
@@ -501,9 +499,7 @@ describe('<ToolMessage />', () => {
uiState: { streamingState: StreamingState.Idle },
width: 80,
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);
await waitUntilReady();
@@ -532,9 +528,7 @@ describe('<ToolMessage />', () => {
uiState: { streamingState: StreamingState.Idle },
width: 80,
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);
await waitUntilReady();

View File

@@ -74,9 +74,7 @@ describe('<ToolMessage /> - Raw Markdown Display Snapshots', () => {
{
uiState: { renderMarkdown, streamingState: StreamingState.Idle },
config: makeFakeConfig({ useAlternateBuffer }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer } }),
},
);
await waitUntilReady();

View File

@@ -58,9 +58,7 @@ describe('ToolOverflowConsistencyChecks: ToolGroupMessage and ToolResultDisplay
constrainHeight: true,
},
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
},
);
@@ -111,9 +109,7 @@ describe('ToolOverflowConsistencyChecks: ToolGroupMessage and ToolResultDisplay
constrainHeight: true,
},
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);

View File

@@ -39,9 +39,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
},
);
await waitUntilReady();
@@ -60,9 +58,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
},
);
await waitUntilReady();
@@ -82,9 +78,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
},
);
await waitUntilReady();
@@ -98,9 +92,7 @@ describe('ToolResultDisplay', () => {
<ToolResultDisplay resultDisplay="**Some result**" terminalWidth={80} />,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);
await waitUntilReady();
@@ -120,9 +112,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
uiState: { constrainHeight: true },
},
);
@@ -143,9 +133,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
uiState: { constrainHeight: true },
},
);
@@ -169,9 +157,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);
await waitUntilReady();
@@ -204,9 +190,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);
await waitUntilReady();
@@ -228,9 +212,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
},
);
await waitUntilReady();
@@ -251,9 +233,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
uiState: { constrainHeight: true },
},
);
@@ -273,9 +253,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: true }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: true } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: true } }),
},
);
await waitUntilReady();
@@ -357,9 +335,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
uiState: { constrainHeight: true },
},
);
@@ -396,9 +372,7 @@ describe('ToolResultDisplay', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
uiState: { constrainHeight: true },
},
);

View File

@@ -22,9 +22,7 @@ describe('ToolResultDisplay Overflow', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
uiState: { constrainHeight: true },
},
);
@@ -51,9 +49,7 @@ describe('ToolResultDisplay Overflow', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
uiState: { constrainHeight: true },
},
);
@@ -91,9 +87,7 @@ describe('ToolResultDisplay Overflow', () => {
/>,
{
config: makeFakeConfig({ useAlternateBuffer: false }),
settings: createMockSettings({
merged: { ui: { useAlternateBuffer: false } },
}),
settings: createMockSettings({ ui: { useAlternateBuffer: false } }),
uiState: { constrainHeight: true },
},
);